August 2008 - Wine-devel - list.winehq.org

Re: dpnet: Add stubbed DirectPlay8Peer interface (try2)
by Alexandre Julliard 21 Aug '08

21 Aug '08

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > HRESULT DPNET_CreateDirectPlay8Peer(LPCLASSFACTORY iface, LPUNKNOWN punkOuter, REFIID riid, LPVOID *ppobj) { > - WARN("(%p, %s, %p): stub.\n", punkOuter, debugstr_guid(riid), ppobj); > - return CLASS_E_CLASSNOTAVAILABLE; > + IDirectPlay8PeerImpl* Client; > + > + Client = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectPlay8PeerImpl)); > + > + if(Client == NULL) > + { > + *ppobj = NULL; > + WARN("Not enough memory\n"); > + return E_OUTOFMEMORY; > + } > + > + Client->lpVtbl = &DirectPlay8Peer_Vtbl; > + return IDirectPlay8PeerImpl_QueryInterface((PDIRECTPLAY8PEER)Client, riid, ppobj); You are leaking the object on error. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: fix error setting in FindWindow
by Dmitry Timoshkov 21 Aug '08

21 Aug '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -1613,6 +1613,7 @@ HWND WINAPI FindWindowExW( HWND parent, HWND child, LPCWSTR className, LPCWSTR t > done: > HeapFree( GetProcessHeap(), 0, list ); > HeapFree( GetProcessHeap(), 0, buffer ); > + if(!retvalue) SetLastError(ERROR_FILE_NOT_FOUND); > return retvalue; > } The prevailing indentation style in this file is to have a space after 'if', i.e. use 'if (!retvalue)'. > HWND WINAPI FindWindowA( LPCSTR className, LPCSTR title ) > { > HWND ret = FindWindowExA( 0, 0, className, title ); > - if (!ret) SetLastError (ERROR_CANNOT_FIND_WND_CLASS); > return ret; > } Changing the whole block to just return FindWindowExA( 0, 0, className, title ); would be more logical. -- Dmitry.

1 0

user32: Fix hook_proc DLL loading using LoadLibraryExW instead of LoadLibraryW
by Hongbo Ni 21 Aug '08

21 Aug '08

> >This patch fixes Bug 14784. > >As requested by Dmitry Timoshkov, I have created a standalone test case >for DLL injection via SetWindowHookEx. It has been attached in Bug 14784 >with MSVC source code and compiled exe and dll. > >With LoadLibraryExW(module, NULL, LOAD_WITH_ALTERED_SEARCH_PATH), the >Wine will search any imported DLL first in the same directory as module, >then in the standard search path. > >LoadLibraryW(module) searches imported DLL(s) in the directory of current >process, which may not be the same process where the module is first >loaded. That is why that LoadLibraryW(module) fails to hook to another >process if the DLL containing the hook_proc links to another DLL(s) in >the same directory. > >--- > dlls/user32/hook.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/dlls/user32/hook.c b/dlls/user32/hook.c >index 4354e05..638a302 100644 >--- a/dlls/user32/hook.c >+++ b/dlls/user32/hook.c >@@ -322,7 +322,7 @@ void *get_hook_proc( void *proc, const WCHAR *module ) > { > TRACE( "loading %s\n", debugstr_w(module) ); > /* FIXME: the library will never be freed */ >- if (!(mod = LoadLibraryW(module))) return NULL; >+ if (!(mod = LoadLibraryExW(module, NULL, LOAD_WITH_ALTERED_SEARCH_PATH))) return NULL; > } > return (char *)mod + (ULONG_PTR)proc; > } >-- Is there any problems with this patch? Hongbo Ni <hongbo(a)njstar.com> +----------------------------------------------------------------+ * NJStar Software Corp., P.O. Box 40, Epping NSW 2121, Australia. * Tel: +61-2-9869-1088 WebSite: http://www.njstar.com * Fax: +61-2-9869-1099 Email: http://njstar.com/contact/ * eFax: +1-253-595-4788 +----------------------------------------------------------------+

1 0

Running a conformance test on windows before submitting to wine-patches.
by Scott Lindeneau 21 Aug '08

21 Aug '08

I would like to submit the following AcceptEx conformance test to wine-patches, but I don't have a windows box (and i haven't got qemu setup(correctly) yet). Would someone run this and let me know how/if it failes (or succeeds... it should succeed). Thanks - Scott

3 2

Re: [PATCH] comctl32: Set listview focus on WM_LBUTTONUP instead of WM_LBUTTONDOWN.
by Lei Zhang 21 Aug '08

21 Aug '08

On Mon, Aug 18, 2008 at 4:08 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This should fix bug 14908. > Any problems with this patch?

1 0

Re: Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.
by Eric Pouech 20 Aug '08

20 Aug '08

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: 5cb8bccf462790338677dac3bfb394df8f4da020 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac3b… > > Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> > Date: Sun Aug 10 12:43:06 2008 +0200 > > regedit: Convert printing&help to unicode. > > --- > > programs/regedit/framewnd.c | 25 +++++++++++++++++-------- > 1 files changed, 17 insertions(+), 8 deletions(-) > > @@ -671,8 +671,11 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > case ID_REGISTRY_DISCONNECTNETWORKREGISTRY: > break; > case ID_REGISTRY_PRINT: > - PrintRegistryHive(hWnd, _T("")); > + { > + const WCHAR empty = 0; > + PrintRegistryHive(hWnd, empty); > break; > + } > this looks very wrong to me -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 4

AcceptEx patch series notes
by Dan Kegel 20 Aug '08

20 Aug '08

Hi Scott. A few notes about your patch series. There should be no forward references in the patches; you can't have patch 1 depend on patch 2. Also, don't send two versions of tests, one for Wine and one for Windows; the same code has to work in both places. You can't even use an ifdef, since the windows .exe has to pass on wine. You can use a runtime test, perhaps, to skip some tests on Wine, but that's about it.

1 0

Re: Running a conformance test on windows before submitting to wine-patches.
by Scott Lindeneau 20 Aug '08

20 Aug '08

Sorry about not knowing how to cross compile before. Here is the patch(gmail doesn't let me attach exe's... I will look into this). Please try this. Tell me if I am doing something wrong (again). -Scott

3 5

re: d3dx9: Implementation of D3DXGetDeclLength
by dank＠kegel.com 20 Aug '08

20 Aug '08

http://kegel.com/wine/patchwatcher/results/ says you forgot to include the new file include/d3dx9mesh.h this time; you included it in http://www.winehq.org/pipermail/wine-patches/2008-August/059261.html but some how dropped it when you resent?

1 0

Re: Running a conformance test on windows before submitting to wine-patches.
by Scott Lindeneau 20 Aug '08

20 Aug '08

It did. I wrote the test using a different set of patches which let it compile with wine. I will look up how to cross compile it and do that next time. Sorry for the inconvenience. On Thu, Aug 21, 2008 at 2:36 AM, Austin English <austinenglish(a)gmail.com> wrote: > On Wed, Aug 20, 2008 at 12:34 PM, Scott Lindeneau <slindeneau(a)gmail.com> wrote: >> I don't think so? I've never written a conformance test before. I did >> implement AcceptEx in wine, but it shouldn't need that patch to >> compile for windows should it? Or maybe I need to load it into memory >> instead of just calling it first... Terribly sorry. I'm making myself >> a nuisance. I will try writing it using the windows WSAIoctl call to >> load it into memory first. MSDN does say I need that. >> >> -Scott >> >> >> On Thu, Aug 21, 2008 at 2:29 AM, Austin English <austinenglish(a)gmail.com> wrote: >>> On Wed, Aug 20, 2008 at 12:23 PM, Scott Lindeneau <slindeneau(a)gmail.com> wrote: >>>> I would like to submit the following AcceptEx conformance test to >>>> wine-patches, but I don't have a windows box (and i haven't got qemu >>>> setup(correctly) yet). Would someone run this and let me know how/if >>>> it failes (or succeeds... it should succeed). >>>> >>>> Thanks >>>> - Scott >>>> >>>> >>>> >>>> >>> >>> Does it depend on another patch: >>> >>> austin(a)SERVER1:~/wine-git/dlls/ws2_32/tests$ make crosstest >>> i586-mingw32msvc-gcc protocol.cross.o sock.cross.o >>> testlist.cross.o -o ws2_32_crosstest.exe -L../../../dlls >>> -L../../../dlls/ws2_32 -L../../../dlls/kernel32 -lws2_32 -lkernel32 >>> sock.cross.o: In function >>> `overlapped_server':/home/austin/wine-git/dlls/ws2_32/tests/sock.c:633: >>> undefined reference to `_AcceptEx(a)32' >>> :/home/austin/wine-git/dlls/ws2_32/tests/sock.c:677: undefined >>> reference to `_GetAcceptExSockaddrs(a)32' >>> collect2: ld returned 1 exit status >>> make: *** [ws2_32_crosstest.exe] Error 1 >>> >> > > Please bottom post on wine-devel. > > In the future, sending a compiled exe is helpful, saves time. Does it > even past make test for you? > > > austin(a)SERVER1:~/wine-git/dlls/ws2_32/tests$ make test > ccache gcc -c -I. -I. -I../../../include -I../../../include > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 > -o protocol.o protocol.c > ccache gcc -c -I. -I. -I../../../include -I../../../include > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 > -o sock.o sock.c > sock.c: In function âoverlapped_serverâ: > sock.c:670: warning: pointer targets in passing argument 3 of > âGetOverlappedResultâ differ in signedness > ccache gcc -c -I. -I. -I../../../include -I../../../include > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 > -o testlist.o testlist.c > ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole > protocol.o sock.o testlist.o -o ws2_32_test.exe.so > ../../../libs/port/libwine_port.a -lws2_32 -lkernel32 > sock.o: In function `overlapped_server': > /home/austin/wine-git/dlls/ws2_32/tests/sock.c:633: undefined > reference to `AcceptEx' > /home/austin/wine-git/dlls/ws2_32/tests/sock.c:677: undefined > reference to `GetAcceptExSockaddrs' > collect2: ld returned 1 exit status > winegcc: ccache failed > make: *** [ws2_32_test.exe.so] Error 2 >

1 0