August 2008 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] mstask: Implemented CreateTrigger.
by Roy Shea 22 Aug '08

22 Aug '08

> dlls/mstask/task.c | 4 ++-- > dlls/mstask/tests/task.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Please disregard this and the subsequent patch in the set. Patchwatecher found a few incorrect todo_wine statements that I forgot to remove. A revised version of the two patches has been resubmitted. Peace, -Roy

1 0

Re: user32: fix error setting in FindWindow (try 2)
by Alexandre Julliard 22 Aug '08

22 Aug '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 1964e88..246347f 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void) > SetLastError(0xdeadbeef); > found = FindWindowExA( GetDesktopWindow(), 0, 0, "message window" ); > ok( found == 0, "found message window %p/%p\n", found, hwnd ); > - todo_wine > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); Have you tried your test on Windows? According to the test results there isn't any Windows version that sets last error here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Spore patch to fix UI and Part descriptions
by Marcus Meissner 22 Aug '08

22 Aug '08

On Fri, Aug 22, 2008 at 02:51:56PM +0700, Andrew Fenn wrote: > I made a new patch this time including a test. > > I put in some extra checking in SetScissorRect making sure that if > rect was null or it was an invalid rectangle that it was returned as > invalid as it should be. > > I'm not able to do a test on windows so if anyone does one please let > me know if there are any problems. Also please tell me if you spot any > problems with this patch. > > --- a/dlls/d3d9/device.c > +++ b/dlls/d3d9/device.c > @@ -746,7 +746,8 @@ static HRESULT WINAPI IDirect3DDevice9Impl_GetDepthStencilSurface(LPDIRECT3DDE > } > } else { > WARN("Call to IWineD3DDevice_GetDepthStencilSurface failed\n"); > - *ppZStencilSurface = NULL; > + /* *ppZStencilSurface = NULL; */ > + return D3DERR_NOTFOUND; > } > LeaveCriticalSection(&d3d9_cs); > return hr; Again, you should likely add a LeaveCriticalSection(&d3d9_cs); to the error return too. Or just set hr = D3DERR_NOTFOUND; and fall through. Ciao, Marcus

1 0

Re: [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed)
by Vincent Povirk 22 Aug '08

22 Aug '08

Why doesn't the WM_DESTROY case handle this properly? At first glance, it appears to have code for stopping the running applets and quitting from the main loop. Calling ExitProcess from WM_CLOSE is anything but graceful. Vincent Povirk On Thu, Aug 21, 2008 at 2:25 PM, Steven Edwards <winehacker(a)gmail.com> wrote: > This time without the TAB/space mixup > > Without this patch, if you have the Control Panel window open along > with an applet and you try to close the Panel window, you get a very > nice crash. This forces an exit with a little grace > > Changelog: > shell32 - handle WM_CLOSE in the Control Panel window > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > > >

3 6

re: patches
by Dan Kegel 22 Aug '08

22 Aug '08

Louis wrote: > Hi, apparently none of my patches is making it into git, nor did i recieve any response from Alexandre about what's wrong with them. I guess i'm kind of "blacklisted" I don't think so. LOTS of people, me included, have trouble getting patches into git. You just have to have patience, try to figure out what needs improving, and keep at it. Michael Karcher already gave you some good feedback: http://winehq.org/pipermail/wine-devel/2008-August/068280.html I don't think you've followed up on that yet. And when in doubt, it never hurts to rediff and clean up your patch series and resend. Maintainers like Alexandre often get overwhelmed by incoming email. Linus Torvalds even said that he simply deletes his inbox when it gets too full, and that people who are serious about wanting their patches in will resend. This is probably true of Alexandre, especially after he gets back from a two week vacation, as he just did. - Dan

1 0

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)
by James Hawkins 21 Aug '08

21 Aug '08

On Mon, Aug 18, 2008 at 4:18 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > (the return TRUE statement got lost from last patch, thanks Michael for > noticing) > > > Hi, this fixes Adobe Lightroom 2.0 start up bug, mentioned in > http://bugs.winehq.org/show_bug.cgi?id=8224#c4 > > as long wine doesn't handle with volume mount points, it's probably safe to > satisfy most apps. > > (A simple google for > "fixme:volume:GetVolumePathNameW" > revealed only about 3 apps , and "fixme:volume:GetVolumePathNameA" revealed > zero hits, so for now the use of this api seems not really wide-spread, and > no need to touch GetVolumePathNameA i guess) > + /* As long as we don't handle volumemountpoints, and filename is something like "X:\\blabla\\bla", it's probably safe to return "X:\" for + now to keep some applications happy */ + Please get rid of this comment. + if(strlenW(filename)>=3 && filename[1] == ':' && filename[2] == '\\' && buflen >3) + { + lstrcpynW(volumepathname,filename,4); + return TRUE; + } You've handled *a* successful case, but what about the error case? Also, you're copying 4 bytes of filename into volumepathname. I don't think you understand what lstrcpyn does. Imagine this case: volumepathname = "aaaaaaaa" buflen = 8 filename = "C:\\file" After the call to lstrcpyn: volumepathname = "C:\\faaaa" -- James Hawkins

3 3

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)
by Louis. Lenders 21 Aug '08

21 Aug '08

----- Original Message ---- From: James Hawkins <truiken(a)gmail.com> To: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> Cc: wine-devel(a)winehq.org Sent: Thursday, 21 August, 2008 3:55:07 PM Subject: Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4) >That whole paragraphs reads "hack now, fix later", which is definitely >not acceptable. Well, I would call it a "semi-stub", there's more of them scattered all over the wine-source. But if opinions are it's too hackish, that's fine with me, I was only trying to help a user to get an app running > > + { > + lstrcpynW(volumepathname,filename,4); > + return TRUE; > + } > > >>Also, you're copying 4 bytes of filename into volumepathname. I don't >>think you understand what lstrcpyn does. Imagine this case: > > volumepathname = "aaaaaaaa" > buflen = > 8 > filename = "C:\\file" > > After the call to lstrcpyn: > > volumepathname = "C:\\faaaa" > > > > MSDN says volumepathname was a pointer to an "out" - string, so how would it > become someting > like "aaaaaa", or am i overseeing something? > Yes you are overseeing something. I think it would be a good idea if you read up a bit more on C in your spare time. I get the feeling you don't quite have a grasp on the intricacies of the language, particularly pointers and strings. What I meant is, why would an app set volumepathname to "aaaaaa", as it's the pointer where it expects to find the volumepoint, so on windows this would be filled by kernel32.dll, not by the app. Maybe you mean this could be the case after a second call to GetVolumePathName? Anyway, this is not the place to discuss a C-language course so I'll reread the docs. Thanks for the comments anyway. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 1

re: [6/6][PATCH]Updates WSAIoctl in ws2_32 to return AcceptEx and GetAcceptExSockaddrs
by Dan Kegel 21 Aug '08

21 Aug '08

slindeneau at gmail.com wrote: > This patch will allow the patch [1/6] to successfully complete on wine > and windows. Prior to this patch the conformance tests submitted in > [1/6] of this series will fail on wine. It's exciting to see such progress on AcceptEx! But the wine project likes to have all tests passing after each patch in a series. If patch 1/6 adds tests that fail on Wine, they need to be marked with todo_wine. If patch 6/6 fixes the problem in wine that caused those tests to fail, it should also remove the todo_wine from the test. Following this rule will help make sure your patches don't turn red on http://kegel.com/wine/patchwatcher/results/

2 1

Re:kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)
by Louis. Lenders 21 Aug '08

21 Aug '08

>You've handled *a* successful case, but what about the error case? As i said already in the mail with the patch, it might be *a* case, but this is the case that most apps will follow as far as i can see. Futhermore, when apps are really crashing into the other cases, it can be added later on i.m.o. For now they will just fall back to the current "implementation", returning "not implmented" then, so there will be no differnce with current behaviour. + { + lstrcpynW(volumepathname,filename,4); + return TRUE; + } >Also, you're copying 4 bytes of filename into volumepathname. I don't >think you understand what lstrcpyn does. Imagine this case: volumepathname = "aaaaaaaa" buflen = 8 filename = "C:\\file" After the call to lstrcpyn: volumepathname = "C:\\faaaa" MSDN says volumepathname was a pointer to an "out" - string, so how would it become someting like "aaaaaa", or am i overseeing something? Send instant messages to your online friends http://uk.messenger.yahoo.com

2 1

Re:shobjidl.idl: add Taskbarlist interface defenitions
by Louis. Lenders 21 Aug '08

21 Aug '08

>The "I'll send the rest later" is a warning light. You should further develop this and send it all later so >we know this is actually going somewhere. The whole patch, that lets Governor of Poker start i have attached to the bug http://bugs.winehq.org/attachment.cgi?id=15297 a few weeks ago. As i said before , it's enough to stub out interface calls like in that patch to let the game start I discovered later I put the headers in the wrong (seperate ) header file, so i thought first to send in the definitions in the correct header. I thought later on send the rest in small pieces thanks again for the review Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0