August 2008 - Wine-devel - list.winehq.org

What to do when size of the struct differs on 32 and 64 bit?
by Vitaliy Margolen 21 Sep '08

21 Sep '08

While debugging some force-feedback issues ran into an interesting problem. The size of one struct from include/linux differs between 32-bit and 64-bit. That wouldn't be a major problem except that size is the part of the ioctl() request. Which results in EINVAL. In more details: input.h: #define EVIOCSFF _IOC(_IOC_WRITE, 'E', 0x80, sizeof(struct ff_effect)) The simple test program: #include <linux/input.h> #include <stdio.h> int main(int argc, char * argv[]) { printf("sizeof(struct ff_effect) = %d EVIOCSFF=%#x\n", sizeof(struct ff_effect), EVIOCSFF); return 0; } $ gcc test_size.c -o test_size && ./test_size sizeof(struct ff_effect) = 48 EVIOCSFF=0x40304580 $ gcc -m32 test_size.c -o test_size32 && ./test_size32 sizeof(struct ff_effect) = 44 EVIOCSFF=0x402c4580 The question is what do we do about it? I'm sure there are might be more cases like that. Vitaliy

6 6

Adding Flawfinder to Patchwatcher
by Austin English 09 Sep '08

09 Sep '08

I had a discussion with Dan about adding Flawfinder to the patchwatcher. Currently, it's got some pretty generic errors, but it seems able to test only patches, so we wouldn't be flooded with old nonbugs (or we could set up a blacklist of safe errors). For reference, I've run it on today's git. I'm attaching the full log, as well as a condensed version of the most common errors (1 per error type). Looks like a lot of chances for buffer overflows.. Thoughts? -Austin

15 19

Re: imm32: Improve ImmGetCompositionString.
by Paul Vriens 08 Sep '08

08 Sep '08

Aric Stewart wrote: > > It should return number of copied bytes. But it always returns required > buffer size to receive all information. > (originally by Kusanagi Kouichi (slash(a)ma.neweb.ne.jp) ) > --- > dlls/imm32/imm.c | 207 > ++++++++++++++++++++++++++++++++++-------------------- > 1 files changed, 130 insertions(+), 77 deletions(-) > > > > ------------------------------------------------------------------------ > > Shouldn't patches like these be accompanied by tests? It changes the behavior after all. -- Cheers, Paul.

2 1

Re: ntdll/file: Add sub-second resolution to NtQueryInformationFile
by Detlef Riekenberg 04 Sep '08

04 Sep '08

On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote: > --- > configure | 303 > +++++++++++++++++++++++++++++++++++++++++++++++++++ You should never include autogenerated code in a Patch. This will reduce the risk, that your Patch does not apply after a different Patch was commited. -- By by ... Detlef

6 5

Implementing textures functions of d3dx using an extern library.
by Jérôme Gardou 02 Sep '08

02 Sep '08

It appears this mail did not get in, so I resend it... ---------- Forwarded message ---------- From: Jérôme Gardou <jerome.gardou(a)gmail.com> Date: 2008/8/26 Subject: Implementing textures functions of d3dx using an extern library. To: wine-devel(a)winehq.org D3DX supports a wide range of file types for textures. Instead of rewriting everything from scratch, the best would certainly be to use some image processing library to handle them. As a bonus, this would allow lighter code. Some of those library are : SDL_Image : easy to use, but loading an image using a SDL_Surface is quite heavy. Moreover, the files supported are not enough for d3dx. MagickWand/MagickCore, the libraries on which imagemagick is based : Hard to use, and very heavy. Supports every format thet d3dx supports. FreeImage : Quite easy to use, the only files not supported are DIB and PFM... Not so widely represented. I had to recompile it, as packages for it are not available for 32 bits. (I use a 64 bits ubuntu system). Here is an implementation of D3DXGetImageInfoFromFileInMemory using FreeImage. Suggestions and comments are welcomed. PS : Please CC me your potential answers, as I'm not a subscriber of this list.

2 1

Re: Patch for font size = 0x7fff in dialog templates
by Koro 02 Sep '08

02 Sep '08

> This is a patch that fixes a discrepancy between WINE's dialog manager > and the real Windows one. If, in a dialog template, (assuming DS_SETFONT > is set) the font size is 0x7fff, it means that the dialog manager must > use the message box font and not read the rest of the font data > (facename and others) off the template. > > This quirk is "documented" in a comment there, and I have myself > confirmed this behavior with some of my code a few months ago: > http://blogs.msdn.com/oldnewthing/archive/2005/04/29/412577.aspx#413552 > > Sending patch as attachment because putting it inline would probably > word-wrap it all over the place. What was wrong with my patch? I never heard of it again, and last time I checked http://source.winehq.org/source/dlls/user32/dialog.c it still wasn't there.

2 1

Recent msi/package tests failures
by Paul Vriens 01 Sep '08

01 Sep '08

Hi, I was looking into the recent test failures for the msi/package tests on my WinXP box. The reason for most of them was a stray MSITEST package that couldn't be removed via the 'Add/Remove Programs' (had to remove stuff from the registry). Any one else seeing this? (Adam Petaccia's XP box has the same issue I guess). -- Cheers, Paul.

5 12

RE: Fix for rendering issues when calling GetDepthStencilSurface
by Stefan Dösinger 01 Sep '08

01 Sep '08

> When IWineD3DDevice_GetDepthStencilSurface returns WINED3DERR_NOTFOUND > it was setting ppZStencilSurface to null. This was the cause of > rendering issues with the 3d models in spore. Can you write a test for this? I think we have some depth stencil tests in dlls/d3d9/tests/device.c which you could use to test this. I think you are right with this patch - I vaguely remember writing a test for a different getter function, but it is better to be sure

3 4

Problems Running Windows app
by Chris Vermeulen 01 Sep '08

01 Sep '08

Hi Please help me I'm currently running ubuntu 8.04, with wine 1.0 I've got a program that I use to program Telephone systems. It uses a SQL database with a web interface. but I can't get this to work on wine, if I want to install it gives me the following and just closes. Usage: Install a product: msiexec {package|productcode} [property] msiexec /i {package|productcode} [property] msiexec /a package [property] Repair an installation: msiexec /f[p|o|e|d|c|a|u|m|s|v] {package|productcode} Uninstall a product: msiexec /x {package|productcode} [property] Advertise a product: msiexec /j[u|m] package [/t transform] [/g languageid] msiexec {u|m} package [/t transform] [/g languageid] Apply a patch: msiexec /p patchpackage [property] msiexec /p patchpackage /a package [property] Modifiers for above operations: msiexec /l[*][i|w|e|a|r|u|c|m|o|p|v|][+|!] logfile msiexec /q{|n|b|r|f|n+|b+|b-} Register a module: msiexec /y module Unregister a module: msiexec /z module Display usage and copyright: msiexec {/h|/?} NOTE: Product code on commandline unimplemented as of yet Copyright 2004 Vincent B�ron Please help I'm hate this dual booting into windows. If I can get this working It'll be like a huge Christmas gift. If you need the program let me know and I'll get it to you Thanks Chris Vermeulen ##################################################################################### Notice This e-mail message and/or attachments may contain information that is confidential to ITEC and/or any of its affiliated companies. If you are not the intended recipient you cannot use, distribute or copy the message and/or attachments. In such a case, please notify the sender by return e-mail immediately and erase all copies of the message and/or attachments. Opinions, conclusions and other information in this message and/or attachments that do not relate to the official business of ITEC or any of its affiliated companies are neither given nor endorsed by it. ITEC and its affiliated companies accept no liability or responsibility of whatever nature for any failure or loss arising from the use of email as a form of communication. #####################################################################################

2 1

Re: kernel32/winerror [try 3]: Add Russian translation
by Dmitry Timoshkov 31 Aug '08

31 Aug '08

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation for winerrors. > > Added dlls/kernel32/nls/winerror_rus.mc file. > Changed files: > dlls/kernel32/kernel.rc > dlls/kernel32/Makefile.in What's the point in resending the patch without changing anything in it, or at least answering the questions? -- Dmitry.

1 0