August 2008 - Wine-devel - list.winehq.org

Patch formatting question: how picky should the robot be?
by Dan Kegel 12 Aug '08

12 Aug '08

So, git generates patches like this: diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c index da66e2e..4569997 100644 --- a/dlls/ddraw/tests/dsurface.c +++ b/dlls/ddraw/tests/dsurface.c and that's the way we like it. And sometimes people generate patches with cvs, like http://winehq.org/pipermail/wine-patches/2008-August/059403.html diff -u -3 -p -r1.57 vga.c --- dlls/winedos/vga.c 14 Jul 2008 10:57:58 -0000 1.57 +++ dlls/winedos/vga.c 27 Jul 2008 23:13:08 -0000 (That even used to be the way we liked it.) That's ok, too, isn't it? If so, I'll make sure my patch robot can handle it. But what about patches like http://winehq.org/pipermail/wine-patches/2008-August/059404.html --- dlls/appwiz.cpl/appwiz.rc 2008-07-26 09:24:56.000000000 +0900 +++ appwiz.rc 2008-07-28 09:48:00.000000000 +0900 ... --- /dev/null 2008-07-28 09:27:06.210506864 +0900 +++ Ko.rc 2008-07-28 09:48:00.000000000 +0900 The patch robot should probably complain about those, right? - Dan

3 3

Crashing tests for WinHttp
by Zac Brown 11 Aug '08

11 Aug '08

Hi all, Dan Kegel pointed out to me a couple of tests for WinHttp were reported as crashing in Wine, build 520ab5c26170 (the latest). Would the owners of machines "2000 wine-1.1.2" and "XP th" please shoot me an email. I'd like to see if I can reproduce the crash in wine. For better reference, its the machines in the first and last column on this page: http://test.winehq.org/data/520ab5c261706f6118a85a82ba84213932ba76e7/#group… Thanks, Zac

1 0

Is Wine portable to ARM arch?
by Tomasz Czapiewski 11 Aug '08

11 Aug '08

I wonder if someone has done successfull port of Wine for mobile/PDA Linux distributions on hardware with ARM processors. Is it possible? If no then are there any plans for multiplatform code in Wine? There are many Linux users of such hardware (like Neo FreeRunner etc.) which would like to use Windows applications on their portable ARM-based devices. Kind Regards, Tom

4 3

RE: [PATCH 04/10] ddraw/dsurface_thunks: Add typesafe inline conversion functions.
by Stefan Dösinger 11 Aug '08

11 Aug '08

> Do you see a chance to get such a change committed? It's hard to tell; I think you should ask Alexandre once he's back from vacation

1 0

Re: rpcrt4: Dynamically load iphlpapi
by Rob Shearman 11 Aug '08

11 Aug '08

2008/8/5 Juan Lang <juan.lang(a)gmail.com>: > This has a similar motivation to the last patch I sent. In rpcrt4's > case, iphlpapi is needed at most once per process, so dynamically load > it rather than keeping it around all the time. > @@ -304,18 +304,23 @@ #define ADDRESS_BYTES_NEEDED 6 > > static RPC_STATUS RPC_UuidGetNodeAddress(BYTE *address) > { > + static const WCHAR iphlpapi[] = { 'i','p','h','l','p','a','p','i',0 }; > int i; > DWORD status = RPC_S_OK; > > ULONG buflen = sizeof(IP_ADAPTER_INFO); > PIP_ADAPTER_INFO adapter = HeapAlloc(GetProcessHeap(), 0, buflen); > + HMODULE lib = LoadLibraryW(iphlpapi); > + DWORD (WINAPI *pGetAdaptersInfo)(PIP_ADAPTER_INFO, PULONG) = NULL; Hi Juan, Why manually load iphlpapi here instead of using the automatic delayed import mechanism like you used for ws2_32? I assume it was because you reasoned that a hard dependency was unnecessary because the code has a fallback path, but I think you needed to make this clear in the changelog. -- Rob Shearman

2 2

RE: [PATCH 04/10] ddraw/dsurface_thunks: Add typesafe inline conversion functions.
by Stefan Dösinger 11 Aug '08

11 Aug '08

I think it is better to replace the whole macros in ddcomimpl.h with inline functions. This is also what Alexandre asked for some time ago, but I was too lazy to implement it > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Michael Karcher > Sent: Sunday, August 10, 2008 4:20 PM > To: wine-patches(a)winehq.org > Subject: [PATCH 04/10] ddraw/dsurface_thunks: Add typesafe inline > conversion functions. > > These are going to replace the CONVERT/CONVERT_REV macros. > --- > dlls/ddraw/surface_thunks.c | 54 > +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 54 insertions(+), 0 deletions(-)

1 0

RE: [PATCH 03/10] ddraw/surface: Made IDirectDrawSurfaceImpl methods non-static.
by Stefan Dösinger 11 Aug '08

11 Aug '08

I think you should put the things from surface_impl.h into ddraw_private.h > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Michael Karcher > Sent: Sunday, August 10, 2008 4:20 PM > To: wine-patches(a)winehq.org > Subject: [PATCH 03/10] ddraw/surface: Made IDirectDrawSurfaceImpl > methods non-static. > > This allows direct calls from surface_thunks.c. IMHO there is no point > in letting the call from the thunk to the implementation go through the > vtable again, unless we are going to use dynamic vtables. > --- > dlls/ddraw/surface.c | 85 +++++++++--------- > dlls/ddraw/surface_impl.h | 207 > +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 250 insertions(+), 42 deletions(-) create mode > 100644 dlls/ddraw/surface_impl.h

1 0

Re: [AppDB] db_filter_ui: Use first filter option as default
by Winandy Hubert 11 Aug '08

11 Aug '08

Alexander Nicolaysen Sørnes schrieb: > Should be a little more user-friendly. > > > Alexander N. Sørnes > > > > __________ NOD32 3344 (20080810) Information __________ > > Diese E-Mail wurde vom NOD32 antivirus system geprüft > http://www.nod32.com > > ------------------------------------------------------------------------ > > Kann Anhang nicht öffnen Danke Winandy Hubert > > > > __________ NOD32 3344 (20080810) Information __________ > > Diese E-Mail wurde vom NOD32 antivirus system geprüft > http://www.nod32.com

1 0

Re: [Bug 14810] WinHttp needs to be implemented
by James Hawkins 11 Aug '08

11 Aug '08

On Sun, Aug 10, 2008 at 6:43 PM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=14810 > > > --- Comment #4 from Erich Hoover <ehoover(a)mines.edu> 2008-08-10 18:43:16 --- > This whole DLL has a total of 27 functions, 14 of which are currently exposed, > and only 1 is "implemented". I put some work into implementing enough of the > DLL to get RA3 to authenticate and found that it needs 9 of the functions to > operate properly. I think it is reasonable to say that implementing the rest > of the functions for WinHttp would not be too difficult. I do not think that > this particular issue is anywhere close to a broad-spectrum "Win32 API needs to > be implemented". > Of course it's not the same scale as all of the Win32 API. It was an analogy illustrating why the bug is superfluous. On the other hand, you're vastly underestimating the amount of work needed to properly implement winhttp. You might want to chat with Zac Brown who is working on implementing winhttp right now. Also, please don't post in closed bugs. -- James Hawkins

4 9

Re: rpcrt4: [1/2] Improve stub for I_RpcBindingInqTransportType, with test
by Dmitry Timoshkov 10 Aug '08

10 Aug '08

Detlef Riekenberg <wine.dev(a)web.de> wrote: > @@ -848,6 +848,10 @@ RPC_STATUS WINAPI I_RpcBindingInqTransportType( RPC_BINDING_HANDLE Binding, unsi > { > > FIXME( "(%p,%p): stub\n", Binding, Type); > + > + /* NT: RPC_S_NO_CONTEXT_AVAILABLE, 9x: RPC_S_NO_CALL_ACTIVE */ > + if (!Binding) return RPC_S_NO_CONTEXT_AVAILABLE; According to your test this should be if (!Binding || !Type) return RPC_S_NO_CONTEXT_AVAILABLE; Also the comment doesn't belong here, it's ok to have in the test though. -- Dmitry.

2 1