August 2008 - Wine-devel - list.winehq.org

Re: taskmgr: Converted some functions and variables to Unicode
by Nikolay Sivov 07 Aug '08

07 Aug '08

Vladimir Pankratov wrote: > - if (DialogBox(hInst, MAKEINTRESOURCE(IDD_COLUMNS_DIALOG), hMainWnd, ColumnsDialogWndProc) == IDOK) > + if (DialogBoxW(hInst, (LPWSTR)MAKEINTRESOURCE(IDD_COLUMNS_DIALOG), hMainWnd, ColumnsDialogWndProc) == IDOK) Why not to use MAKEINTRESOURCEW?

1 0

Re: advapi32: Implement GetSecurityInfo. [take 2]
by Dmitry Timoshkov 07 Aug '08

07 Aug '08

"Dan Hipschman" <dsh(a)linux.ucla.edu> wrote: > +#include <assert.h> ... > DWORD WINAPI GetSecurityInfo( > HANDLE hObject, SE_OBJECT_TYPE ObjectType, > @@ -2718,8 +2735,44 @@ DWORD WINAPI GetSecurityInfo( > PSECURITY_DESCRIPTOR *ppSecurityDescriptor > ) > { > - FIXME("stub!\n"); > - return ERROR_BAD_PROVIDER; > + PSECURITY_DESCRIPTOR sd; > + NTSTATUS status; > + ULONG n1, n2; > + BOOL present, defaulted; > + > + status = NtQuerySecurityObject(hObject, SecurityInfo, NULL, 0, &n1); > + assert(status != STATUS_SUCCESS); > + if (status != STATUS_BUFFER_TOO_SMALL) > + return RtlNtStatusToDosError(status); My previous comments regarding assert() still apply. -- Dmitry.

3 3

RE: winex11.drv: recognize WGL_SWAP_METHOD_ARB wgl pixel format attribute.
by Stefan Dösinger 06 Aug '08

06 Aug '08

> WGL_SWAP_METHOD attribute is not handled. Explicitly skip it in > ConvertAttribWGLtoGLX and always return WGL_SWAP_UNDEFINED_ARB in > X11DRV_wglGetPixelFormatAttribivARB, because buffers are always in > undefined state after swap in GLX. There's GLX_OML_swap_method. It is supported on fglrx, and I think it is supported on the open source drivers as well

2 1

RE: winex11.drv: recognize WGL_SWAP_METHOD_ARB wgl pixel format attribute.
by Stefan Dösinger 06 Aug '08

06 Aug '08

> WGL_SWAP_METHOD attribute is not handled. Explicitly skip it in > ConvertAttribWGLtoGLX and always return WGL_SWAP_UNDEFINED_ARB in > X11DRV_wglGetPixelFormatAttribivARB, because buffers are always in > undefined state after swap in GLX. There's GLX_OML_swap_method. It is supported on fglrx, and I think it is supported on the open source drivers as well

1 0

Re: user32: Add test and fix for the error with edit control whose parentis desktop.
by Dmitry Timoshkov 06 Aug '08

06 Aug '08

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > +static void test_edit_parent_desktop_1(void) > +{ > + HWND hwEdit; > + HDC hdc; > + > + hwEdit = CreateWindowEx( 0, "EDIT", NULL, WS_CHILD | WS_OVERLAPPEDWINDOW | > WS_VISIBLE, 10, 10, 300, 300, GetDesktopWindow(), NULL, hinst, NULL); Formatting of the line above looks pretty much strange. Please try to keep the line length under 80 columns, and use consistent spacing. > + > + hdc = GetDC( hwEdit ); > + SendMessage( hwEdit, WM_PAINT, (WPARAM)GetDC( hwEdit ), 0 ); > + > + ok( GetPixel( hdc, PIXEL_X, PIXEL_Y ) != COLOR_DEF_EDIT, "Get incorrect parent device context handle: brush color > = %04x\n", GetPixel( hdc, PIXEL_X, PIXEL_Y ) ); Same here. > + > + DestroyWindow( hwEdit ); > +} In general this test proves nothing. -- Dmitry.

1 0

Re: d3dx9: Implementation of D3DXGetDeclLength
by H. Verbeet 06 Aug '08

06 Aug '08

2008/8/5 Luis Busquets <luis.busquets(a)ilidium.com>: > +static const D3DVERTEXELEMENT9 lc={0xFF,0,D3DDECLTYPE_UNUSED,0,0,0}; What do you use this for? > + while ((pdecl+i)->Stream!=0xFF) > + { > + i++; You might as well increment pdecl itself. Also keep in mind that Alexandre won't be back before the 18th, so no patches will be applied before that either.

2 1

Re: taskmgr [try 2]: Converted some functions and variables to Unicode [1/12]
by Nikolay Sivov 06 Aug '08

06 Aug '08

Vladimir Pankratov wrote: > - TCHAR strErrorText[260]; > + WCHAR wstrErrorText[0x400]; Why do you use word format for size constant? Btw, is it normal that it's changed 260 -> 1024? > - GetLastErrorText(strErrorText, 260); > + GetLastErrorText(wstrErrorText, sizeof(wstrErrorText)/sizeof(WCHAR)); You've patched GetLastErrorText in your patch 12. But you changed calls to use WCHAR argument before this. That's why previous patches are broken I think. you should change function and all related calls of it in a single patch.

1 0

Re: [PATCH] oleaut32: Fix some corner cases in VarBstrCmp.
by Alexandre Julliard 06 Aug '08

06 Aug '08

"Lei Zhang" <thestig(a)google.com> writes: > diff --git a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c > index daeac85..713ebae 100644 > --- a/dlls/oleaut32/vartype.c > +++ b/dlls/oleaut32/vartype.c > @@ -6942,7 +6942,24 @@ HRESULT WINAPI VarBstrCmp(BSTR pbstrLeft, BSTR pbstrRight, LCID lcid, DWORD dwFl > if (!pbstrLeft || !*pbstrLeft) > { > if (!pbstrRight || !*pbstrRight) > - return VARCMP_EQ; > + { > + UINT ll; > + UINT lr; > + > + if (lcid) > + { > + ll = SysStringLen(pbstrLeft); > + lr = SysStringLen(pbstrRight); > + } > + else > + { > + ll = SysStringByteLen(pbstrLeft); > + lr = SysStringByteLen(pbstrRight); > + } > + if (ll == lr) > + return VARCMP_EQ; > + return ll < lr ? VARCMP_LT : VARCMP_GT; > + } That's ugly, you shouldn't need such special handling here, you should simply fall through to the normal comparisons which should give the correct results. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3dx9: Implementation of D3DXMatrixDecompose 2/2
by David Adam 05 Aug '08

05 Aug '08

Hi, some remarks + if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0)) should be + if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0)) No need to redefine a module fonction Replace + poutscale->x=module(pM->m[0][0],pM->m[0][1],pM->m[0][2]); by + poutscale->x=D3DXVec3Length(&D3DXVECTOR3((pM->m[0][0],pM->m[0][1],pM->m[0][2])); David 2008/8/5 Luis Busquets <luis.busquets(a)ilidium.com> > Please be aware that this function relies on D3DXQuaternionRotationMatrix > and therefore the bug in the latter has to be corrected. > > --- > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/math.c | 39 ++++++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 64 > +++++++++++++++++++++++++++++++++++++++++++ > include/d3dx9math.h | 1 + > 4 files changed, 105 insertions(+), 1 deletions(-) > > > >

2 1

Vacation
by Alexandre Julliard 05 Aug '08

05 Aug '08

Folks, I'm leaving on vacation, so there won't be any commits for a while. Of course thanks to git that shouldn't prevent you from filling my mailbox with patches... I'll be back on the 18th, and release 1.1.3 will thus be on the 22nd. -- Alexandre Julliard julliard(a)winehq.org

1 0