October 2009 - Wine-devel - list.winehq.org

Re: [5/6] mshtml: Handle DISPATCH_CONSTRUCT flag for DispatchEx objects
by Jacek Caban 21 Oct '09

21 Oct '09

Hi Andrew, Andrew Eikum wrote: > --- > dlls/mshtml/dispex.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > + if(This->data->vtbl && This->data->vtbl->value){ + IUnknown *unk; + IDispatchEx_QueryInterface(iface, &IID_IUnknown, (void**)&unk); That's what This->outer is for. Also, because the child object controls it, you don't have to QueryInterface for IHTMLImageElementFactory in the next patch. Jacek

1 0

valgrind results for 20 October 2009
by Dan Kegel 21 Oct '09

21 Oct '09

Fresh Valgrind results for the wine conformance tests are available at http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/ This is from about six hours ago, so it doesn't include Alexandre's coming commits for the day. The code was compiled with -O0 -g to give detailed stacks. The run uses current valgrind from svn with a couple patches, mainly John Reiser's recent patch to make mmap/mprotect behave (needed since the merge of mac support). ole32/marshal.c hung, so I don't have any results from past that. I suppressed some of the benign warnings, but there are surely a bunch left (e.g. kernel32 tests of freeing an invalid pointer still show up), so you have to look at the test source before deciding whether a warning is valid. I suppressed all the "possible" leaks, so any leak that shows up in the log is quite probably a real leak (though possibly a benign one). Please have a look to see if your favorite module has easily-fixable problems.

4 7

Re: [PATCH 2/5] ddraw/tests: Check some more return values (LLVM/Clang).
by Paul Vriens 21 Oct '09

21 Oct '09

On 10/16/2009 10:38 AM, Henri Verbeet wrote: > diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c > index d9b1c72..9104147 100644 > --- a/dlls/ddraw/tests/d3d.c > +++ b/dlls/ddraw/tests/d3d.c > @@ -961,6 +961,7 @@ static BOOL D3D1_createObjects(void) > ddsd.dwWidth = 256; > ddsd.dwHeight = 256; > hr = IDirectDraw_CreateSurface(DirectDraw1,&ddsd,&Surface1, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface returned %#x.\n", hr); > if (!Surface1) { > skip("DDSCAPS_3DDEVICE surface not available\n"); > return FALSE; Hi Henri, This one currently fails on some Win9x/WinMe boxes (VMware only)? As there is a skip() afterwards it seems like the call doesn't always need to be succeeding? Should I just get rid of the ok() message and the assignment to hr? Or move the ok() till after the if()? -- Cheers, Paul.

2 1

NetFwService_create() is unused
by Francois Gouget 21 Oct '09

21 Oct '09

NetFwService_create() is unused in dlls/hnetcfg/service.c. I presume it's meant to be used somehow rather than removed? Maybe a patch is missing? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

1 0

valgrind results for 20 October 2009, take 2
by Dan Kegel 21 Oct '09

21 Oct '09

This time with today's commits, and skipping ole32/marshal, since that hangs. Results at http://kegel.com/wine/valgrind/logs/2009-10-20-09.31/ There are a few very common errors that I need to file bugs for and then suppress... but there are also quite a large number of valid-looking problems. I'll try one more run with -q to get rid of more gunk...

1 0

Re: [6/7] ole32: Don't use IEnumSTATSTGImpl to search in CreateStream.
by Vincent Povirk 20 Oct '09

20 Oct '09

DOH, looks like I mistitled this one. Should be OpenStream. On Tue, Oct 20, 2009 at 2:51 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

RFC: Implement CDROM_GetInterfaceInfo() on Mac OS.
by Charles Davis 20 Oct '09

20 Oct '09

Hi, This patch will implement CDROM_GetInterfaceInfo() (and its associated IOCTL) on Mac OS X. The problem is that it's big, it's complicated, and it uses I/O Kit. From what I've seen, Alexandre doesn't exactly like I/O Kit that much. Anyway, I want someone to review the patch. No, I could not find a system ioctl that did what I wanted. Perhaps I should hold off on this until we have that driver I mentioned earlier ready...? In any case, here's my current patch. Chip --- dlls/ntdll/cdrom.c | 428 +++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 411 insertions(+), 17 deletions(-)

1 0

ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned. [Try 2]
by Erich Hoover 20 Oct '09

20 Oct '09

After looking over my second attempt at this patch I see that I failed to gracefully handle the case when no routes are found. Am I missing anything else here? http://www.winehq.org/pipermail/wine-patches/2009-October/079872.html http://www.winehq.org/pipermail/wine-patches/2009-October/079873.html Erich Hoover ehoover(a)mines.edu

1 0

Re: [PATCH 4/8] msi: Fix merging string type checks.
by Alexandre Julliard 20 Oct '09

20 Oct '09

Hib Eris <hib(a)hiberis.nl> writes: > +static BOOL merge_type_match(LPCWSTR type1, LPCWSTR type2) > +{ > + const WCHAR szl[] = {'l', 0}; > + const WCHAR szs[] = {'s', 0}; > + const WCHAR szL[] = {'L', 0}; > + const WCHAR szS[] = {'S', 0}; > + > + if ((!StrCmpNW(type1, szl, 1) || !StrCmpNW(type1, szs, 1)) && > + (!StrCmpNW(type2, szl, 1) || !StrCmpNW(type2, szs, 1))) > + return TRUE; > + > + if ((!StrCmpNW(type1, szL, 1) || !StrCmpNW(type1, szS, 1)) && > + (!StrCmpNW(type2, szL, 1) || !StrCmpNW(type2, szS, 1))) > + return TRUE; > + > + return !StrCmpNW(type1, type2, 1); > +} Surely you don't need StrCmpNW to compare one character... -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: dlls/winex11.drv/dib.c: initialize two warnings (RESEND)
by Alexandre Julliard 20 Oct '09

20 Oct '09

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I verified that I still need this patch originally sent on May 31st > to address to compiler warings with current versions of GCC 4.5.0. > > This seems to be the only invocation of DIB_GetBitmapInfo which > requires this kind of extra initialization. I expect you can avoid that by restructuring the code a little. -- Alexandre Julliard julliard(a)winehq.org

1 0