October 2009 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] Moving wprocs.dll16 out of winedos
by Alexandre Julliard 20 Oct '09

20 Oct '09

Eric Pouech <eric.pouech(a)orange.fr> writes: > .gitignore | 1 > configure | 15 > configure.ac | 1 > dlls/Makefile.in | 6 > dlls/winedos/Makefile.in | 3 > dlls/winedos/vxd.c | 1718 ----------------------------------- > dlls/winedos/wprocs.spec | 19 > dlls/wprocs.dll16/Makefile.in | 15 > dlls/wprocs.dll16/vxd.c | 1718 +++++++++++++++++++++++++++++++++++ > dlls/wprocs.dll16/wprocs.dll16.spec | 19 > 10 files changed, 1766 insertions(+), 1749 deletions(-) > delete mode 100644 dlls/winedos/vxd.c > delete mode 100644 dlls/winedos/wprocs.spec > create mode 100644 dlls/wprocs.dll16/Makefile.in > create mode 100644 dlls/wprocs.dll16/vxd.c > create mode 100644 dlls/wprocs.dll16/wprocs.dll16.spec I don't think we need a separate dll for this one. The plan is to fold it back into krnl386 once it's split off from kernel32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] hlink: Use HLINKSETF flags in Hlink::fnSetMonikerReference
by Alexandre Julliard 20 Oct '09

20 Oct '09

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/hlink/hlink_main.c | 4 +- > dlls/hlink/link.c | 37 +++++++++++------- > dlls/hlink/tests/hlink.c | 98 > ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 123 insertions(+), 16 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:676: Test failed: mon == NULL make: *** [htmldoc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32/font: Prevent possible buffer overrun
by Dmitry Timoshkov 20 Oct '09

20 Oct '09

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > Reported as http://bugs.winehq.org/show_bug.cgi?id=19819 > > Changelog: > - prevent possible buffer overrun > - while (!(*lpSrc>>index & 0x0001) && index<MAXTCIINDEX) index++; > + while (index < MAXTCIINDEX && !(*lpSrc>>index & 0x0001)) index++; 'index >= MAXTCIINDEX' won't trigger in that case: if (index >= MAXTCIINDEX || FONT_tci[index].ciCharset == DEFAULT_CHARSET) return FALSE; It would be simpler IMO to add one more item to FONT_tci[] instead. -- Dmitry.

2 1

Re: [4/9] WineD3D: Use the shader backend reported constant limit outside the shader backend
by Henri Verbeet 20 Oct '09

20 Oct '09

2009/10/20 Stefan Dösinger <stefan(a)codeweavers.com>: > -static void stateblock_savedstates_set_all(SAVEDSTATES *states, const struct wined3d_gl_info *gl_info) > +static void stateblock_savedstates_set_all(SAVEDSTATES *states, const IWineD3DDeviceImpl *device) Please don't do that.

1 0

Trying to fix some setupapi tests on Win9x/WinMe
by Paul Vriens 20 Oct '09

20 Oct '09

Hi, In an effort to get everything green I'm trying to fix some long standing setupapi test failures. In one of the tests, test_SetupDecompressOrCopyFile() in misc.c, we call SetupDecompressOrCopyFileA a few times. One of them fails as the target file is still open and doesn't allow reading from it (ERROR_SHARING_VIOLATION). This only happens when running winetest and not when running the single tests. Once all tests are finished that previously 'locked' file can be removed. I'm building my own winetest where I selectively removed some of the tests. If I remove for example comctl32/d3d9/fusion/kernel32/riched20 the setupapi tests succeed. Other combinations are however also possible to make the tests pass (for example everything up to d3d8). I do see that on Win98 several processes are started due to some tests needing functionality (like 'rpcss.exe', 'spool32.exe', 'pstores.exe', 'ddhelp.exe'). These processes however have only handles to the winetest results file and not to the mentioned setupapi test file. I'm a bit lost where I should be looking so any ideas, suggestions would be appreciated. I don't know when these tests started failing but I found some failures in test results as far back as May 30th 2008 (WinMe). It's also worth mentioning that not all Win9x/WinMe boxes fail and that the failures happen on both VMware and real boxes. Could it be that we are not cleaning up properly after some tests? Most things should however be cleaned up when we exit a test (like freeing libraries, closing open handles etc...), not? -- Cheers, Paul.

2 2

[PATCH 16/14] winmm: MCI Close all causes one notification per open driver.
by Joerg-Cyril.Hoehle＠t-systems.com 20 Oct '09

20 Oct '09

Paul Vriens asked: >Do all you previous patches still apply after several commits (patches >from Eric)? >I see that for now only "winecoreaudio: Move ERR&WARN out of OSSpinLock >sections" is applied. I don't know. They applied on git as it was over the week end. If there's a problem, I'll not be able to (git fetch &) resolve it until next week. I thought Eric's async patch in bug #20232 would not be submitted as he wrote: >the attached patch is a quick hack for testing purposes I wanted to test it on my side. Ouch. I already made the experience that it's usually better to *not* talk about bugs when I plan to fix them, as Eric's second patch (SYSINFO) which he wrote after I mentioned the bug clearly conflicts with my own. Both were written over the week-end. Sh*t happens. Mine passes the test suite, giving the expected return code :-P Regards, Jörg Höhle.

1 0

Re: winecoreaudio: Move ERR&WARN out of OSSpinLock sections.
by Vitaliy Margolen 20 Oct '09

20 Oct '09

Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Still a few occurances left in wid* functions. > Also, HeapFree occurs in such sections (which may also cause logging). > This is not unsafe as it is no requirement that spinlock sections should be quick. It's just adequate when contention is presumed low. > ------_=_NextPart_001_01CA50B7.60F14FE6 > Content-Type: application/text; > name="0002-mciwave-Pause-resume-is-not-accepted-from-every-sta.patch" > Content-Transfer-Encoding: base64 > Content-Description: 0002-mciwave-Pause-resume-is-not-accepted-from-every-sta.patch > Content-Disposition: attachment; > filename="0002-mciwave-Pause-resume-is-not-accepted-from-every-sta.patch" > > RnJvbSA0N2ZlZGZlMTBmY2Y1MmI2MGEzOTc1ZWY3YTFkMjI4NjJjNGE5MDJlIE1vbiBTZXAgMTcg Could you fix your mailer to report correct mime-types for your attachments. Vitaliy.

1 0

Re: dinput: Fix counting non maped axis as pov [try 2]
by Vitaliy Margolen 20 Oct '09

20 Oct '09

Ričardas Barkauskas wrote: > This time with patch. Sorry. > Fixes crash with dinput joystick test and pcsx2 lilypad plugin on my system.. > > - else if (tokens < 15) > + else if (tokens >=8 && tokens < 15) Nice catch, this is indeed a bug when token == -1. Vitaliy.

1 0

Re: [PATCH 3/5] [WinMM]: allow 32-bit mciLoadCommandResource to load out of 16 bit module
by Alexandre Julliard 19 Oct '09

19 Oct '09

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -1566,7 +1554,41 @@ UINT WINAPI mciLoadCommandResource(HINSTANCE hInst, LPCWSTR resNameW, UINT type) > if (!(hRsrc = FindResourceW(hInst, resNameW, (LPWSTR)RT_RCDATA))) { > WARN("No command table found in resource\n"); > } else if ((hMem = LoadResource(hInst, hRsrc))) { > - ret = MCI_SetCommandTable(LockResource(hMem), type); > + if (!HIWORD(hInst)) { /* it's a 16bit resource, convert it */ > + const BYTE* ptr16 = LockResource(hMem); Please don't do that. 16-bit resources should always be loaded with 16-bit functions. Support for casting 16-bit instances to 32-bit is a hack that will have to be removed. -- Alexandre Julliard julliard(a)winehq.org

2 2

CPPCheck for Monday October 19th
by chris ahrendt 19 Oct '09

19 Oct '09

Errors: [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd Tools Errors: [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:388]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/pe.c:1547]: (error) Memory leak: map Test Errors To Ignore: [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1117]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1101]: (possible error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1108]: (possible error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (error) Array index out of bounds Chris

1 0