October 2009 - Wine-devel - list.winehq.org

Re: ddraw.c: avoid memory overwrite in GetDeviceIdentifier()
by Stefan Dösinger 12 Oct '09

12 Oct '09

> diff --git a/dlls/ddraw/tests/visual.c b/dlls/ddraw/tests/visual.c > index 450d231..645fa8d 100644 > --- a/dlls/ddraw/tests/visual.c > +++ b/dlls/ddraw/tests/visual.c The visual.c file doesn't seem quite right for this test. There's no really matching file, but I think ddrawmodes.c is better, since that file mainly tests IDirectDraw behavior, while visual.c is mainly about d3d. > memcpy(DDDI->szDriver, deviceidentifier.szDriver, MAX_DDDEVICEID_STRING); > memcpy(DDDI->szDescription, deviceidentifier.szDescription, MAX_DDDEVICEID_STRING); It's probably worth testing what happens when the string is shorter than the max length(as it is most likely the case on all windows boxes). Are the remaining bytes in szDriver unchanged, as if you were using strcpy rather than memcpy. I can imagine that they're left untoched(strcpy), set to garbage(memcpy) or set to zero(memset, then strcpy)

1 0

Re: CPP Check 1.1.31
by Nikolay Sivov 12 Oct '09

12 Oct '09

James McKenzie wrote: > Nikolay Sivov wrote: > >> chris ahrendt wrote: >> >>> [/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) >>> Division by zero >>> >>> >> False positive I suppose: >> >> --- >> static const BYTE pad[] = { >> 'P','A','D','D','I','N','G','X','X','P','A','D','D','I','N','G' }; >> DWORD i; >> >> -> for ( i = 0; i < size / sizeof pad; i++ ) >> --- >> > Should pad be enclosed in parenthesis? > > James McKenzie > No, why?

1 0

Requesting comments on patchset to fix Bug 7929 (C&C 3 network does not work)
by Erich Hoover 12 Oct '09

12 Oct '09

I've been a bit busy lately, but I sent in a patchset at the end of September to fix the C&C3 LAN networking bug. If I could get some feedback on these patches then I would greatly appreciate it: http://www.winehq.org/pipermail/wine-patches/2009-September/079193.html[1/6] http://www.winehq.org/pipermail/wine-patches/2009-September/079195.html[2/6] http://www.winehq.org/pipermail/wine-patches/2009-September/079194.html[3/6] http://www.winehq.org/pipermail/wine-patches/2009-September/079198.html[4/6] http://www.winehq.org/pipermail/wine-patches/2009-September/079196.html[5/6] http://www.winehq.org/pipermail/wine-patches/2009-September/079197.html[6/6] Erich Hoover ehoover(a)mines.edu

5 8

Re: comctl32: Remove trailing spaces in propsheet.c
by James McKenzie 12 Oct '09

12 Oct '09

Ričardas Barkauskas wrote: > Remove trailing spaces in comctl32's propsheet.c. > > These types of patches are highly discouraged unless this is causing a breakage with your compiler. If there is a breakage, file a bug with this patch attached for comments. Trailing spaces are not a problem with most forms of GNU c/C++ (gcc/g++) James McKenzie

1 0

Re: Wine MSSQL VB
by Nikolay Sivov 12 Oct '09

12 Oct '09

kumaresan c wrote: > Thanks. > You are right. As per that code there is no need to create DSN. > But I can't access even by creating DSN under wine and modify > the connection code as follows > > Db.open "DSN=ForLinux; User Id=sa; Password=kumaresan" > > > Ok, How to check whether the provider(oledb) works? > > or else What should I do to install oledb provider? > > --Kumaresan I'm not sure it will work through DSNs cause it requires some system support beside providers. You should install mdac as you did, and possibly override all oledb related modules, please use Wine user support forum http://forum.winehq.org/ for such questions, wine-devel isn't used for support.

1 0

Wine MSSQL VB
by kumaresan c 12 Oct '09

12 Oct '09

I have a program that accesses Mssql 2000 database from Windows 2003 server. Now I need to run this program in Linux. I setup wine, mdac28 etc. I can install the program with one error: ODBC's SQLRemoveDriverManager Failed. I can also create a system DSN in Linux using odbcad32.exe under wine. But when I run the program the following error occurs: Specifed SQL Server not found. The code I used is: Db.open "Provider=SQLOLEDB.1;Persist Security Info=True; User ID=sa; Initial Catalog=ForLinuxTest;Data Source=WINSERVER.VISUALWIN.TESTDOMAIN; Password=kumaresan" If I modify this code to use DSN, It looks for a unixODBC DSN instead of wine DSN. What should I do? Help me if you can............... ---Kumaresan.

2 1

Re: ddraw.c: avoid memory overwrite in GetDeviceIdentifier()
by Reece Dunn 12 Oct '09

12 Oct '09

+ * Fill result structure element by element to avoid memory overwrites + * du to size alignment. That should be "*due* to size alignment." - Reece

1 0

Re: [PATCH 07/11] Revert "winmm: Test opening the same device twice."
by Alexandre Julliard 12 Oct '09

12 Oct '09

Ken Thomases <ken(a)codeweavers.com> writes: > This reverts commit 6a7127bfc201ff7a218795c239d5b2571ea413d7 and part of > 9f32c0d9d60662ac8e00ce5cbd4aebd4fdf8dc89. > > It turns out that the issue isn't a limitation of winmm. It's just > individual low-level drivers that may fail to support opening the device > twice. So, there's no way to write the test (is it todo_wine or not? > depends on the driver). That's not a reason to remove it... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment
by Stefan Dösinger 12 Oct '09

12 Oct '09

Am 11.10.2009 um 17:44 schrieb Markus Stockhausen: > > <diff.patch> Did you compile this test with MSVC and the Microsoft headers on Windows?

3 5

Re: [PATCH] (resubmit) winegcc: free link_args (Coverity)
by Alexandre Julliard 12 Oct '09

12 Oct '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity spotted we do not free link_args, so just free them. > > (I know its a small cleanup issue, just to get this off my and > coveritys radar ;) The program is exiting at that point, freeing memory is a waste of time. -- Alexandre Julliard julliard(a)winehq.org

1 0