October 2009 - Wine-devel - list.winehq.org

Re: msadp32: Do not enumerate 8bit PCM formats, they cannot be converted.
by Alexandre Julliard 12 Oct '09

12 Oct '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > I found it illogical to advertise unusable 8bit formats. But I did not > cross check whether MS-Windows would do so. Please do, and then if they are really not needed remove them, don't leave them commented out with no explanation. > Is it supported to send 2 patches as 2 attachments in one mail? No. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Help me get a patch into Wine
by Charles Davis 12 Oct '09

12 Oct '09

Damn it, I keep forgetting to reply all. Charles Davis wrote: > Vitaliy Margolen wrote: >> Charles Davis wrote: >>> Hi, >>> >>> My name is Charles Davis, but you all can call me "Chip". >>> >>> I'm new to Wine development, and frankly, I'm kinda scared because I've >>> heard and read that getting patches into Wine is very difficult. In >>> fact, every time I got ready to send this first patch, I chickened out >>> and couldn't do it. So, I want someone to review this patch to see if >>> there's anything wrong with it. >>> >> Thanks for writing the patch. >> >> Few things about your patch: >>> + * Copyright 2008, 2009 Charles Davis >> You need to add substantial amount of code to or be working for a long time >> on this file to add yourself to the copyright note. As for your contribution >> to the project, all authors are tracked and AUTHORS file updated automatically. > Oh. I see. But I have many more patches for this file. >>> + switch(fmt->Format) >>> + { >>> + case IOCTL_CDROM_CURRENT_POSITION: >>> + memset(&data->CurrentPosition, 0, sizeof(data->CurrentPosition)); >>> + break; >>> + case IOCTL_CDROM_MEDIA_CATALOG: >>> + memset(&data->MediaCatalog, 0, sizeof(data->MediaCatalog)); >>> + break; >>> + case IOCTL_CDROM_TRACK_ISRC: >>> + memset(&data->TrackIsrc, 0, sizeof(data->TrackIsrc)); >>> + } >>> + /* We need IOCDAudioControl for IOCTL_CDROM_CURRENT_POSITION */ >>> + if (fmt->Format == IOCTL_CDROM_CURRENT_POSITION) >>> + { >>> + ERR("This version of Mac OS X does not support IOCDAudioControl\n"); >>> + return STATUS_NOT_SUPPORTED; >>> + } >> This doesn't seems right. If it's not supported (aka error) you shouldn't be >> touching returned data. Also why are you zeroing return buffers? I don't see >> other implementations do it. > Good catch. I should have done the check first. >>> + case IOCTL_CDROM_MEDIA_CATALOG: >>> + memset(&ioc, 0, sizeof(ioc)); >> and >>> + case IOCTL_CDROM_TRACK_ISRC: >>> + memset(&ioc, 0, sizeof(ioc)); >> You shouldn't need to zero buffer you pass to system ioctl. > Good point. >>> + if((io = ioctl(fd, DKIOCCDREADMCN, &ioc.mcn)) == -1) break; >>> + if((io = ioctl(fd, DKIOCCDREADISRC, &ioc.isrc)) == -1) break; >> Please keep formatting consistent with the rest of the function/file. Here >> you need to add space after "if". > You're right. I read about that, but that must have slipped by me. >> >> Vitaliy. > > Thanks for your input. > > Chip

1 0

Re: d3dx11_42: Stub implementation
by Nikolay Sivov 12 Oct '09

12 Oct '09

Ričardas Barkauskas wrote: > Allows pcsx2 r1888 gsdx plugin to start and try to execute in dx9 mode. > > Ričardas Barkauskas > REalm > > + * Direct3D X 10 main file Eleventh maybe?

1 0

Re: Bug 6971 in RedOrchestra Game.
by Roderick Colenbrander 12 Oct '09

12 Oct '09

Hi, First of all wine-patches is the list to which patches are submitted for inclusion in Wine, it is not meant as a user discussion list. Questions like the one you asked belong on wine-devel. Bug 6971 is an old Wine bug and is hard to fix. Now that xserver 1.7 is out, there is finally Xinput 1.2 support which adds relative mouse movement support to X which is needed to fix the problem. At wine-devel some old patches float around but I'm not sure if they still work. These patches need to be cleaned up and integrated into Wine but it is quite an amount of work. Roderick On Sun, Oct 11, 2009 at 7:37 AM, Loren Kraushar <bure_10(a)hotmail.com> wrote: > To whom it may concern, > > I have been enjoying your fine wine for a few months now and am requesting > that you add the patch for the redorchestra/darkest hour game. Basically > the mouse is confined to the same size window as the desktop or something > and you cant really rotate 360 degrees in game properly. There is a "patch" > but it was made in Italian or something and I can't really tell how to use > it might be some money in it for you if I could play my games flawlessly > next update. > > Sincerely Loren Kraushar. > > ________________________________ > New! Hotmail sign-in on the MSN homepage. > > >

2 2

Help me get a patch into Wine
by Charles Davis 12 Oct '09

12 Oct '09

Hi, My name is Charles Davis, but you all can call me "Chip". I'm new to Wine development, and frankly, I'm kinda scared because I've heard and read that getting patches into Wine is very difficult. In fact, every time I got ready to send this first patch, I chickened out and couldn't do it. So, I want someone to review this patch to see if there's anything wrong with it. Thanks in advance. Chip --- dlls/ntdll/cdrom.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 45 insertions(+), 0 deletions(-)

3 2

Re: Help me get a patch into Wine
by Charles Davis 12 Oct '09

12 Oct '09

Oops, forgot to reply all. Charles Davis wrote: > James McKenzie wrote: >> Charles Davis wrote: >>> Hi, >>> >>> My name is Charles Davis, but you all can call me "Chip". >>> >>> I'm new to Wine development, and frankly, I'm kinda scared because I've >>> heard and read that getting patches into Wine is very difficult. In >>> fact, every time I got ready to send this first patch, I chickened out >>> and couldn't do it. So, I want someone to review this patch to see if >>> there's anything wrong with it. >>> >> Might help to add testcases to show that this is what Windows does and >> that Wine correctly emulates these actions. > Then why isn't there already a testcase for this? This is nearly > impossible to test automatically. (You need a CD in the drive.) > Interactively... well, you got me there. >> It also might REALLY help if you can state where you found this in MSDN >> or on a public site. Otherwise this leaves your code as suspect and it >> will not be added. > It's under "Win32 and COM Development/Windows Driver Kit/Device and > Driver Technologies/Storage Devices" on MSDN. Under the Reference > section, there's a list of all the IOCTLs supported by Windows for all > storage devices--including CD-ROM devices. Then again, I hear that MSDN > doesn't have the full story. Maybe I should write a testcase... and I do > have a Windows XP machine for testing. >> If this solves a bug, you might also want to add that too. > It doesn't. Not that I know of anyway. (Maybe I should do a search?) I > stumbled upon a bunch of unimplemented stuff in this file while trying > to add IOCTL_SCSI_PASS_THROUGH support. (Basically the whole file, save > for the eject and TOC IOCTLs, was unimplemented on Mac OS.) So I > decided, "Since nobody else is going to implement this, I might as > well." Then again, maybe there's a good reason they're not yet > implemented (nobody needs this stuff). >> Thank you. >> >> James McKenzie >> >> > Thanks for your input, James. > > Chip > >

1 0

Re: ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned.
by Vitaliy Margolen 12 Oct '09

12 Oct '09

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > If an application calls gethostbyname on it's own hostname then it > expects an IP to be returned for each interface, in order of the > routing priority (see MS Knowledge Base article #160215). The > attached patch first checks to see if the gethostbyname request > resolved to a loopback address (which currently gets replaced by the > magic IP). If the magic IP would have been returned then it uses the > routing table to build the list of IP addresses and properly sorts > those addresses from highest routing priority to lowest routing > priority (lowest metric to highest metric). > Changelog: > ws2_32: Use the routing table information for > gethostbyname('self') if the magic IP would otherwise be returned. Thanks for the patch, however there are few issues with it. Why do you return a list of IP addresses from WS2_get_local_ips if you need only one? Just get the one with the lowest metric and return it. I think it would be better > + adapters = HeapAlloc(GetProcessHeap(),0,adap_size); > + routes = HeapAlloc(GetProcessHeap(),0,route_size); > + route_addrs = HeapAlloc(GetProcessHeap(),0,0); /* HeapReAlloc doesn't work on NULL */ Here and everywhere else please put space before comas to follow the file's formatting. > + if (route_addrs != NULL) > + HeapFree(GetProcessHeap(), 0, route_addrs); > + if (adapters != NULL) > + HeapFree(GetProcessHeap(), 0, adapters); > + if (routes != NULL) > + HeapFree(GetProcessHeap(), 0, routes); You do not need to check pointers for NULL before freeing them. Vitaliy.

3 4

Localized date names
by Nikolay Sivov 11 Oct '09

11 Oct '09

Hi. I'm trying to figure out the best way for adding genitive month names support for locales. After some tests I've got the following: - GetLocaleInfo doesn't return such names, only nominative names is returned; - GetDateFormat returns genitive name both for "ddMMMM" and "MMMMdd" Looking deeper GetDateFormat uses cache filled using GetLocaleInfo, so such data will never get here cause it isn't provided with this call. So the first question is am I able to directly load resource strings with null terminators inside? MSDN states that (http://msdn.microsoft.com/en-us/library/cc194815.aspx) alternate month forms are stored in the same string with null as a separator between forms. Second question: what is the most efficient (by means a speed) way to rework format parsing to catch a case when genitive form should be used? An obvious one is to search twice but I'm not sure about it. Nikolay.

1 0

Re: winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used.
by Dmitry Timoshkov 11 Oct '09

11 Oct '09

"Erich Hoover" <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > The attached patch makes it so that the 'F10' key send a > WM_SYSKEYDOWN window notification on press and WM_SYSKEYUP on release. > This change fixes Bug 19383 ([Monkey Island Special Edition] Version > Hotswap does not work), where the application relies on the > notification to switch between "modes." > Changelog: > winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used. This change requires a test case. -- Dmitry.

3 3

use DDRAW4 instead of DDRAW7
by Markus Stockhausen 11 Oct '09

11 Oct '09

Hi, as I did not find anything in the Wiki maybe a stupid question: If I want an application to use DDRAW4 functions in Wine instead of DDRAW7, how can I accomplish that? Thanks in advance. Markus

2 6