October 2009 - Wine-devel - list.winehq.org

Re: [1/2] comctl32/propsheet: Remove trailing spaces
by lats 11 Oct '09

11 Oct '09

On 11/10/09 19:29, Ričardas Barkauskas wrote: > Removes trailing spaces to have it clean for next patch I will be interested to see how you go with this one as the word has been that formatting only patches are not accepted.

3 2

Fixing bug #2181, standard EDIT class extra value
by Julius Schwartzenberg 11 Oct '09

11 Oct '09

Hi, I'm trying to solve bug #2181. With help from Roderick, I created this patch together with a test, which allows Civilization II to work. I noticed that there are currently no similar tests which check the standard classes. Shouldn't at least the extra values of the other classes be tested too? In that case I would try to add tests for those too. The current test works for me on Windows 98 & XP. Can others try it on other Windows versions? This is the first time I'm developing for Wine, so please let me know if you have any comments. Regards, Julius

2 6

Re: [2/2] comctl32/propsheet: Fix PropSheet_IndexToHwnd to handle invalid handles
by Paul Vriens 11 Oct '09

11 Oct '09

On 10/11/2009 10:33 AM, Ričardas Barkauskas wrote: > Fixes crash with pcsx2 r1888 plugin. > > > Ričardas Barkauskas > REalm > > Hi, You forgot the patch. -- Cheers, Paul.

1 0

Compiling a particular version of Wine
by Danila Sentiabov 10 Oct '09

10 Oct '09

Hi, everyone. A n00b problem here :-) I can't figure out how to compile an old version of Wine with git. One could always get the latest version with "git fetch && git rebase origin", but now I need 1.1.28 for testing purposes. Already tried some lame things and stared at manpages for about half an hour with no success :-) Could someone please help me in this matter? -- Best regards, Danila Sentiabov aka dsent

3 3

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit
by Henri Verbeet 10 Oct '09

10 Oct '09

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > +typedef struct tagDPSP_MSG_HEADER > +{ > + DWORD size; /* size & 0x000FFFFF, token & 0xFFF00000 */ > + SOCKADDR_IN SockAddr; > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER; > + It seems you're sending this over the network, so you should make sure it's correctly packed, and take the byte order into account.

3 11

CPP Check 1.1.31
by chris ahrendt 10 Oct '09

10 Oct '09

[/home/cahrendt/wine-git/dlls/kernel32/resource.c:1279]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd Chris

2 1

no LANG=C wine winecfg on Mac OS? (texts are always translated)
by Joerg-Cyril.Hoehle＠t-systems.com 10 Oct '09

10 Oct '09

Hi, On Linux, I can toggle Wine's idea about the current language by starting with: LANG=C or =de_DE.UTF-8 or fr_... wine winecfg Winecfg then displays text in the chosen locale (english for C). This works well in Ubuntu for any locale with the language-pack-xyz packages installed (C always works). On my Mac, winecfg's texts are always German. Even LANG=C /path/to/wine winecfg does not display english texts! How to switch languages on the Mac? I'm using 1.1.30, compiled by myself on Mac OS X 10.5.7. Thanks for your help, Jörg Höhle.

2 1

Winamp disappears when you move it's location
by Peter Dons Tychsen 10 Oct '09

10 Oct '09

I am posting your response, as you are not on CC in the bug. >>You can't do that sort of thing. If you really don't want the window manager to >>control the windows there's an option for it, but you can't have it both ways. I am not sure i agree. Everywhere i looked they referred to "override_redirect" as being *the way* to control this. And doing so is totally valid. The xlib manual is very clear on this: "To control window placement or to add decoration, a window manager often needs to intercept (redirect) any map or configure request. Pop-up windows, however, often need to be mapped without a window manager getting in the way. To control whether an InputOutput or InputOnly window is to ignore these structure control facilities, use the override-redirect flag." I think this says it all... http://tronche.com/gui/x/xlib/window/attributes/override-redirect.html I also checked the source code for Metacity, which only confirmed my findings. Notes and code to support the statement above was in place. Please consider this, as it makes some apps look so much better. Thanks, /pedro

2 8

Fixing the last shell32/shlfileop tests on Windows (< Win7)
by Paul Vriens 10 Oct '09

10 Oct '09

Hi, In my attempt to have no failures on WinMe I changed some W-functions into their A equivalent. The problem with some Russian (only?) versions of XP is that in test_sh_path_prepare() we create a directory with the name "c:\Ä". This name is thrown through WideCharToMultiByte(CP_ACP ....) and we check with A-calls for the existence of this directory. This is the point where it fails. Doing these checks with W-calls is fine. Is this some quirk of WideCharToMultiByte or does Russian in combination with using an A-function (GetFileAttributesA) present the issue? The easy way out here is to just skip the tests on WinMe and stick with the W-functions. Having two codepaths is also possible (not pretty) and would only present an issue (I assume) if we ever have a Russian WinMe in our tests ;). -- Cheers, Paul.

1 0

Re: [ddraw/tests] Don't crash on Win95 and NT4
by Paul Vriens 10 Oct '09

10 Oct '09

On 10/09/2009 09:34 PM, Paul Vriens wrote: > Hi, > > Again a case of no exception handler on these platforms. While at it I > also fixed a test failure on these two platforms. > > Changelog > Don't crash on Win95 and NT4 > Hi, Ignore this one. I'll send an updated one. -- Cheers, Paul.

1 0