November 2009 - Wine-devel - list.winehq.org

MCI and application-level thread-safety?
by Joerg-Cyril.Hoehle＠t-systems.com 11 Nov '09

11 Nov '09

Hi, So far my my patches have dealt only with "internal thread consistency", i.e. to avoid bogus conditions that result by using threads *internal* to the MCI. I wonder whether the individual MCI devices must protect themselves from application-level threads, i.e. an application issuing commands to the same device from several threads? (Also needed for auto-close...) This for sure would require the addition of critical sections which currently only mciavi32 has. These have to be thought about very carefully to avoid dead-locks (give me Erlang or Occam, or queues like in the audio drivers instead of this lock-based error-prone stuff!). Regards, Jörg Höhle

1 0

Re: Cpp Check Nov. 7th
by chris ahrendt 11 Nov '09

11 Nov '09

Alexandre Julliard wrote: > chris ahrendt <celticht32(a)yahoo.com> writes: > >> Well its been a few since I ran CPP Check and so I ran it today and got the following: >> >> New CPP Check Errors for the Wine Code: >> >> [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized variable: bmi_buf >> [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd >> [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szText >> [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szTitle >> [/home/cahrendt/wine-git/dlls/shell32/shellpath.c:1360]: (error) Uninitialized variable: InfoBuffer >> [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd >> [/home/cahrendt/wine-git/server/mapping.c:118]: (error) Uninitialized variable: page_size > > These are once again all false positives. I don't think there's any > point in continuing to post such reports, at least not until cppcheck > becomes more reliable. > Will report them to CPPcheck are you sure though all of these are false positives? chris

2 1

re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface
by Dan Kegel 11 Nov '09

11 Nov '09

As Nikolay pointed out, the change > /* the ones with offsets at the end are the same as in Windows */ > struct _IMAGELIST > { >+ const struct IImageListVtbl *lpVtbl;/* IImageList vtable */ >+ LONG ref; /* reference count */ >+ > DWORD magic; /* 00: 'SAMX' */ is wrong because it changes offsets... but it also breaks those comments. (Can you put the vtable at the end?)

2 1

Re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface
by Nikolay Sivov 11 Nov '09

11 Nov '09

On Wed, Nov 11, 2009 at 12:11 AM, Owen Rudge <orudge(a)codeweavers.com> wrote: > --- > dlls/comctl32/imagelist.c | 322 > ++++++++++++++++++++++++++++++++++++++++++++- > dlls/comctl32/imagelist.h | 3 + > 2 files changed, 319 insertions(+), 6 deletions(-) > After that: --- diff --git a/dlls/comctl32/imagelist.h b/dlls/comctl32/imagelist.h index 73ccd8a..51b8635 100644 --- a/dlls/comctl32/imagelist.h +++ b/dlls/comctl32/imagelist.h @@ -30,6 +30,9 @@ /* the ones with offsets at the end are the same as in Windows */ struct _IMAGELIST { + const struct IImageListVtbl *lpVtbl;/* IImageList vtable */ + LONG ref; /* reference count */ + DWORD magic; /* 00: 'SAMX' */ INT cCurImage; /* 04: ImageCount */ INT cMaxImage; /* 08: maximages */ --- let's pray that nobody depends on structure layout :). If it'll be a problem the possible solution could be to use two structure types - one for traditional API and one for com-based. Choosing one of it could be done possibly in ImageList_Create checking for manifest enabled in activation context. All traditional calls should check for that then and apply an offset to pointer to get HIMAGELIST without vtbl. We'll see...

1 0

Wine 64-bit in Fedora ...
by Michael Stefaniuc 11 Nov '09

11 Nov '09

Fedora includes now a 64-bit Wine package (at least in F11) which of course breaks existing Wine setups. "yum install wine" will install the 64-bit version... Looks like we had our WineConf too late for this. I have opened https://bugzilla.redhat.com/show_bug.cgi?id=533988 for this problem. The quick fix is to just remove the wine*.x86_64 rpms and install the wine*.i586 instead. bye michael

5 6

Re: setupapi: add stub and some tests for SetupGetInfFileListW [resend]
by Henri Verbeet 10 Nov '09

10 Nov '09

2009/11/9 Stefan Leichter <Stefan.Leichter(a)camline.com>: > my crystal ball is still not working, therefore resending unchanged > Try http://source.winehq.org/patches/ And indeed, the patch doesn't apply: diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c --- a/wine-git/dlls/setupapi/install.c +++ b/wine-build/dlls/setupapi/install.c Note that you're also adding whitespace errors.

3 4

Re: [PATCH 16/16] comctl32/tests: Remove todo_wine from SHGetImageList tests
by Paul Vriens 10 Nov '09

10 Nov '09

On 11/10/2009 07:12 PM, Owen Rudge wrote: > --- > dlls/comctl32/tests/imagelist.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Hi Owen, This patch suggest that one of the previous patches in this series makes the tests succeed or actually fail as they are inside a todo_wine(). -- Cheers, Paul.

2 1

Re: rsaenh/tests(3/5): Add round-trip test of RSA
by Paul Vriens 10 Nov '09

10 Nov '09

On 11/05/2009 07:11 PM, Juan Lang wrote: > --Juan > > Hi Juan, This one introduces some test failures on Win9x and WinMe: http://test.winehq.org/data/tests/rsaenh:rsaenh.html Could you have a look? -- Cheers, Paul.

1 0

Re: [8/9] widl: Add support for varargs functions.
by Paul Vriens 10 Nov '09

10 Nov '09

On 11/07/2009 03:55 PM, Rob Shearman wrote: > --- > dlls/rpcrt4/tests/server.c | 3 ++ > dlls/rpcrt4/tests/server.idl | 2 + > tools/widl/header.c | 68 ++++++++++++++++++++++------------------- > tools/widl/parser.l | 1 + > tools/widl/parser.y | 12 +++++-- > 5 files changed, 51 insertions(+), 35 deletions(-) > hi Rob, Either this one or "widl: Implement [range] attribute." introduced quite some test failures: http://test.winehq.org/data/tests/rpcrt4:server.html Could you please take a look? -- Cheers, Paul.

1 0

Re: [2/3] oledb32: Add test for marshalling IDBProperties.
by Paul Vriens 10 Nov '09

10 Nov '09

On 11/07/2009 01:29 PM, Rob Shearman wrote: > --- > dlls/oledb32/tests/Makefile.in | 5 +- > dlls/oledb32/tests/marshal.c | 272 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 275 insertions(+), 2 deletions(-) > create mode 100644 dlls/oledb32/tests/marshal.c > Hi Rob, The test results for these new tests don't look too great: http://test.winehq.org/data/tests/oledb32:marshal.html Could you have a look? -- Cheers, Paul.

1 0