December 2009 - Wine-devel - list.winehq.org

Re: [usp10 5/6] Fix the ABC width calculations in ScriptPlace
by Alexandre Julliard 18 Dec '09

18 Dec '09

Jason Green <jave27(a)gmail.com> writes: > - if (pABC) TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + if (pABC) > + { > + ABC tmp; > + > + > + /* the compositie 'A' width is simply the padding from the first glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[0], &tmp); > + pABC->abcA = tmp.abcA; > + > + /* the compositie 'C' width is simply the padding from the last glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[cGlyphs - 1], &tmp); > + pABC->abcC = tmp.abcC; > + > + /* since the 'B' width now includes the 'A' and 'C' widths, we must adjust it slightly */ > + pABC->abcB -= pABC->abcA + pABC->abcC; > + > + TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + } That's too complicated, there's no reason to retrieve the sizes twice, just handle that in the main loop. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [usp10 3/6] Fix the handling of spaces in ScriptBreak and ScriptShape
by Alexandre Julliard 18 Dec '09

18 Dec '09

Jason Green <jave27(a)gmail.com> writes: > commit 93b60cf8b1bcdabf008437b00cde35e162bdad1c > Author: Jason Green <jason(a)transgaming.com> > Date: Thu Dec 17 10:56:39 2009 -0500 > > Fix the handling of spaces in ScriptBreak and ScriptShape > From: Eric van Beurden <ericvb(a)transgaming.com> It doesn't work: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:1245: Test failed: fWhiteSpace set usp10.c:1256: Test failed: fWhiteSpace set make[2]: *** [usp10.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mapi32: add French translation
by Nicolas Le Cam 18 Dec '09

18 Dec '09

Hi Frédéric, Using "absence" and "installé" in the same sentence doesn't sound right. Something like "L'envoi de courriel a échoué car vous n'avez pas de client mail MAPI installé." or "L'envoi de courriel a échoué du fait de l'absence de client mail MAPI." should be simpler and more correct. -- Nicolas Le Cam

2 1

gcrypt windows build is done on linux, uses wine to run test suite
by Dan Kegel 18 Dec '09

18 Dec '09

Here's an interesting tidbit. gcrypt's windows version's only supported build environment is mingw on unix/linux, and it relies on wine to run its test suite. - Dan ---------- Forwarded message ---------- From: Simon Josefsson <simon(a)josefsson.org> Date: Thu, Dec 17, 2009 at 12:57 PM Subject: Re: gcrypt windows build To: "Hoyt, David" <hoyt6(a)llnl.gov> Cc: Werner Koch <wk(a)gnupg.org>, "gcrypt-devel(a)gnupg.org" <gcrypt-devel(a)gnupg.org> "Hoyt, David" <hoyt6(a)llnl.gov> writes: >> We only support cross-builds from a POSIX platform. If you try to build it on the traget platform it may or may not work. > > How do you test a cross-compiled library? How do you run your test > programs to validate your cross-compiled libraries are working > correctly? Do you have any tips on how I could get the test programs > working? Use wine. Just install MinGW and Wine under Linux, and then build libgcrypt like this: ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu It will invoke the self-tests automatically, if you have the binfmt-support package installed. If you want a makefile that does everything, check out <http://josefsson.org/gnutls4win/Makefile>. /Simon _______________________________________________ Gcrypt-devel mailing list Gcrypt-devel(a)gnupg.org http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

2 1

daily 16 bit tests?
by Joerg-Cyril.Hoehle＠t-systems.com 18 Dec '09

18 Dec '09

Hi, there have been a number of 16bit changes lately (accompanied by a few regressions) and I've been wondering whether some bot somewhere has been setup to execute 16 bit tests (I read that there's a 16bit testsuite somewhere, not integrated into Wine tests)? I believe that would be a good thing to have. BTW, I've come across a weird situation where a 16bit app crashes in "recent" Wine. Actually, I've an old build of wine-1.1.16 which works, but when I recompile 1.1.16 (or anything more recent) nowadays, the app crashes. Except for Ubuntu's security updates and installation of libmpg123, I don't see what's changed on this machine. Anybody with similar experience? Hmm, perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid... Regards, Jörg Höhle.

1 0

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.
by Eric Pouech 17 Dec '09

17 Dec '09

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: dcec342b50524562844f64d43d423ed2c83c1f97 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Dec 11 14:52:28 2009 +0100 > > user32: Add a thunking mechanism for 16-bit edit word break procedures. > > > Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Re: [5/5] WineD3D: Implement buffer subrange mapping with GL_APPLE_flush_buffer_range
by Henri Verbeet 17 Dec '09

17 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -85,6 +85,21 @@ static void buffer_create_buffer_object(struct wined3d_buffer *This) ... > + This->maps = HeapAlloc(GetProcessHeap(), 0, sizeof(*This->maps)); This is the wrong place for that. Either do it in buffer_init(), or in buffer_Map(). Keeping track of maps should also be in a separate patch, and you should integrate "lock_count". > +struct map_range A "wined3d_" prefix wouldn't hurt. > + LONG maps_size; Does a signed variable really make sense here? > + /* TODO: GL_ARB_map_buffer_range */ > + return gl_info->supported[APPLE_FLUSH_BUFFER_RANGE]; As a general rule, I think it makes sense to add support for ARB extensions (when available) before vendor specific extensions.

3 7

Re: [usp10 1/6] Fix an uninitialized static variable.
by Juan Lang 17 Dec '09

17 Dec '09

Hi Jason, - static const ABC nil; + static const ABC nil = {0}; This has no effect, as static variables are implicitly initialized to 0 anyway. It might be a little less surprising this way.. --Juan

3 6

Re: [dbghelp 1/2] Check for incorrectly set ClientPointers flag
by Eric Pouech 17 Dec '09

17 Dec '09

Jason Green a écrit : I don't think it's a good idea to change the exception structure passed by the caller to the minidump creation it's better to hard wire the optimization in dump_exception_info A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Valgrind warnings down 50% from last month
by Dan Kegel 17 Dec '09

17 Dec '09

The total count of valgrind warnings in the wine test suite has gone down from about 2000 a month ago http://kegel.com/wine/valgrind/logs/2009-11-16-19.12.errs.txt to about 1000 today http://kegel.com/wine/valgrind/logs/2009-12-15-07.57.errs.txt (as computed by http://kegel.com/wine/valgrind/logs/count.sh.txt ). Thanks to everyone who has been helping clean this up! Let's see if we can cut it down another 50% by this time next month...

1 2