February 2009 - Wine-devel - list.winehq.org

AppDB new design: Top 10s still look ugly
by André Hentschel 15 Feb '09

15 Feb '09

Hello, Bug #16466 is declared as fixed. but it isnt. my patch should do something else. I wanted let each top 10 in its own color(platin, gold or bronce) and not to have the platin-look for all. anything went wrong while using my patch. maybe the other patch went in, too? It should be this style: http://www.funplugged.bplaced.net/appdb/

2 2

Re: mshtml: Correctly test to see if PutProperty_CLASSIDPROP is called
by Alistair Leslie-Hughes 15 Feb '09

15 Feb '09

Ignore this, the subject is wrong. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:4997DB01.1000602(a)hotmail.com... > Hi, > > Changelog: > mshtml: Correctly test to see if PutProperty_CLASSIDPROP is called. > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From 14267df8f532c7acc7cc184c3c1e020639ca8702 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 6 Feb 2009 20:03:47 +1100 > Subject: [PATCH] Corrected tests > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/urlmon/tests/url.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c > index c062cf8..e5895c4 100644 > --- a/dlls/urlmon/tests/url.c > +++ b/dlls/urlmon/tests/url.c > @@ -313,7 +313,7 @@ static DWORD WINAPI thread_proc(PVOID arg) > CHECK_CALLED(Obj_OnProgress_BEGINSYNCOPERATION); > CHECK_CALLED(CreateInstance); > CHECK_CALLED(PutProperty_MIMETYPEPROP); > - CLEAR_CALLED(PutProperty_CLASSIDPROP); > + CHECK_CALLED(PutProperty_CLASSIDPROP); > CHECK_CALLED(Load); > CHECK_CALLED(Obj_OnProgress_ENDSYNCOPERATION); > CHECK_CALLED(OnObjectAvailable); > @@ -612,7 +612,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol > *iface, LPCWSTR szUrl, > CHECK_CALLED(Obj_OnProgress_BEGINSYNCOPERATION); > CHECK_CALLED(CreateInstance); > CHECK_CALLED(PutProperty_MIMETYPEPROP); > - CLEAR_CALLED(PutProperty_CLASSIDPROP); > + CHECK_CALLED(PutProperty_CLASSIDPROP); > CHECK_CALLED(Load); > CHECK_CALLED(Obj_OnProgress_ENDSYNCOPERATION); > CHECK_CALLED(OnObjectAvailable); > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Proposal: put Winetricks into Wine menu
by Dan Kegel 15 Feb '09

15 Feb '09

I know, when I wrote Winetricks, I meant it as a developers' tool only. But... then... people started using it, and it made sense to provide it as a way to download missing visual C++ runtimes etc. for average users. Quite a few newbies trip over the fact that it needs cabextract installed. Let's make it easy for folks, actually package it up along with Wine (SuSE does this already), and put it in the Wine menu right beneath "Uninstall Windows Software". What do people think? It might make life easier for a lot of folks. (And, come to think of it, we should include some documentation in that menu. "man wine" just doesn't cut it for the average gui user, and "wine manual page" in the gnome help browser is a broken link. But that's a separate issue.) - Dan

3 4

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel 15 Feb '09

15 Feb '09

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: [Bug 17104] Drives in winecfg can not be set correctly for paths containing non-latin (probably multibyte) characters. [utf-8]
by Austin English 15 Feb '09

15 Feb '09

On Sat, Feb 14, 2009 at 5:59 PM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=17104 > > > Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|RESOLVED |CLOSED > > > > > --- Comment #10 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-02-14 17:59:35 --- > Confirming fixed. > > Closing bug fixed in wine-1.1.15. > > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. > Perhaps we should wait for bugs to be closed by AJ in the next release, even if they were fixed in a previous release? That way, they should up in the release notes. Dan brought it up on another bug, and I agree...but figured it should be brought up here. Thoughts? -- -Austin

2 1

Re: mshtml: allow REG_EXPAND_SZ values for GeckoCabDir
by Juan Lang 14 Feb '09

14 Feb '09

Hi Christoph, - /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ - res = RegOpenKeyW(HKEY_CURRENT_USER, mshtml_keyW, &hkey); - if(res != ERROR_SUCCESS) - return FALSE; - file_name = heap_alloc(size+sizeof(GECKO_FILE_NAME)); - res = RegQueryValueExA(hkey, "GeckoCabDir", NULL, &type, (PBYTE)file_name, &size); + /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ + res = RegGetValueA(HKEY_CURRENT_USER, mshtml_keyA, "GeckoCabDir", RRF_RT_ANY, &type, (PBYTE)file_name, &size); This change is unrelated to the subject. One change per patch, please. + if(res != ERROR_SUCCESS || (type != REG_SZ && type != REG_EXPAND_SZ)) { heap_free(file_name); return FALSE; } If you're allowing REG_EXPAND_SZ, oughtn't you call ExpandEnvironmentVariablesA as well? --Juan

2 2

Re: Proposal: put Winetricks into Wine menu
by Dan Kegel 14 Feb '09

14 Feb '09

So, for people packaging wine, here's a proposed plan: 0. See http://wiki.winehq.org/winetricks if you're not familiar with winetricks 1. Download http://www.kegel.com/wine/winetricks (or get it via svn, see http://code.google.com/p/winezeug ) It's a monolithic shell script, so you don't need to compile it or anything. 2. Move it to /usr/bin and do chmod +x /usr/bin/winetricks 3. Add a dependecy on cabextract, sha1sum, and wget or curl. 4. In your package's changelog, note which version of Winetricks you pulled down. You'll want to pull down a fresh one every time you package Wine, as it contains download URLs that occasionally go stale. (In particular, I need to update the gecko URL for wine-1.1.5, I'll do that today.) The Suse packages already do all the above steps, I think; you might ask Marcus Meissner if you want to confirm the details. Here's the part that I don't think anybody does yet: 5. Add a menu item under Applications / Wine that runs /usr/bin/winetricks. In Ubuntu, the existing menu items are Programs Browse C: Drive Configure Wine Uninstall Wine Software Assuming we name the menu item Winetricks, the menu would then look like Programs Browse C: Drive Configure Wine Uninstall Wine Software Winetricks Now, at some point we should come up with a better menu item name than Winetricks, but I have no idea how to sum it up properly. winetricks has a fair bit of name recognition, and requires no localization, so let's run with that name until we figure out what it should really be called, and what the GUI really should look like in the end. (We also need a menu item there for "Help Using Wine", but nobody's written that yet. It can't just be links to the FAQ, since it has to work while offline.) Sound good? - Dan

3 3

GSoC 2009 coming up
by Kai Blin 14 Feb '09

14 Feb '09

Hi folks, the organization application period for GSoC 2009 is starting on March 9th, so it's time to get our http://wiki.winehq.org/SummerOfCode wiki page in shape again. Detlef Riekenberg and Roderick Colenbrander made a good start, so if the rest of you could check and make sure that all the projects on there still make sense? We should also investigate possible changes to the requirements (weekly reports to the mailing list come to mind). Maarten, any comments? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows
by Susan Cragin 14 Feb '09

14 Feb '09

>Hi, > >For those not monitoring slashdot [1], there is an article [2] that is >comparing the Google V8 benchmark on Windows and Linux versions of >Firefox 3. > >The result of this is that the Windows and Wine runs are pretty close >(241 vs 227) when compared to the Linux run (181) and Opera (155). > >I wonder what the results are like on Firefox 3.1 with tracemonkey >enabled on Windows, Wine and Linux. > >[1] http://tech.slashdot.org/article.pl?sid=09/02/13/0058251 >[2] http://www.tuxradar.com/content/browser-benchmarks-2-even-wine-beats-linux-… > >- Reece One thing that interested me... one person wrote that Linux/Firefox compiled with msvc was faster than gcc, because msvc is better at optimization. Has anyone tried compiling wine with msvc? Susan

3 2

msvcrt:file test failures under wine and winetest
by Austin Lund 14 Feb '09

14 Feb '09

I've been playing around with the odd failure that occurs on some platforms for the msvcrt:file tests. http://test.winehq.org/data/6a1537c4b5037be5253c33021fda3a02430533f7/#group… I am able to recreate it on my computer running ubuntu 8.10. (tag: apl-u810-dell630) I was trying to nail down what exactly problem was when I found the following: $ ./programs/winetest/winetest -o out -c msvcrt:file 2> /dev/null && tail -n 8 out Test output: msvcrt:file start dlls/msvcrt/tests/file.c - file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 462 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcrt:file done (0) It seemed to succeed when it was the only test run. I played around for a bit with this and found the combination of tests which causes the failure: $ ./programs/winetest/winetest -o out -c msvcrtd:debug msvcrt:file 2> /dev/null && tail -n 13 out Test output: msvcrtd:debug start dlls/msvcrtd/tests/debug.c - debug: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcrtd:debug done (0) msvcrt:file start dlls/msvcrt/tests/file.c - file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file.c:1057: Test failed: fstat(stdin) failed: errno=2 file.c:1066: Tests skipped: stdin is not a char device? st_mode=100666 file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 458 tests executed (0 marked as todo, 1 failure), 1 skipped. msvcrt:file done (1) Also of note is that when doing "make test" this failure never occurs. So whatever is going on, it is a strange interaction between msvcrtd:debug msvcrt:file tests and winetest. Another point to make is that the error that corresponds to errno=2 is "No such file or directory", which is an odd message for a filedes which is meant to be stdin. Does anyone have any tips on what to look at to nail this one down?

1 0