February 2009 - Wine-devel - list.winehq.org

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.
by Nikolay Sivov 12 Feb '09

12 Feb '09

Aric Stewart wrote: > --- > dlls/gdiplus/graphics.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 2673042..c276a43 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -1901,7 +1901,8 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > j++; > } > > - stringdup[j] = 0; > + if (j < length) > + stringdup[j] = 0; > length = j; > > while(sum < length){ > Hm, maybe I don't follow something, but I think 'j < length' is always true after that: --- for(i = 0, j = 0; i < length; i++){ if(!isprintW(string[i]) && (string[i] != '\n')) continue; stringdup[j] = string[i]; j++; } stringdup[j] = 0; length = j; --- Or you thought about zero length case? It should be handled earlier, on stringdup allocation or before...

2 1

Re: [2/2] tools/winemaker.man.in: update man-page
by Nikolay Sivov 12 Feb '09

12 Feb '09

André Hentschel wrote: > sorry, had the wrong mail-account last time. > updating the man-page of winemaker. > there were such old things, there was dust on it! > > > > No attachment here...

1 0

Re: mshtml: Implement IHTMLStyle get/put minHeight (resend)
by Jacek Caban 12 Feb '09

12 Feb '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put minHeight > [get|set]_nsstyle_attr_var functions were introduces to avoid the code duplication like you do. You should use them (and probably implement VT_I4 handling in set_nsstyle_attr_var). Jacek

1 0

Is the test.winehq.org front page too pessimistic?
by Juan Lang 12 Feb '09

12 Feb '09

The front page of test.winehq.org shows statistics about failed tests, but it doesn't seem to take into account the number of individual tests that passed and failed, rather the number of files that had any failures. So, for example, about a week ago I got a fix committed for some failing mapi32 tests. Looking at the machines with test failures, before the fix was committed, 139 tests were run, with 134 of them failing, whereas after the fix was committed, the same number of tests were run, with only 6 of them failing. Nonetheless, the 4th of February shows a higher failure rate (14.6%) than the 3rd of February (12.4%). I know other tests could have started failing in the interim, but it seems like we've been putting a fair amount of effort into reducing test failures lately, while the percent of failed tests isn't going down, at least not on the main page. If you look at a particular day's results, the numbers look a bit better over time. I'm not sending a patch, because there may be different opinions on this. That is, perhaps some people like to see a statistic on the number of files with failing tests on any machine, which the front page appears to show, while others may like to see the number of failures in a particular file, which a day's results show. My own opinion is that it's hard to get motivated to fix something without some sort of positive feedback for it, so changing the front page would be better. My own feeling is that there are far fewer failing tests now than there used to be, and I'd sure like to see that reflected somewhere at a quick glance. Thoughts? --Juan

8 11

Re: mshtml: Implement IHTMLStyle_put_textDecorationUnderline (resend)
by Jacek Caban 12 Feb '09

12 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle_put_textDecorationUnderline + + return set_style_attr(This, STYLEID_TEXT_DECORATION, v == VARIANT_TRUE ? valUnderline : emptyW, 0); You shouldn't compare v to VARIANT_TRUE. The correct way to deal with bool values is 'v ? valUnderline : emptyW'. Jacek

1 0

ntdll: Avoid Potential Infinite Loop
by Paul Bryan Roberts 12 Feb '09

12 Feb '09

Hi, I expect this patch will be accepted due to precedent - a few months ago I submitted the same patch for the same problem in a different routine in a different compilation unit of ntdll. Yes, I guess the infinite loop does not occur in practice (someone would have noticed) and I guess it has been there a very long time. But it isn't exactly hard to spot - I was speed reading the code looking for something else. I've seen a lot of chatter recently about something called Coverity. I looked it up on Wikipedia (after checking the spelling). Apart from it's obvious use as a conversation piece, is it proving useful to the project ? Is there a feedback policy ? Something like "We think your product is superlative .... but someone may wonder if your code not finding this bug in our code might be a bug in your code." Security :); false sense of security :( Paul Bryan Roberts >From dd2f31b0176e795edf5b1eb081410de7ed5ed03d Mon Sep 17 00:00:00 2001 From: Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> Date: Thu, 12 Feb 2009 08:09:17 +0000 Subject: ntdll: avoid potential infinite loop --- dlls/ntdll/nt.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c index 879a324..dc81648 100644 --- a/dlls/ntdll/nt.c +++ b/dlls/ntdll/nt.c @@ -293,17 +293,20 @@ NTSTATUS WINAPI NtQueryInformationToken( char stack_buffer[256]; unsigned int server_buf_len = sizeof(stack_buffer); void *buffer = stack_buffer; - BOOLEAN need_more_memory = FALSE; + BOOLEAN need_more_memory; /* we cannot work out the size of the server buffer required for the * input size, since there are two factors affecting how much can be * stored in the buffer - number of groups and lengths of sids */ do { + need_more_memory = FALSE; + SERVER_START_REQ( get_token_groups ) { TOKEN_GROUPS *groups = tokeninfo; + req->handle = wine_server_obj_handle( token ); wine_server_set_reply( req, buffer, server_buf_len ); status = wine_server_call( req ); -- 1.5.4.3

2 1

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.
by Paul Vriens 12 Feb '09

12 Feb '09

Huw Davies wrote: > --- > dlls/gdi32/tests/font.c | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > > ------------------------------------------------------------------------ > > Looks a lot like: http://www.winehq.org/pipermail/wine-patches/2009-February/069297.html Maybe we should use yours as it has less changes to the code. -- Cheers, Paul.

2 1

Download page requires too much scrolling...
by Dan Kegel 12 Feb '09

12 Feb '09

While I was generating screenshots for my presentation, I noticed that http://www.winehq.org/download/ has too much clutter at the top. I don't mind the Codeweavers ad, but it's not good that users have to scroll down to see the useful part of the page...

2 1

Wine64 : Trying to load PE image for unsupported architecture (I386)
by Erik de Castro Lopo 12 Feb '09

12 Feb '09

Hi all, I build Wine64 using the instructions here: http://wiki.winehq.org/Wine64 While I expected it to not work with my Win64 program I was a little surprised that when running a WIn32 program I got: Trying to load PE image for unsupported architecture (I386) I realise that the Win64 stuff is experimental but I'm curions, in the longer term is it expected that one executable will be able to run both Win32 and Win64 executables? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- J. Headley: "God, root, what is difference ?" G. Haverland: "God can change the byte order on the CPU, root can't."

6 7

Fwd: Need Your Help about "dll" on linux
by Jigar Joshi 12 Feb '09

12 Feb '09

---------- Forwarded message ---------- From: Jigar Joshi <jigarjm(a)gmail.com> Date: Mon, Feb 9, 2009 at 6:53 PM Subject: Need Your Help about "dll" on linux To: wine-devel(a)winehq.org Respected sir, i refered your post at http://www.winehq.org/pipermail/wine-devel/2007-April/055855.html i want to know have you completed successfully that project? (using dll on linux) please reply soon . actually i have dlls derived from c , i dont have c code and i need to use those dlls on linus using java (JNI), first i tried to convert dll to ".so" bt i couldn't. . . read your post and got some moral support please reply soon . . . Regards Jigar

1 0