February 2009 - Wine-devel - list.winehq.org

Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows
by Reece Dunn 14 Feb '09

14 Feb '09

Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when compared to the Linux run (181) and Opera (155). I wonder what the results are like on Firefox 3.1 with tracemonkey enabled on Windows, Wine and Linux. [1] http://tech.slashdot.org/article.pl?sid=09/02/13/0058251 [2] http://www.tuxradar.com/content/browser-benchmarks-2-even-wine-beats-linux-… - Reece

3 3

Re: atmlib: add stub dll
by Nikolay Sivov 13 Feb '09

13 Feb '09

Austin English wrote: > Needed by photoshop cs4. See bug 16385. > > diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c > new file mode 100644 > index 0000000..bb17989 > --- /dev/null > +++ b/dlls/atmlib/atmlib_main.c > @@ -0,0 +1,45 @@ > +/* > + * MSSIGN32 implementation > + * > + * Copyright 2009 Austin English > + * > Hi, Austin, not mssign32 ).

2 2

Re: wintrust(3/3): Fix a couple tests on a variety of systems
by Ge van Geldorp 13 Feb '09

13 Feb '09

> From: Alexandre Julliard <julliard(a)winehq.org> > > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > > > I sent out an email earlier to ask if we should include more > > information in the header of the report. We could use that > > information, if this change will be accepted by AJ, to > > limit the reporting only to boxes were we have admin rights. > > > > As soon as all boxes have zero failures (yeah, right) we > > can remove that limit. > > Yes, we will want to fix these tests eventually, since we > will some day support multi-user setups where normal users > won't have admin rights, and we will need tests to make sure > we fail the right way. But in the meantime we can certainly > block these reports and concentrate on the more meaningful failures. I'll take that as a hint to switch my test machines to full admin. Should result in quite a bit more green. Ge.

1 0

Re: [sane.ds try2 1/3] Get resolution from sane, instead of hard coding -1.
by Juan Lang 13 Feb '09

13 Feb '09

Hi Jeremy, a couple comments: - pImageInfo->XResolution.Whole = -1; + if (sane_option_get_int(activeDS.deviceHandle, "resolution", &resolution) == SANE_STATUS_GOOD) + pImageInfo->XResolution.Whole = pImageInfo->YResolution.Whole = resolution; (snip) +/* Option functions */ +#ifdef SONAME_LIBSANE +SANE_Status sane_option_get_int(SANE_Handle h, const char *option_name, SANE_Int *val); +#endif With this change, sane.ds will not compile unless SONAME_LIBSANE is defined. Is this intended? More likely not, and you need to provide a version of sane_option_get_int when it isn't defined, or use an #ifdef at the call site (ick.) The other comment is, is adding a new file (option.c) really necessary? If you're planning to expand it a lot, perhaps, but just for this one small function it looks like overkill to me. --Juan

2 2

RFC: patch to advapi32's cred tests
by Juan Lang 13 Feb '09

13 Feb '09

Hi all, I've written a patch which should fix the failing advapi32 cred tests that mirrors the skips in the existing tests: diff --git a/dlls/advapi32/tests/cred.c b/dlls/advapi32/tests/cred.c index 58103c6..bb6935b 100644 --- a/dlls/advapi32/tests/cred.c +++ b/dlls/advapi32/tests/cred.c @@ -238,7 +238,13 @@ static void test_generic(void) new_cred.UserName = (char *)"winetest"; ret = pCredWriteA(&new_cred, 0); - ok(ret, "CredWriteA failed with error %d\n", GetLastError()); + ok(ret || broken(GetLastError() == ERROR_NO_SUCH_LOGON_SESSION), + "CredWriteA failed with error %d\n", GetLastError()); + if (!ret) + { + skip("couldn't write generic credentials, skipping tests\n"); + return; + } ret = pCredEnumerateA(NULL, 0, &count, &creds); ok(ret, "CredEnumerateA failed with error %d\n", GetLastError()); I'm wondering whether a better patch would be to change the persist type from CRED_PERSIST_ENTERPRISE to CRED_PERSIST_LOCAL_MACHINE. Rob, this is particularly aimed at you since you wrote the original tests: is there a good reason to use CRED_PERSIST_ENTERPRISE here? --Juan

2 2

How to get more info on timed out/crashed tests?
by Juan Lang 13 Feb '09

13 Feb '09

Hi all, there are a number of tests at test.winehq.org that indicate that they're timed out or crashed. The difficulty is, I have no access to machines running the version of Windows on which the test is timing out or failing, and the data about the crash are not helpful in pinpointing the failing test. How can we get more information about these timeouts/crashes? --Juan

3 3

RE: [1/2] gdiplus/tests: Some tests for Image raw format value
by Nikolay Sivov 13 Feb '09

13 Feb '09

Anything wrong with that? http://www.winehq.org/pipermail/wine-patches/2009-February/069267.html http://www.winehq.org/pipermail/wine-patches/2009-February/069273.html

1 0

Re: wintrust(3/3): Fix a couple tests on a variety of systems
by Paul Vriens 13 Feb '09

13 Feb '09

Juan Lang wrote: > --Juan > > > ------------------------------------------------------------------------ > > This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. -- Cheers, Paul.

4 5

Proposed goal for website: happily usable at 800x600?
by Dan Kegel 13 Feb '09

13 Feb '09

What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy to simulate, just resize your browser until xwininfo says it's 800x550, those gnome top and bottom bars chew 25 pixels each). That's asking a lot, I suppose... - Dan

7 9

Re: [PATCH] comdlg32: check for lfs NULL ptr (Coverity)
by Alexandre Julliard 13 Feb '09

13 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > CID 119, 188, resubmit with working patch from earlier round. > > I guess we could also just let it crash if this happens, but > I am not feeling comfortable. These are internal functions, it doesn't make sense to call them with NULL. -- Alexandre Julliard julliard(a)winehq.org

1 0