February 2009 - Wine-devel - list.winehq.org

Re: [imaadp32 2/3] fixed adpcm_FormatSuggest
by Detlef Riekenberg 28 Feb '09

28 Feb '09

On Fr, 2009-02-27 at 20:07 +0100, Stefano Guidoni wrote: > case WAVE_FORMAT_IMA_ADPCM: > - adfs->pwfxDst->nBlockAlign = 1024; > + init_wfx_ima_adpcm((IMAADPCMWAVEFORMAT*)adfs->pwfxDst); > /* FIXME: not handling header overhead */ > TRACE("setting spb=%u\n", > ((IMAADPCMWAVEFORMAT*)adfs->pwfxDst)->wSamplesPerBlock); > + /* check if result is ok */ > + if (ADPCM_GetFormatIndex(adfs->pwfxDst) == 0xFFFFFFFF) return > ACMERR_NOTPOSSIBLE; > break; While reading the diff, it's visible, that you screw the indention up. (Mix SPACE and TAB) -- By by ... Detlef

1 0

Bugzilla down!
by Stefan Leichter 28 Feb '09

28 Feb '09

Hi, i'm getting ------------------------------------------------------------------------------ Software error: Can't connect to the database. Error: User winehq already has more than 'max_user_connections' active connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig? For help, please send mail to the webmaster (bugs-admin(a)winehq.org) giving this error message and the time and date of the error. ------------------------------------------------------------------------------ when i try to reach http://bugs.winehq.org

2 1

Lost disc 1 of WP Office 2002 :-(
by Dan Kegel 27 Feb '09

27 Feb '09

I went to the trouble of buying a copy of WordPerfect Office 2002 a while ago, and just tried installing it again - but I seem to have lost disc 1. Anyone have a copy they're not using anymore? I have disc 2 and a serial number, just no disc 1 :-(

1 0

Revoking my gpg key 0x4C40A6D9 (Was: Re: mcicda: Compare a file handle with INVALID_HANDLE_VALUE instead of NULL.)
by Michael Stefaniuc 27 Feb '09

27 Feb '09

How embarrassing! Having to revoke my new (9 days old) gpg key 0x4C40A6D9. Yes, that was a big part of the passphrase for that key in the CC field ... -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: A revocation certificate should follow iH4EIBECAD4FAkmocts3HQJTZW50IHBhcnQgb2YgdGhlIHBhc3NwaHJhc2UgdG8g YSBwdWJsaWMgbWFpbGluZyBsaXN0LgAKCRAiLf+YTECm2emfAJ4lg1KaduK1eDw6 gASivxMpRHxZpgCeLaO+C3Vn2XVFCoH3WaxHAO5xZV0= =zhsP -----END PGP PUBLIC KEY BLOCK----- /me hangs head in shame michael Michael Stefaniuc wrote: > --- > dlls/mcicda/mcicda.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/mcicda/mcicda.c b/dlls/mcicda/mcicda.c > index 79f3bae..81dc18f 100644 > --- a/dlls/mcicda/mcicda.c > +++ b/dlls/mcicda/mcicda.c > @@ -463,7 +463,7 @@ static DWORD MCICDA_Open(UINT wDevID, DWORD dwFlags, LPMCI_OPEN_PARMSW lpOpenPar > /* now, open the handle */ > root[0] = root[1] = '\\'; root[2] = '.'; root[3] = '\\'; root[4] = drive; root[5] = ':'; root[6] = '\0'; > wmcda->handle = CreateFileW(root, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > - if (wmcda->handle != 0) > + if (wmcda->handle != INVALID_HANDLE_VALUE) > return 0; > > the_error: >

1 0

Time to integrate win16 test suite?
by Dan Kegel 27 Feb '09

27 Feb '09

Now that we support building 16 bit executables, it seems like a good time to think about integrating the 16 bit test suite, currently hibernating at http://win16test.googlecode.com Any takers?

1 0

Re: gdi32: Revert an unrelated part of 028617b90ba586bdb30723c700eea888c159ada7.
by Byeongsik Jeon 27 Feb '09

27 Feb '09

Yes!!! See the http://bugs.winehq.org/show_bug.cgi?id=17218 http://www.winehq.org/pipermail/wine-patches/2009-February/068752.html http://www.winehq.org/pipermail/wine-patches/2009-February/068753.html 2009-02-27 (Fri), 17:57 +0800, Dmitry Timoshkov wrote: > It was not a very nice idea to break bitmap fonts which request a custom > width (therefore a transformation) in a patch that pretended to do something > unrelated. > --- > dlls/gdi32/freetype.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 6ca35c3..54bb999 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -4606,9 +4606,9 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, > } > > if(ft_face->glyph->format != ft_glyph_format_outline && > - (needsTransform || format == GGO_NATIVE || format == GGO_BEZIER || > - format == GGO_GRAY2_BITMAP || format == GGO_GRAY4_BITMAP || > - format == GGO_GRAY8_BITMAP)) > + (format == GGO_NATIVE || format == GGO_BEZIER || > + format == GGO_GRAY2_BITMAP || format == GGO_GRAY4_BITMAP || > + format == GGO_GRAY8_BITMAP)) > { > TRACE("loaded a bitmap\n"); > LeaveCriticalSection( &freetype_cs );

1 1

Re: msi: Add reinstall tests.
by Detlef Riekenberg 27 Feb '09

27 Feb '09

On Do, 2009-02-26 at 10:50 +0100, Hans Leidekker wrote: > + state = 0xdeadbee; > + action = 0xdeadbee; > + r = MsiGetFeatureState(hpkg, "one", &state, &action); > + ok( r == ERROR_UNKNOWN_FEATURE, "Expected ERROR_UNKNOWN_FEATURE, > got %d\n", r ); > + ok( state == 0xdeadbee, "Expected 0xdeadbee, got %d\n", state); > + ok( action == 0xdeadbee, "Expected 0xdeadbee, got %d\n", action); > + > + state = 0xdeadbee; > + action = 0xdeadbee; > + r = MsiGetFeatureState(hpkg, "two", &state, &action); > + ok( r == ERROR_UNKNOWN_FEATURE, "Expected ERROR_UNKNOWN_FEATURE, > got %d\n", r ); > + ok( state == 0xdeadbee, "Expected 0xdeadbee, got %d\n", state); > + ok( action == 0xdeadbee, "Expected 0xdeadbee, got %d\n", action); > + > + state = 0xdeadbee; > + action = 0xdeadbee; > + r = MsiGetFeatureState(hpkg, "three", &state, &action); > + ok( r == ERROR_UNKNOWN_FEATURE, "Expected ERROR_UNKNOWN_FEATURE, > got %d\n", r ); > + ok( state == 0xdeadbee, "Expected 0xdeadbee, got %d\n", state); > + ok( action == 0xdeadbee, "Expected 0xdeadbee, got %d\n", action); This is huge amount of almost the same code in that test. Please use tables. -- By by ... Detlef

1 0

Re: gdi32: Revert an unrelated part of 028617b90ba586bdb30723c700eea888c159ada7.
by Michael Karcher 27 Feb '09

27 Feb '09

Am Freitag, den 27.02.2009, 17:57 +0800 schrieb Dmitry Timoshkov: > It was not a very nice idea to break bitmap fonts which request a custom > width (therefore a transformation) in a patch that pretended to do something > unrelated. It also "breaks" fake italic bitmap fonts, i.e. previously the fake italic transformation was just ignored, so roman characters were displayed, now WineEngGetGlyphOutline runs into this error case, breaking applications trying to use "MS Sans Serif" in italic. Regards, Michael Karcher

1 0

TrainingPeaks WKO+ Version 22 build 105
by Chris Teague 26 Feb '09

26 Feb '09

I'm trying to use WKO, it is software which communicates via USB to an external device (watch/heart rate monitor/bike odometer) using FTDI drivers. When I plug in the device dmesg tells me it's recognized and placed on /dev/ttyUSB0. I've put a link to that inside of .wine/dosdevices/com1. I still can't get communication to work, on stdout I get the following message repeated many times: fixme:comm:wait_on EV_RXFLAG not handled I think I know how to implement this feature of Win32 serial comm, but before I attempted I wanted to broadcast my intent to do so. Is anyone else working on this, or in the serial.c area that would like to discuss it? Software is available as demo here: http://home.trainingpeaks.com/wko-desktop-software/download.aspx

2 3

Wine64 and other test failures
by Austin English 26 Feb '09

26 Feb '09

Howdy, For those of y'all not monitoring http://test.winehq.org/data, I've begun submitting daily test results for Wine64. There are also test results for regular 32-bit wine, wine in a virtual desktop, and with WINEDEBUG=+heap. Regular wine is passing a majority of the time (Ubuntu Jaunty 64-bit, Nvidia 9800 GTX). Virtual desktop has a couple failures in gdi32 (bug 12768) and some user32 tests, otherwise passes. +heap has a few failures: winmm/mci - http://bugs.winehq.org/show_bug.cgi?id=17518 mshtml/dom - http://bugs.winehq.org/show_bug.cgi?id=17520 oleaut32/tmarshal - http://bugs.winehq.org/show_bug.cgi?id=17412 netapi32/access - http://bugs.winehq.org/show_bug.cgi?id=17530 There were a few other bugs in crypt32, jscript, msi and user32, but AJ, Juan, and Jacek fixed those. Couple other related bugs: +relay qmgr/qmgr - http://bugs.winehq.org/show_bug.cgi?id=17521 +message comctl32/datetime - http://bugs.winehq.org/show_bug.cgi?id=17431 I had to find some way to keep y'all busy, since 32-bit winetest is passing now :-). -- -Austin

1 0