February 2009 - Wine-devel - list.winehq.org

Re: [2/2] WineD3D: Create a common sampling function in GLSL
by Henri Verbeet 25 Feb '09

25 Feb '09

2009/2/24 Stefan Dösinger <stefan(a)codeweavers.com>: > > +static void shader_glsl_gen_sample_code(const SHADER_OPCODE_ARG *arg, DWORD sampler, const char *coord_reg, > + const glsl_sample_function_t *sample_function, const char *dst_swizzle, > + const char *bias) { You need to pass dst_swizzle as a swizzle + write mask instead of a string. As an API it's nicer than passing in random strings, but you will also need this when you're going to integrate the fixup code. I think it's a bit silly to pass sample_function to this function, the caller will only call shader_glsl_get_sample_function() to pass it to this function, so you might as well call it yourself. > + shader_glsl_append_dst(arg->buffer, arg); I'm not sure about this one. It's not strictly necessary to do this in the caller, but it would be more consistent between different instruction handlers to do it there, and have shader_glsl_gen_sample_code() only generate the second part of the line. I think it would be nicer to avoid the stack buffers foor coord_reg, either by splitting shader_glsl_gen_sample_code() in two functions to generate the start and end, or by passing it a format string for coord_reg. > + sprintf(instr, "%sLod", sample_function.name); > + sample_function.name = instr; > + shader_glsl_gen_sample_code(arg, sampler_idx, coord_param.param_str, > + &sample_function, dst_swizzle, > + lod_param.param_str); This is just ugly.

1 0

aquamark 3 crashing on startup?
by Dan Kegel 25 Feb '09

25 Feb '09

I was hoping to demo aquamark 3, but it now crashes for me on startup. Did I forget the magic incantation to run it successfully? http://appdb.winehq.org/objectManager.php?sClass=version&iId=6616

1 0

Re: [2/2] WineD3D: Create a common sampling function in GLSL
by Paul Vriens 24 Feb '09

24 Feb '09

Stefan Dösinger wrote: > > > You forgot the patch ;) -- Cheers, Paul.

1 0

Re: [6/6] shell32: implement Get/SetIDList on ShellItem objects
by Alexandre Julliard 24 Feb '09

24 Feb '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > + ILFree(This->pidl); > + This->pidl = ILClone(pidl); > + if (This->pidl) > + return S_OK; > + else > + return E_OUTOFMEMORY; You should check for success before you free the previous pidl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine's malware compatibility: good
by David Gerard 24 Feb '09

24 Feb '09

http://www.trustedsource.org/blog/186/Running-Windows-Malware-in-Linux With apps like ZeroWine, we can I think expect to see Windows binaries that try int 0x80 calls just because they might be useful and a Linux box will make a much more robust host. - d.

1 0

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET
by Nicolas Le Cam 24 Feb '09

24 Feb '09

2009/2/24 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > This makes sure that if we have a dll that's only provided via .NET it can > still > be found. Now both our extraction (and the generation of the subtest list) > and > the real test will find the dll. > > The downside (and hence this is a bit hackish) is that we extend the PATH > for > every test. For now it's only gdiplus that needs this btw as that dll can > also > exist without .NET (if I'm correct) and these tests directly import gdiplus. > > Changelog > Extend PATH if we have dll's that only come with .NET > > -- > Cheers, > > Paul. > > > >From 3cf6c1e876ac032aab988efa0751b26b9643cf93 Mon Sep 17 00:00:00 2001 > From: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> > Date: Tue, 24 Feb 2009 14:05:26 +0100 > Subject: [PATCH] Extend PATH if we have dll's that only come with .NET > > --- > programs/winetest/main.c | 28 +++++++++++++++++++++++++++- > 1 files changed, 27 insertions(+), 1 deletions(-) > > diff --git a/programs/winetest/main.c b/programs/winetest/main.c > index 74a4307..ee390ec 100644 > --- a/programs/winetest/main.c > +++ b/programs/winetest/main.c > @@ -542,7 +542,33 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, > if (!dll && pLoadLibraryShim) > { > MultiByteToWideChar(CP_ACP, 0, dllname, -1, dllnameW, MAX_PATH); > - if (FAILED( pLoadLibraryShim(dllnameW, NULL, NULL, &dll) )) dll = > 0; > + if (FAILED( pLoadLibraryShim(dllnameW, NULL, NULL, &dll) )) > + dll = 0; > + else > + { > + char *newpath; > + char dllpath[MAX_PATH]; > + DWORD needed, pathlen = 0; > + > + /* Extend the path so get_subtests() and the test itself can > find > + * the dll (gdiplus for example). > + */ > + GetModuleFileNameA(dll, dllpath, MAX_PATH); > + *strrchr(dllpath, '\\') = '\0'; > + > + needed = GetEnvironmentVariableA("PATH", NULL, 0); > + > + /* current path + ';' + dllpath + '\0' */ > + pathlen = needed + 1 + strlen(dllpath) + 1; > + newpath = xmalloc(pathlen); > + GetEnvironmentVariable("PATH", newpath, pathlen); > + > + strcat(newpath, ";"); > + strcat(newpath, dllpath); > + SetEnvironmentVariableA("PATH", newpath); > + > + free(newpath); > + } > } > if (!dll) { > xprintf (" %s=dll is missing\n", dllname); > -- > 1.6.0.6 > > > > > > What about extending wine_test struct with a path variable that will be set and restored around the CreateProcess call in run_ex if not null ? -- Nicolas Le Cam

2 1

Simple but awesome demos of Wine?
by Dan Kegel 24 Feb '09

24 Feb '09

I'm going to be giving a Wine presentation at Cebit next month. You can see a draft of the presentation at http://kegel.com/wine/cebit2009/talk.html (I will say lots more than is written there; the slides are kept simple on purpose, with just the key idea in the caption.) A large part of the presentation will be demos of platium-rated apps. Can people suggest compelling apps to demo? Right now my list is kind of boring-sounding: Framemaker 7 Kid Pix gp-Untis Photoshop cs2 Futuretax Dreamweaver It'd be nice to also have some games, but I don't play enough to know which ones to pick. I suspect online games are out, since I can't count on an internet connection. I'm tempted to write an autohotkey script to demo each app so I don't have to worry about fumbling mouse clicks while on stage. The ability to script would be a nice demo itself. This show is a big opportunity for us to introduce Wine to a large audience, so any help here would be appreciated.

18 29

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.
by Francois Gouget 24 Feb '09

24 Feb '09

On Sun, 22 Feb 2009, Nicolas Le Cam wrote: > This avoid a messagebox in regression tests on systems that don't have > GdiPlus. This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere. Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me. So I think that if there's any issue, it's on the winetest.exe side. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

6 10

Re: advapi32: Stubs for GetNamedSecurityInfoEx (attempt 4)
by Austin English 24 Feb '09

24 Feb '09

On Tue, Feb 24, 2009 at 1:59 AM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > Reference bug 14334 (WordPerfect Office 2002: Unable to Install) > > Use of breakpoints in a debugger under WindowsTM has shown that > GetNamedSecurityInfoExA is called during a normal installation. From > this we infer that some kind of implementation of this routine is > necessary if the app in question is ever to install. It has been > determined empirically that a empty sub is sufficient. > > This attempt has been written without reference to the previous attempts > or to the piclist web site. It takes on board feedback received and has > done after study of carefully distilled precedent exposed at: > > http://wiki.jswindle.com/index.php/Stubs_Partially_Explained#Brief_Stub_Cod… > > http://wiki.jswindle.com/index.php/Coding_Hints:Patches#Copyright > > The patch provides a stub pair for the A and W forms of > GetNamedSecurityInfoEx. Prototypes in include/aclapi.h, implementations > in advapi32/security.c and the whats-it-called in advapi32/advapi32.spec. > > No reference to GetNamedSecurityInfoEx is to be found on the MSDN > web-site: the signature of these stubs is derived by splicing to > together GetNamedSecurityInfo and GetSecurityInfoEx (as found in > aclapi.h etc). You forgot the patch :-). -- -Austin

1 0

Re: faultrep:display useful information in ReportFault
by Jérôme Gardou 23 Feb '09

23 Feb '09

Jérôme Gardou a écrit : > This should help debugging applications which performs their own > exception handling. After a bit of thinking, I think that this should be displayed each time the function is called. Is there any macro in wine/debug.h which would display a message, even when WINEDEBUG is set to "-all" ?

7 20