February 2009 - Wine-devel - list.winehq.org

Wine shirt
by Jeremiah Flerchinger 26 Feb '09

26 Feb '09

I saw the previous Wine t-shirt, with the drunken penguin, but it wasn't really me and I don't think there are anymore anyways. For those of you who didn't know about it, I don't think it was advertised very well (maybe we should have had a products tab or links in World Wine News more regularly). I started playing with zazzle.com and ideas for a Wine shirt for myself. Here's what I have so far in case anyone cares or would like one too: http://www.zazzle.com/tuxg2_wine_t_shirt-235593182956669764 I plan on giving half of any profits to Wine through their donation page & use the rest to set up some Wine embroidery items (I'm thinking a hat & zip-up sweatshirt). After that I'll update the amount that goes to Wine. I thought it was a nice approach because it's print on demand and it's possible for people to customize with their own slogans instead of having to vote on one. Later, -J

1 0

Re: user32: In SetMenuInfo() implement the MIM_APPLYTOSUBMENUS with test.
by Alexandre Julliard 26 Feb '09

26 Feb '09

Rein Klazes <wijn(a)online.nl> writes: > Also in Get/SetMenuInfo set last error if called with invalid parameters. Please use the appropriate function pointers in the test so that it still runs on older platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

CUDA Wrapper and unimplemented functions kernel32
by Seth Shelnutt 26 Feb '09

26 Feb '09

A while back you guys had helped with developing the CUDA wrapper. Some changes in the folding at home GPU2 client core, has caused us the need to update it with newer functions implemented. However it seems now that the wrapper is getting an error, which appears to be related to Wine itself. $ wine ./FahCore_14.exe -suffix 01 -nodelete wine: Call from 0x7edb2a73 to unimplemented function kernel32.dll., aborting err:module:attach_process_dlls "cudart.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"Z:\\home\\daz\\core14test2\\FahCore_14.exe" failed, status 80000100 What do you guys make of it? The CUDA wrapper and source can be downloaded from http://www.twomurs.com/seth/patches/new/ . For instructions on how to set it up, see our wiki http://gpu2.twomurs.com/index.php?title=Linux . The only difference is instead of downloading the wrapper linked there, download the one I linked to above. Also to test out the new F(a)H core which is causing the update and the subsiquent kernel issue, before you run the F(a)Hclient, download these two files, and place them in the same directory you have the f(a)h cient, - core: http://fah-web.stanford.edu/ihaque/FahCore_14.exe MD5 hash: 4e4621e3cbe1e4069c264c449615c127 - WU: http://fah-web.stanford.edu/ihaque/wudata_01.dat MD5 hash: 8d4e47c17445a8deca403caa52fbcb6f Thanks for the help, Seth Shelnutt

1 0

Malware on Wine review
by Dan Kegel 25 Feb '09

25 Feb '09

http://www.avertlabs.com/research/blog/index.php/2009/02/23/running-windows… is an interesting report; all the malware he tried ran to at least some extent on wine. One interesting bit of advice he gives at the end is "Do not set the file association for Windows executables with Wine. This would enable running Windows executables in Wine by simply double clicking them." I saw a patch floating by to turn this on by default recently. Maybe we should make it off by default, but easy to turn on...?

15 46

Cursor patches
by Andrew Riedi 25 Feb '09

25 Feb '09

Attached are some cursor patches I have been working on. These patches store the cursor in the wineserver, clean up user32 a little bit, draw .ani cursors more completely, and ultimately implement themed cursors. I am sending them here for some last review (big thanks to Henri for taking some time to give me some tips where I can improve my code) before wine-patches. Even though I have tested these patches best I can, more testing can never hurt, so I would appreciate any replies from people who want to test the patches. I would like to most hear from AJ about the first few patches and if I am moving cursors into the wineserver correctly or not. -- Andrew Riedi

1 0

Re: shell32: add a message for opening files with no association
by Austin English 25 Feb '09

25 Feb '09

2009/2/25 Vincent Povirk <madewokherd+8cd9(a)gmail.com>: > Fixes bug 17485. > > Vincent Povirk > > > > diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc index f752e6d..d7fa7c3 100644 --- a/dlls/shell32/shell32_En.rc +++ b/dlls/shell32/shell32_En.rc @@ -282,6 +282,8 @@ STRINGTABLE IDS_CPANEL_TITLE "Wine Control Panel" IDS_CPANEL_NAME "Name" IDS_CPANEL_DESCRIPTION "Description" + + IDS_SHLEXEC_NOASSOC "There is no Windows program configured to open this type of file." } Not sure if it matters for .rc files, but you're using spaces whereas the earlier entries are using tabs. -- -Austin

2 1

wiki.winehq.org down?
by Dan Kegel 25 Feb '09

25 Feb '09

I can't get pages from http://wiki.winehq.org, though I can ping lattica.ca. The web server there seems to close connections after a long pause without any response. it looks like the wiki server needs restarting?

2 1

Re: crypt32: Fix more test failures on Win9x
by Paul Vriens 25 Feb '09

25 Feb '09

Juan Lang wrote: > --Juan > > > ------------------------------------------------------------------------ > > Hi Juan, The first 4 changes are not correct. Win9x returns TRUE (1) here. -- Cheers, Paul.

1 1

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)
by Nicolas Le Cam 25 Feb '09

25 Feb '09

Hi Paul, minor comments : > programs/winetest/main.c | 60 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 59 insertions(+), 1 deletions(-) > > diff --git a/programs/winetest/main.c b/programs/winetest/main.c > index 74a4307..58e520b 100644 > --- a/programs/winetest/main.c > +++ b/programs/winetest/main.c > @@ -44,6 +44,7 @@ struct wine_test > int subtest_count; > char **subtests; > char *exename; > + char *maindllpath; > }; > > char *tag = NULL; > @@ -61,6 +62,9 @@ static unsigned int nb_filters = 0; > static HMODULE hmscoree; > static HRESULT (WINAPI *pLoadLibraryShim)(LPCWSTR, LPCWSTR, LPVOID, HMODULE > *); > > +/* To store the current PATH setting (related to .NET only provided dlls) > */ > +static char *curpath; > + > /* check if test is being filtered out */ > static BOOL test_filtered_out( LPCSTR module, LPCSTR testname ) > { > @@ -341,6 +345,19 @@ static DWORD wait_process( HANDLE process, DWORD > timeout ) > return WAIT_TIMEOUT; > } > > +static void append_path( const char *path) > +{ > + char *newpath; > + > + newpath = xmalloc(strlen(curpath) + 1 + strlen(path) + 1); > + strcpy(newpath, curpath); > + strcat(newpath, ";"); > + strcat(newpath, path); > + SetEnvironmentVariableA("PATH", newpath); > + > + free(newpath); > +} Perhaps use newpath = strmake( NULL, "%s;%s", curpath, path); I don't know. (I used it in a similar patch that I was making yesterday) > + > /* Run a command for MS milliseconds. If OUT != NULL, also redirect > stdout to there. > > @@ -446,8 +463,16 @@ get_subtests (const char *tempdir, struct wine_test > *test, LPTSTR res_name) > > extract_test (test, tempdir, res_name); > cmd = strmake (NULL, "%s --list", test->exename); > + if (test->maindllpath) { > + /* We need to add the path (to the main dll) to PATH */ > + append_path(test->maindllpath); > + } > status = run_ex (cmd, subfile, tempdir, 5000); > err = GetLastError(); > + if (test->maindllpath) { > + /* Restore PATH again */ > + SetEnvironmentVariableA("PATH", curpath); > + } > free (cmd); > > if (status == -2) > @@ -538,11 +563,27 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, > strcpy(dllname, lpszName); > *strstr(dllname, testexe) = 0; > > + wine_tests[nr_of_files].maindllpath = NULL; > dll = LoadLibraryExA(dllname, NULL, LOAD_LIBRARY_AS_DATAFILE); > if (!dll && pLoadLibraryShim) > { > MultiByteToWideChar(CP_ACP, 0, dllname, -1, dllnameW, MAX_PATH); > - if (FAILED( pLoadLibraryShim(dllnameW, NULL, NULL, &dll) )) dll = > 0; > + if (FAILED( pLoadLibraryShim(dllnameW, NULL, NULL, &dll) )) > + dll = 0; > + else > + { > + char dllpath[MAX_PATH]; dllpath should be declared at start of the function IMHO. > + > + /* We have a dll that cannot be found through LoadLibraryExA. > This > + * is the case for .NET provided dll's. We will add the > directory > + * where the dll resides to the PATH variable when dealing with > + * the tests for this dll. > + */ > + GetModuleFileNameA(dll, dllpath, MAX_PATH); > + *strrchr(dllpath, '\\') = '\0'; > + wine_tests[nr_of_files].maindllpath = xmalloc(strlen(dllpath) + > 1); > + strcpy(wine_tests[nr_of_files].maindllpath, dllpath); > + } This won't work if test needs more than one dll found through LoadLibraryShim > } > if (!dll) { > xprintf (" %s=dll is missing\n", dllname); > @@ -578,6 +619,12 @@ run_tests (char *logname) > DWORD strsize; > SECURITY_ATTRIBUTES sa; > char tmppath[MAX_PATH], tempdir[MAX_PATH+4]; > + DWORD needed; > + > + /* Get the current PATH only once */ > + needed = GetEnvironmentVariableA("PATH", NULL, 0); > + curpath = xmalloc(needed); > + GetEnvironmentVariable("PATH", curpath, needed); This should be GetEnvironmentVariableA. > > SetErrorMode (SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX); > > @@ -684,11 +731,21 @@ run_tests (char *logname) > struct wine_test *test = wine_tests + i; > int j; > > + if (test->maindllpath) { > + /* We need to add the path (to the main dll) to PATH */ > + append_path(test->maindllpath); > + } > + > for (j = 0; j < test->subtest_count; j++) { > report (R_STEP, "Running: %s:%s", test->name, > test->subtests[j]); > run_test (test, test->subtests[j], logfile, tempdir); > } > + > + if (test->maindllpath) { > + /* Restore PATH again */ > + SetEnvironmentVariableA("PATH", curpath); > + } > } > report (R_DELTA, 0, "Running: Done"); > > @@ -697,6 +754,7 @@ run_tests (char *logname) > logfile = 0; > remove_dir (tempdir); > free (wine_tests); > + free (curpath); > > return logname; > } I did a similar patch yesterday but forget to set PATH around run_ex in get_subtests so it didn't work when I tested on my W2K Pro test platform. Thanks for your work -- Nicolas Le Cam

2 4

Re: [1/3] wordpad: Added missing string values for some languages.
by Michael Stefaniuc 25 Feb '09

25 Feb '09

Hello Dylan, please do not add the English strings for stringtable resources that aren't broken (here the Hungarian translation). It makes it hard to automatically detect (http://www.mikolaj.zalewski.pl/wine-transl/) if the resource is translated or not. Also you have fixed only the traditional Chinese stringtable but not the simplified Chinese one in the same Zh.rc file. The best way to check for translation errors is to pass --verify-translation to the wrc command invoked from the Makefile and look for ERR and DIFF lines. Dylan Smith wrote: > There were some string that were only available in for certain > languages, so I copied the english version of these values. > --- > programs/wordpad/Da.rc | 5 +++++ > programs/wordpad/Hu.rc | 18 ++++++++++++++++++ > programs/wordpad/Ja.rc | 1 + > programs/wordpad/No.rc | 1 + > programs/wordpad/Pl.rc | 5 +++++ > programs/wordpad/Ru.rc | 6 +++++- > programs/wordpad/Tr.rc | 5 +++++ > programs/wordpad/Zh.rc | 1 + > 8 files changed, 41 insertions(+), 1 deletions(-) > bye michael

1 0