August 2009 - Wine-devel - list.winehq.org

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.
by Alexandre Julliard 20 Aug '09

20 Aug '09

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) > return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); > } > > +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) > +{ > + return (IXMLDOMNode*)&This->lpVtbl; > +} That wrapper doesn't follow any established naming convention, and doesn't seem quite necessary. The standard way is to simply cast to the interface type. If you really want a wrapper it should be called something like IXMLDOMNode_from_impl. -- Alexandre Julliard julliard(a)winehq.org

2 3

GSoC - Wine/Gstreamer
by Trevor Davenport 20 Aug '09

20 Aug '09

Hi, I wanted to send a mail to the list and basically state what the status of all this is and what my plans are for the future. For those unfamiliar with what i was doing, I was trying to enable using gstreamer elements as directshow filter to expand the quartz functionality available. At the start of the program I was not very familiar with quartz so it took a fair amount of learning to get up to speed with it. The basic ability to use a gstreamer element is mostly there. More work is needed to finish up a few aspects of it though. The source commited to my github repo does expose one working element if you have the gstreamer mp3 plugin installed. A little bit more work is needed to map more formats so that more elements can be exposed. I had hoped to do this before the program deadline but it just ended up not being possible. But i plan to keep working on this. I'd like to see it commited if possible. My plans are essentially the following: * expand the format mapping so most audio elements (ones that operate on one input and one output) can be exposed * add to the quartz filter registry * clean up anything I can find (i am sure there is a leak or two, etc) * finish build setup - configure option and library finding issue (seems to pickup 64bit version on 64bit system...which won't work...) * start patch review More long term I want to start more general quartz work. Implementing some of the currently unimplemented features such as dynamic pin reconnection would help. I want to do this as well as start cleaning up a few areas I found while trying to find what was happening. I also want to continue working on this to allow more elements, specifically the demuxers from gstreamer which should be able to the take the place of avisplitter and mpegsplitter but have more features. I didn't get as far as i had wanted to due to how much I had to learn about directshow and time was constantly a issue. Nothing really uses the new filter currently expect my little test mp3 player, which is also available in the github repo (just search for tdaven, both the wine and the test programs are in my personal repo). It seems the quartz dsound element sometimes (i've had it often) does not mix well when using alsa as the audio driver over pulseaudio. If it sounds extremely slow this is the cause. I've not tracked down exactly what is going on in this case, but using raw alsa or something else has never demonstrated the issue. Took me a good while to find this was the cause though. If there are any questions I'd be glad to answer whatever. Cheers, Trevor Davenport

1 0

Re: winemp3.acm: link to system libmpg123.so
by Alex Villacís Lasso 20 Aug '09

20 Aug '09

Aric Stewart escribió: > --- > configure.ac | 12 + > dlls/winemp3.acm/Makefile.in | 11 +- > dlls/winemp3.acm/common.c | 261 ------- > dlls/winemp3.acm/dct64_i386.c | 329 -------- > dlls/winemp3.acm/decode_i386.c | 164 ---- > dlls/winemp3.acm/huffman.h | 346 --------- > dlls/winemp3.acm/interface.c | 254 ------- > dlls/winemp3.acm/l2tables.h | 175 ----- > dlls/winemp3.acm/layer1.c | 159 ---- > dlls/winemp3.acm/layer2.c | 301 -------- > dlls/winemp3.acm/layer3.c | 1613 > ---------------------------------------- > dlls/winemp3.acm/mpegl3.c | 119 ++-- > dlls/winemp3.acm/mpg123.h | 166 ---- > dlls/winemp3.acm/mpglib.h | 69 -- > dlls/winemp3.acm/tabinit.c | 95 --- > 15 files changed, 81 insertions(+), 3993 deletions(-) > delete mode 100644 dlls/winemp3.acm/common.c > delete mode 100644 dlls/winemp3.acm/dct64_i386.c > delete mode 100644 dlls/winemp3.acm/decode_i386.c > delete mode 100644 dlls/winemp3.acm/huffman.h > delete mode 100644 dlls/winemp3.acm/interface.c > delete mode 100644 dlls/winemp3.acm/l2tables.h > delete mode 100644 dlls/winemp3.acm/layer1.c > delete mode 100644 dlls/winemp3.acm/layer2.c > delete mode 100644 dlls/winemp3.acm/layer3.c > delete mode 100644 dlls/winemp3.acm/mpg123.h > delete mode 100644 dlls/winemp3.acm/mpglib.h > delete mode 100644 dlls/winemp3.acm/tabinit.c > > > ------------------------------------------------------------------------ > > The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame. -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

7 12

Re: [2/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban 20 Aug '09

20 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement > + else if( IsEqualGUID( riid, &IID_IDispatch ) || + IsEqualGUID( riid, &IID_IDispatchEx ) ) + { + xmlnode *node = impl_from_IXMLDOMNode( This->node ); + + dispex_query_interface(&node->dispex, riid, ppvObject); + + return *ppvObject ? S_OK : E_NOINTERFACE; + } This should be handled by node's QueryInterface implementation. + + xmlnode = impl_from_IXMLDOMNode( This->node ); It's not about your code as you follow msxml3 design, but this is ugly and it shouldn't be needed. + init_dispex(&xmlnode->dispex, (IUnknown*)&This->lpVtbl, &domelem_dispex); init_dispex is first called in create_basic_node, so you initialize it second time here. IMO msxml3 object inheritance needs serious design changes and it would be better to do it before adding IDispatchEx support for node implementations. I will send a few first patches. Thanks, Jacek

1 0

Re: wined3d: have SetAutoGenFilterType call glHint
by Henri Verbeet 20 Aug '09

20 Aug '09

2009/8/20 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > This fixes bug #11167. It depends on my previous patch. > > One unclear issue about glHint() is the scope. > What textures does it affect? When? > > An alternative would be, as Stefan Dösinger puts it: "just check if > the app ever sets two contradicting filter types" but I don't know how > "global" the effect of glHint() is (per UNIX process, per .exe, > per GL context, per active texture, per ...)? > > Another alternative would be to replace SetAutoGen with just a FIXME > to at least get rid of the bogus >>>>>> glTexParameter call. > This isn't quite correct. The hint indeed applies to the entire context, and you should map the linear filter to GL_NICEST. We should probably generate mipmaps explicitly with glGenerateMipmapEXT() if the FBO extension is available.

1 0

Request for test on at least one Windows box
by Juan Lang 19 Aug '09

19 Aug '09

Hi all, could someone with the ability to build and run a test on Windows run the attached test for me? I have a fix for bug 19760, but I'd just like to double check that it's correct before sending it in (and I don't have access to Windows at the moment.) Please copy the list on the reply so not too many people end up doing it. Cheers, --Juan

2 2

Wine Development Stats
by André Hentschel 19 Aug '09

19 Aug '09

Hi, inspired by "Linux Kernel Development: How Fast it is Going, Who is Doing It, What They are Doing, and Who is Sponsoring It: An August 2009 Update" (http://www.linuxfoundation.org/publications/whowriteslinux.pdf) i thought we might do a similar analyse of the wine tree. I attach a first overview made with gitdm, the tool they used, too. Is there some interest to do a similar PDF? -- Best Regards, André Hentschel

2 1

Re: ole32: On big endian machines, copy strings to little endian order without mucking with the map they're stored in (try 2)
by Alexandre Julliard 19 Aug '09

19 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > +#ifdef WORDS_BIGENDIAN > +/* Returns a byte-swapped copy of str, to be freed with HeapFree(). */ > +static LPWSTR PropertyStorage_StringToLE(LPCWSTR str, size_t len) > +{ > + LPWSTR leStr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + if (leStr) > + { > + memcpy(leStr, str, len * sizeof(WCHAR)); > + PropertyStorage_ByteSwapString(leStr, len); > + } > + return leStr; > +} > +#else > +#define PropertyStorage_StringToLE(s, l) (LPWSTR)(s) > +#endif You are still casting away const... -- Alexandre Julliard julliard(a)winehq.org

2 2

GSoC 2009 Final evaluations due
by Kai Blin 19 Aug '09

19 Aug '09

Hi folks, GSoC 2009 is wrapping up and the final evaluations are due. So far only one student and no mentors have filled out the surveys, so please take your time and take care of that soon. The results are due on Monday, but I'd prefer if I had some room to deal with any issues coming up, so please try to get the surveys in as soon as possible. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [1/3] WineD3D: Use a sane default refresh rate
by Henri Verbeet 19 Aug '09

19 Aug '09

2009/8/19 Stefan Dösinger <stefan(a)codeweavers.com>: > and its value(=0) is not sane MSDN seems to disagree. "The value of 0 indicates an adapter default."

2 4