August 2009 - Wine-devel - list.winehq.org

Re: gdiplus: Implement GdipIsVisibleRect
by Andrew Eikum 17 Aug '09

17 Aug '09

Andrew Eikum wrote: > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 47 +++++++++-- > dlls/gdiplus/tests/graphics.c | 180 > +++++++++++++++++++++++++++++++++++++++++ > include/gdiplusflat.h | 2 + > 4 files changed, 221 insertions(+), 10 deletions(-) > > > > ------------------------------------------------------------------------ > > Don't apply. I just found out these should call GdipIsVisibleRegion*. Will fix shortly.

1 0

Re: [7/10] windowscodecs: implement CopyPixels for GIF decoder (resend)
by Reece Dunn 17 Aug '09

17 Aug '09

2009/8/17 Vincent Povirk <vincent(a)codeweavers.com>: > This time with correct interlacing code. Patch?

1 0

Re: [13/18] wpp: Add wpp_set_exit_on_error function
by Juan Lang 17 Aug '09

17 Aug '09

Hi Matteo, this approach seems pretty inflexible to me: +/* Whether to exit the app on errors (default: true) */ +extern void wpp_set_exit_on_error( int exit ); @@ -646,7 +654,8 @@ int ppy_error(const char *s, ...) va_start(ap, s); generic_msg(s, "Error", ppy_text, ap); va_end(ap); - exit(1); + if(pp_status.exit_on_error) exit(1); + else pp_status.state = 1; return 1; } It seems as though you might instead have a global error function that should be called, which defaults to exit(). In fact, that's what ppy_error seems to be. So I think you'd want to make ppy_error into a function pointer, and make the current definition its default value, or something like that. I can't imagine that retaining the output to stderr is all that useful in the context of the D3D9 shader assembler. You could further split this patch: this is half of it, setting and dealing with the exit_on_error flag. The other half deals with the current assumption that ppy_error never returns. You can make removing that assumption one patch, and this--changing the error function to something else--a subsequent patch. --Juan

2 1

Re: [7/10] windowscodecs: implement CopyPixels for GIF decoder
by Vincent Povirk 17 Aug '09

17 Aug '09

Don't commit this. I screwed up the interlacing. On Mon, Aug 17, 2009 at 2:01 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

Re: mshtml: Implement OmNavigator_get_appName
by Jacek Caban 17 Aug '09

17 Aug '09

Hi Vladimir, Vladimir Pankratov wrote: > Hello all. > > Implemented OmNavigator_get_appName. Please add a test. Jacek

1 0

Re: [1/18] d3dx9: Add shader assembler private definitions
by Stefan Dösinger 17 Aug '09

17 Aug '09

Am Sunday 16 August 2009 19:50:54 schrieb Matteo Bruni: > This is a long patch series that implements the D3D shader assembler > and D3DXAssembleShader function. The first part has already passed a > couple of rounds of review in wine-devel. The patches look ok for applying to me. I didn't look deeply at the later patches yet(no time), and will look later. The base structure seems ok, I know earlier versions of the ASM code, and if there are some smaller issues they can be fixed incrementally. Its probably easier to discuss and fix them(if there are any) once the base code is in. Its a new feature, so it shouldn't cause any regressions.

1 0

Re: [PATCH 6/6] wined3d: Make RTL_READTEX the default rendertarget locking method.
by Stefan Dösinger 17 Aug '09

17 Aug '09

Am Friday 14 August 2009 09:23:25 schrieb Henri Verbeet: > For most cards this should make more sense than RTL_READDRAW, even if e.g. > surface_upload_data() has some room for improvement. I don't think this is a good idea until the READDRAW code has the ability to only upload a part of the surface if a limited rectangle was locked > --- > dlls/wined3d/surface.c | 1 - > dlls/wined3d/wined3d_main.c | 2 +- > dlls/wined3d/wined3d_private.h | 1 - > 3 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 29ad00d..781a6b2 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -1518,7 +1518,6 @@ static HRESULT WINAPI > IWineD3DSurfaceImpl_UnlockRect(IWineD3DSurface *iface) { > IWineD3DSurface_LoadLocation(iface, SFLAG_INTEXTURE, NULL /* partial > texture loading not supported yet */); /* drop through */ > > - case RTL_AUTO: > case RTL_READDRAW: > IWineD3DSurface_LoadLocation(iface, SFLAG_INDRAWABLE, > fullsurface ? NULL : &This->dirtyRect); break; > diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c > index 881f90e..4feb509 100644 > --- a/dlls/wined3d/wined3d_main.c > +++ b/dlls/wined3d/wined3d_main.c > @@ -41,7 +41,7 @@ wined3d_settings_t wined3d_settings = > PS_HW, /* Hardware by default */ > TRUE, /* Use of GLSL enabled by default */ > ORM_FBO, /* Use FBOs to do offscreen rendering */ > - RTL_AUTO, /* Automatically determine best locking method */ > + RTL_READTEX, /* Default render target locking method */ > PCI_VENDOR_NONE,/* PCI Vendor ID */ > PCI_DEVICE_NONE,/* PCI Device ID */ > 0, /* The default of memory is set in FillGLCaps */ > diff --git a/dlls/wined3d/wined3d_private.h > b/dlls/wined3d/wined3d_private.h index 8df99f6..5f88afd 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -267,7 +267,6 @@ static inline float float_24_to_32(DWORD in) > #define SHADER_NONE 4 > > #define RTL_DISABLE -1 > -#define RTL_AUTO 0 > #define RTL_READDRAW 1 > #define RTL_READTEX 2

3 5

Regression Testing 0.9.60/0.9.61
by James McKenzie 17 Aug '09

17 Aug '09

Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was working on. I've received guidance from Dylan Smith on how to redo the patch and I will once I get the old patch working with 1.0. Guidance on how to use git to run bisect tests would be appreciated. Do I get the commit numbers from the Tag messages that AJ sends? James McKenzie

3 3

Re: winecfg: Let the user specify the drive letter of a to be added drive.
by Austin English 16 Aug '09

16 Aug '09

On Sun, Aug 16, 2009 at 1:12 PM, Rein Klazes<wijn(a)online.nl> wrote: > fixes bug#14728 > --- > programs/winecfg/Bg.rc | 10 +++++++++ > programs/winecfg/Cs.rc | 10 +++++++++ > programs/winecfg/Da.rc | 10 +++++++++ > programs/winecfg/De.rc | 10 +++++++++ > programs/winecfg/En.rc | 10 +++++++++ > programs/winecfg/Es.rc | 10 +++++++++ > programs/winecfg/Fi.rc | 10 +++++++++ > programs/winecfg/Fr.rc | 10 +++++++++ > programs/winecfg/Hu.rc | 10 +++++++++ > programs/winecfg/It.rc | 10 +++++++++ > programs/winecfg/Ja.rc | 10 +++++++++ > programs/winecfg/Ko.rc | 10 +++++++++ > programs/winecfg/Lt.rc | 10 +++++++++ > programs/winecfg/Nl.rc | 10 +++++++++ > programs/winecfg/No.rc | 10 +++++++++ > programs/winecfg/Pl.rc | 10 +++++++++ > programs/winecfg/Pt.rc | 20 +++++++++++++++++ > programs/winecfg/Ro.rc | 10 +++++++++ > programs/winecfg/Ru.rc | 10 +++++++++ > programs/winecfg/Si.rc | 10 +++++++++ > programs/winecfg/Sv.rc | 10 +++++++++ > programs/winecfg/Tr.rc | 10 +++++++++ > programs/winecfg/Zh.rc | 20 +++++++++++++++++ > programs/winecfg/driveui.c | 48 ++++++++++++++++++++++++++++++++++++++++++- > programs/winecfg/resource.h | 2 + > 25 files changed, 299 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/Bg.rc b/programs/winecfg/Bg.rc > index fcdf895..8ac2c67 100644 > --- a/programs/winecfg/Bg.rc > +++ b/programs/winecfg/Bg.rc > @@ -128,6 +128,16 @@ BEGIN > PUSHBUTTON "Îòìåíè",IDCANCEL,77,74,45,14,WS_GROUP > END > > +IDD_DRIVECHOOSE DIALOG DISCARDABLE 60, 70, 170, 60 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +CAPTION "Select Drive Letter" > +FONT 8, "MS Shell Dlg" Howdy Rein, I don't believe you're supposed to add English resources to non-English rc files. The dialog will automatically fall back to English if not present. It messes up the translation stats.. -- -Austin

3 2

When do regressions become high priority for developers?
by Matt Perry 16 Aug '09

16 Aug '09

When do regressions become high priority for developers? I ask because I opened bug 13583 over 14 months ago, provided all the information requested, as did other people, and nothing has happened. The program worked with Wine 0.9.53 but has been broken since then. I have continued to test the program on newer versions of Wine occasionally, but the bug persists. In fact, I am starting to see more regressions in recent Wine builds that prevent me from getting to the point in the program where I can test the regression reported in the bug report. 14 months seems to be more than reasonable to repair a regression. I'm worried about having to forever maintain a separate installation of Wine just to use this program. I'll be happy to test further if someone is going to work on this bug but right now my efforts seem to be for naught. Should I bother to continue to give this bug any attention or just abandon it and focus my efforts elsewhere? Matt

5 4