August 2009 - Wine-devel - list.winehq.org

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by James Mckenzie 21 Aug '09

21 Aug '09

Rico: Which patch is the correct one? Please send it in with (try 3). James McKenzie -----Original Message----- >From: Rico Schüller <kgbricola(a)web.de> >Sent: Aug 21, 2009 9:16 AM >To: wine-patches(a)winehq.org >Subject: Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc. > >Am 21.08.2009 17:46, schrieb Rico Schüller: >> --- >> dlls/d3d10/d3d10_private.h | 3 ++- >> dlls/d3d10/effect.c | 25 ++++++++++++++++++------- >> 2 files changed, 20 insertions(+), 8 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> >> >Hi, > >the previous patch was wrong, take this one instead of the other one. > >Rico >

1 0

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by Rico Schüller 21 Aug '09

21 Aug '09

Am 21.08.2009 17:46, schrieb Rico Schüller: > --- > dlls/d3d10/d3d10_private.h | 3 ++- > dlls/d3d10/effect.c | 25 ++++++++++++++++++------- > 2 files changed, 20 insertions(+), 8 deletions(-) > > > ------------------------------------------------------------------------ > > > Hi, the previous patch was wrong, take this one instead of the other one. Rico

1 0

Bug for beginners
by Alexandros Dermenakis 21 Aug '09

21 Aug '09

Hi all, I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. thank you

5 6

Re: Bug for beginners
by James Mckenzie 21 Aug '09

21 Aug '09

>On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum ><andrew(a)brightnightgames.com>wrote: > >> Alexandros Dermenakis wrote: >> >>> Hi all, >>> >>> I studied the wine developer's guide and went a bit through the code. I >>> would like a suggestion, a bug to start understanding better the structure >>> of wine and familiarize myself with it in order to be able to contribute >>> more in the future. >>> >>> thank you >>> >>> >> Hi Alexandros, >> >> When I began working on Wine, I found that the easiest way for me was to >> implement parts of Wine that have no implementation yet. Implementing new >> functions means you don't have to worry about breaking old tests or >> re-arranging and understanding someone else's code. It also gives you the >> opportunity to write new tests from the ground up, so you get used to >> exactly what the unit tests are for and how they work. >> >> Look around in Wine for functions that are labeled with FIXMEs indicating >> that they are stubs, or look in the .spec files for functions declared as >> stubs. Find a function that has an easy to understand purpose: a very clear >> input and output. Then, write unit tests in that DLL's test suite that >> prove all of the important features of that function. Run your tests on an >> actual Windows OS (look into "crosstests") and verify that they are correct. >> Finally, implement that function in Wine to make it also pass your tests. >> >> If you want a suggestion for where to look for small stubs, take a look at >> gdi32 and gdiplus. I know they still have some smallish, unimplemented or >> half-implemented functions. If graphics don't interest you, there are >> plenty of stubs elsewhere. >> >> Once you've got the hang of how the unit tests work (I mean it, the test >> cases are the most important part of getting patches into Wine), try looking >> into bugs on WineHQ until you find one you think you might be able to >> handle. Then gear up for the most fun you'll ever have reading pages and >> pages debug logs :) >> >> No matter where you begin your work, remember that Wine is a difficult >> project to work on. Because even very subtle changes can cause breakages in >> seemingly unrelated parts of Wine, the standard for patches is very high. >> You will need to prove that your patch is correct using the test suites. >> No provable tests means it's not getting in. >> >> Good luck and thanks for your interest, >> Andrew >> >> >> >As I understand from Wine's policies, functions should only be implemented >if an application requires them. If that's correct, a random search for >stubs isn't a good idea, because the follow up question would be "which >application requires this function?". > One idea is to look at Bugzilla for a problem report that exists because a specific function does not exist. For instance, I have been working on a bug with EM_FORMATRANGE and trying to update the fix included to work with the current Wine version as several programs rely on the ability to change fonts in specific windows. I have a working fix for 0.9.59 and my time was and continues to be diverted to other efforts, not necessarily this fix. However, I would like assistance in moving the patch forward and into Wine. There are other bug reports where the fix is 'hacky' and needs to be cleaned up so, in many cases a conformance/compliance test is all that is needed. This would be a great place to start where you can look at the current Wine code base, what someone came up with as a fix and what needs to make the fix workable. You don't have to look for an application that requires a certain function that works in a specific manner. James McKenzie

1 0

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]
by Alexandre Julliard 21 Aug '09

21 Aug '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,32 +1713,35 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR buffer[MAX_PATH], xlpFile[MAX_PATH]; > - LPWSTR space, s; > + LPWSTR space; > > - LPWSTR beg = wszApplicationName/*sei_tmp.lpFile*/; > - for(s=beg; (space=strchrW(s, ' ')); s=space+1) { > - int idx = space-sei_tmp.lpFile; > - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); > + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); > + space = buffer + strlenW(buffer); > + do Searching from the end doesn't look right. This would need a test case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: mshtml: Implement IHTMLStyle get/put wordSpacing
by Jacek Caban 21 Aug '09

21 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLStyle get/put wordSpacing static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v) { - HTMLStyle *This = HTMLSTYLE_THIS(iface); - FIXME("(%p)->(v%d)\n", This, V_VT(&v)); - return E_NOTIMPL; + HTMLStyle *This = HTMLSTYLE_THIS(iface); + TRACE("(%p)->(v%d)\n", This, V_VT(&v)); + return set_nsstyle_attr_var(This->nsstyle, STYLEID_WORD_SPACING, &v, 0); The indention here is wrong. + hres = IHTMLStyle_get_wordSpacing(style, &v); + ok(hres == S_OK, "get_wordSpacing: %08x\n", hres); + ok(!strcmp_wa(V_BSTR(&v), "10px"), "expected 10px = %s\n", wine_dbgstr_w(V_BSTR(&v))); + VariantClear(&v); Please add a test for V_VT(&v) == VT_BSTR. Jacek

1 0

Re: kernel32: test GetPrivateProfileString with empty string as key and section
by Michael Stefaniuc 21 Aug '09

21 Aug '09

Hello Stefan, Stefan Leichter wrote: > Problem spotted from Claudio Fontana on wine-devel > > tested on Win2K > diff -ruw wine-git/dlls/kernel32/tests/profile.c wine-build/dlls/kernel32/tests/profile.c > --- wine-git/dlls/kernel32/tests/profile.c 2009-06-04 19:00:09.000000000 +0200 > +++ wine-build/dlls/kernel32/tests/profile.c 2009-08-16 23:03:37.000000000 +0200 > @@ -41,6 +41,13 @@ > UINT result9x; > }; > > +static const char *debugstr_w(LPCWSTR str) you don't need to add a local debugstr_w implementation anymore. Alexandre added wine_dbgstr_w() to test.h two days ago with commit ee868cce5b412b103ff167deb59c3d5237363199. > +{ > + static char buf[1024]; > + WideCharToMultiByte(CP_ACP, 0, str, -1, buf, sizeof(buf), NULL, NULL); > + return buf; > +} > + > static void test_profile_int(void) > { > struct _profileInt profileInt[]={ bye michael

1 0

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
by Alexandre Julliard 20 Aug '09

20 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > TRACE("socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n", > s, level, optname, optval, *optlen); > > + /* Some apps sign-extend the level, so mask off the higher-order bits */ > + level &= 0x0000ffff; There can be several other ways to handle this, it needs test cases to determine which way Windows is using. -- Alexandre Julliard julliard(a)winehq.org

3 5

re: old patch enabling visible icons in some applications
by Dan Kegel 20 Aug '09

20 Aug '09

trueflyingsheep wrote: > why didn't it make it into the release? Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it. Thanks! - Dan

6 7

Re: [PATCH 02/12] windowscodecs: Add IWICStream_InitializeFromMemory implementation [try 2]
by Alexandre Julliard 20 Aug '09

20 Aug '09

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + * > + * Used by IWICStream_InitializeFromMemory > + * This interface is windowscodecs private only which > + * is why we don't need to implement QueryInterface and AddRef Don't do that, implement it properly even if that code is not used at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0