August 2009 - Wine-devel - list.winehq.org

Conformance tests
by Keith Muir 14 Aug '09

14 Aug '09

What disturbs me about the conformance tests is that yes there are 0% failures but when you check you discover its 0% failures on virtual machines. Failures on real hardware under XP can reach as high as 6% with peaks greater than that. Windows is tolerant of all types of hardware wine still isn't. I may be stating the obvious but hardware tolerance must be a goal for the wine project if it isn't already. Regards, Keith

2 1

Re: shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces (resend)
by Juan Lang 14 Aug '09

14 Aug '09

Hi Stefan, I know this is nitpicking, but: - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); + while((space=strchrW(buffer, ' '))) You're mixing tabs and spaces here. --Juan

2 3

RE: about video memory detection in wine
by Sun, Sunny 14 Aug '09

14 Aug '09

Hi I am sorry I forgot to introduce myself. I am a software engineer at AMD, working on OpenGL graphics driver, I am working with wine issues now. Some uses complained that there are too many issues to play games with wine with AMD graphics card, so we want to improve the quality. That's all, Thanks Regards Sunny ________________________________ From: Sun, Sunny Sent: Wednesday, August 12, 2009 4:04 PM To: 'wine-devel(a)winehq.org' Cc: Jin, Jian-Rong; Hu, Li; Guan, Xiao-Feng; Wang, Robin Subject: about video memory detection in wine Hi You are using the hardcoded method to get the vidmem now (in function IWineD3DImpl_FillGLCaps), first you call glGetString(GL_RENDERER) to get the GPU renderer string, and then you use this string to set the vidmem in your code. Unfortunately you don't get all of the ATI GPU's string now, for our workstation GPU, the string is always like "ATI FireGL V8700", so you don't recognize this GPU and consider it as ATI_RADEON_9500, then 64MB is set which doesn't support 1280x1024 resolution (Out of adapter memory). I think you can first detect GL_ATI_meminfo in glGetString(GL_EXTENSIONS); if GL_ATI_meminfo exists, then you can use glGetIntegerv(GL_VBO_FREE_MEMORY_ATI, param) to get the current free video memory, you can see more info at: http://www.opengl.org/registry/specs/ATI/meminfo.txt if GL_ATI_meminfo doesn't exist, you can fall back to the original method. Please tell me if you have any questions. Regards, Sunny, Sun

2 2

Re: gdiplus: Implement GdipIsVisiblePoint
by Nikolay Sivov 14 Aug '09

14 Aug '09

Andrew Eikum wrote: > --- > dlls/gdiplus/graphics.c | 19 ++++- > dlls/gdiplus/tests/graphics.c | 162 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 177 insertions(+), 4 deletions(-) Could you do it in opposite direction - implement "I" version on top of GdipIsVisiblePoint? This is how the rest of similar cases already works.

2 1

CPPcheck weekly run off thursdays GIT tree
by chris ahrendt 14 Aug '09

14 Aug '09

[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/rpcrt4/tests/server.c:1189]: (all) Array index out of bounds [../wine-git/dlls/wined3d/arb_program_shader.c:820]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:821]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:966]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:977]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:988]: (all) Buffer overrun [../wine-git/server/handle.c:201]: (error) Memory leak: new_entries [../wine-git/tools/fnt2bdf.c:656]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:303]: (error) Memory leak: file_lens [../wine-git/tools/makedep.c:953]: (error) Resource leak: file [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winedump/pe.c:1549]: (all) Memory leak: map Chris

3 2

Re: [transl 7/8] Add pedantic possibilities to the resource page
by Aurimas Fišeras 14 Aug '09

14 Aug '09

On 2009.08.14 17:28, Paul Vriens wrote: > Hi, > > Again, passing pedantic in the URL gets a different behavior. In > pedantic mode there will always be a direct comparison with English(US) > when there are warnings. > > Changelog > Add pedantic possibilities to the resource page > You forgot the patch

1 0

Re: dbghelp: Fixed arena allocation in pool_alloc.
by Jacek Caban 14 Aug '09

14 Aug '09

> dbghelp: Fixed arena allocation in pool_alloc. Well, 'fixed' might be a wrong word, but this patch makes it more intuitive. Jacek

1 0

Re: [11/18] windowscodecs: add test for pixel format conversion
by Alexandre Julliard 14 Aug '09

14 Aug '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > +START_TEST(testsrc) > +{ > + CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); > + > + test_conversion(&testdata_32bppBGRA, &testdata_32bppBGR, "BGRA -> BGR", 0); > + test_conversion(&testdata_32bppBGR, &testdata_32bppBGRA, "BGR -> BGRA", 0); > + test_conversion(&testdata_32bppBGRA, &testdata_32bppBGRA, "BGRA -> BGRA", 0); > + test_invalid_conversion(); > + test_default_converter(); > + > + CoUninitialize(); > +} Much better this way, thanks. You should probably rename the test file to converter.c or something like that though. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Alexandre Julliard : libwine: Ignore libraries that are of the wrong 32/ 64 class.
by Ken Thomases 14 Aug '09

14 Aug '09

Hi Alexandre, It seems this would fail to ignore a fat Mach-O library that doesn't include the right 32/64 class. For example, a fat i386/ppc library when running 64-bit. A fat library starts with the struct fat_header defined in /usr/ include/mach-o/fat.h, followed by a number of struct fat_arch-es. Its magic is 0xcafebabe in big-endian order. This would also fail to ignore a PowerPC-only library because the magic would be big-endian, but I doubt we care about that. -Ken On Aug 11, 2009, at 10:47 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 99538272d5b4ffc852f950dd3447a7072d6316ff > URL: http://source.winehq.org/git/wine.git/?a=commit;h=99538272d5b4ffc852f950dd3… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Aug 11 17:29:07 2009 +0200 > > libwine: Ignore libraries that are of the wrong 32/64 class. > > --- > > libs/wine/loader.c | 46 +++++++++++++++++++++++++++++++++++++++++++ > +-- > 1 files changed, 44 insertions(+), 2 deletions(-) > > diff --git a/libs/wine/loader.c b/libs/wine/loader.c > index d10a6e0..37c603e 100644 > --- a/libs/wine/loader.c > +++ b/libs/wine/loader.c > @@ -147,12 +147,54 @@ static void build_dll_path(void) > } > } > > +/* check if the library is the correct architecture */ > +/* only returns false for a valid library of the wrong arch */ > +static int check_library_arch( int fd ) > +{ > +#ifdef __APPLE__ > + struct /* Mach-O header */ > + { > + unsigned int magic; > + unsigned int cputype; > + } header; > + > + if (read( fd, &header, sizeof(header) ) != sizeof(header)) > return 1; > + if (header.magic != 0xfeedface) return 1; > + if (sizeof(void *) == sizeof(int)) return !(header.cputype >> > 24); > + else return (header.cputype >> 24) == 1; /* CPU_ARCH_ABI64 */ > +#else > + struct /* ELF header */ > + { > + unsigned char magic[4]; > + unsigned char class; > + unsigned char data; > + unsigned char version; > + } header; > + > + if (read( fd, &header, sizeof(header) ) != sizeof(header)) > return 1; > + if (memcmp( header.magic, "\177ELF", 4 )) return 1; > + if (header.version != 1 /* EV_CURRENT */) return 1; > +#ifdef WORDS_BIGENDIAN > + if (header.data != 2 /* ELFDATA2MSB */) return 1; > +#else > + if (header.data != 1 /* ELFDATA2LSB */) return 1; > +#endif > + if (sizeof(void *) == sizeof(int)) return header.class == 1; /* > ELFCLASS32 */ > + else return header.class == 2; /* ELFCLASS64 */ > +#endif > +} > + > /* check if a given file can be opened */ > static inline int file_exists( const char *name ) > { > + int ret = 0; > int fd = open( name, O_RDONLY ); > - if (fd != -1) close( fd ); > - return (fd != -1); > + if (fd != -1) > + { > + ret = check_library_arch( fd ); > + close( fd ); > + } > + return ret; > } > > static inline char *prepend( char *buffer, const char *str, size_t > len ) > > >

2 1

Re: msxml3: Support loading windows file path under wine (resend)
by Alexandre Julliard 14 Aug '09

14 Aug '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static int wineXmlMatchCallback (char const * filename) > +{ > + static const WCHAR sColon[] = {':',0}; > + BSTR sFilename = bstr_from_xmlChar( (xmlChar*)filename); > + int nRet = 0; > + > + TRACE("%s\n", debugstr_w(sFilename)); > + > + /* > + * We will deal with loading XML files from the file system > + * We only care about files that linux cannot find. > + * e.g. C:,D: etc > + */ > + if(isalphaW(sFilename[0]) && sFilename[1] == sColon[0]) > + nRet = 1; > + > + SysFreeString(sFilename); It doesn't make sense to convert the string to Unicode just to check for a drive letter. Also the sColon string is clearly useless. -- Alexandre Julliard julliard(a)winehq.org

1 0