August 2009 - Wine-devel - list.winehq.org

Re: includes: Make vmrender.idl C++ friendly
by Maarten Lankhorst 11 Aug '09

11 Aug '09

Hi Austin, Austin English schreef: > On Tue, Aug 11, 2009 at 12:56 PM, Maarten > Lankhorst<m.b.lankhorst(a)gmail.com> wrote: > >> C++ doesn't like: GUID GUID; which is valid in C, so replace with struct >> _GUID GUID; >> > > > FYI, you're e-mail is messed up in the patch: > From: Maarten Lankhorst <mlankhorst(a)patser.(none)> > > I think AJ's scripts may prefer the patch e-mail to the sender's e-mail. > afaict it has never been a problem in the past, aj has always used sender for me Cheers, Maarten

1 0

convert a testcase into a unittest (bug #19666)
by Stefan Leichter 11 Aug '09

11 Aug '09

Hi, i got a testcase that exhibits bug #19666. Now i'm looking for a way to integrate the testcase into the testsuite. The testcase needs a program (currently c:\ShellExecuteClient.exe) that must be called without parameters. Therefore i can not use eg. shell32_test.exe itself. I'm searching for a way to build/bundle ShellExecuteClient.exe with shell32_test.exe. Can ShellExecuteClient.exe be integrated as wine-lib binary in the testsuite? Please give me comments, suggestions, solutions Bye Stefan

1 0

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/11 Owen Rudge <orudge(a)codeweavers.com>: > +static const IImageListVtbl ImageListImpl_Vtbl = { > + ImageListImpl_QueryInterface, > + ImageListImpl_AddRef, > + ImageListImpl_Release > +}; You can't do that, you need to at least implement stubs for the other methods.

2 2

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)
by Eric Pouech 11 Aug '09

11 Aug '09

Juan Lang a écrit : > Uses %u rather than %d, based on Henri's feedback. > --Juan > > ------------------------------------------------------------------------ > > Hi Juan don't you miss a break statement (or a more likely a return 0) at the end of the block ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: ws2_32(8/8): Implement getsockopt(SOL_IRLMP, IRLMP_ENUMDEVICES)
by Henri Verbeet 11 Aug '09

11 Aug '09

Isn't getsockopt() supposed to write the size of the data actually written to optlen?

2 1

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/11 Juan Lang <juan.lang(a)gmail.com>: > + sprintf( win->irdaServiceName, "LSAP-SEL%d", uin->sir_lsap_sel ); I have no idea if this can even be an issue in practice, but "uin->sir_lsap_sel" is unsigned.

2 1

Re: Assigning a bug to myself
by James Mckenzie 11 Aug '09

11 Aug '09

>--- On Mon, 10/8/09, Ben Klein <shacklein(a)gmail.com> wrote: > >> 2009/8/10 Alexandros Dermenakis >> <alderfc7(a)gmail.com>: >> > Hi, >> > >> > I 'm now ready to start debugging wine so I'd like to >> try solving a bug. Do I >> > need to assign a bug to myself or I just start solving >> it? If I have to assign >> > it how can I do that? >> > >> > I created a bug zilla account >> >> You don't need to assign bugs to yourself. I believe this >> was covered >> in another thread. Once you have a patch to fix a bug, send >> it to >> wine-patches, following the "submitting patches" guide. >> Then, if it is >> accepted and committed, the appropriate bug can be marked >> "FIXED". > >To avoid duplication of effort (though quite unlikely among the wine community), it is probably appropriate to >stick a comment on the specific bug to that effect and put yourself to the CC:. This way, others know you >are working on it, and you get to read about others' insight to the problem if they choose to write to >comment. (this has essentially the same effect as having the bug formally assigned to oneself, without the >management/administration overhead). It is a good idea to get the bug assigned to one's self and not to rely on the use of comments. Of course, if you abandon the bug because you cannot complete the fix, it is a good idea to get the bug unassigned and leave a comment as to the status of the bug fix. > >Most bugs' status are eventually and officially closed by AJ anyway :-). ALL Wine bugs are closed by AJ after confirming that the fix is in a specific release of Wine. He has reserved this to himself. Wine Web Site bugs are closed by the person who incorporated fixes into the code for the web site. James McKenzie

1 0

Help with test
by Alistair Leslie-Hughes 11 Aug '09

11 Aug '09

Hi, I been trying to fix this bug, and have patch that works. http://bugs.winehq.org/show_bug.cgi?id=11325 The only thing is that the test case I've written fails under wine but work under Windows XP. The issue is, when using a stylesheet we can do something like <xsl:apply-templates select='document("C:\temp\ss.xsl"/bottle/etc)' />. which attempts to load a document and extracts information from it. In windows this works fine, but the linux libxsl library doesn't know about 'c:\' syntax. To get around this issue we overload the input for libxml, and handle windows file paths. (patch attached) The problem is I've attempted to reproduce this scenario as a test, but have missed something. Can someone have a look to see what I might of overlooked? Best Regards Alistair Leslie-Hughes

1 0

Re: hhctrl.ocx: Handle NULL param
by Paul Chitescu 11 Aug '09

11 Aug '09

This is a quite ugly patch, adds unnecessary wstring copying. Why not: wsprintfW(buf, url_format, full_path, (index && index[0] == '/') ? empty : slash, index);

1 1

Re: removes 1024 mb from geforce gtx 260 and adds 896mb instead directx patch
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/10 James Carthew <jcarthew(a)gmail.com>: > From 3fc1812db11e6468b9774f597993c292f36873b7 Mon Sep 17 00:00:00 2001 > From: Your Name <you(a)email.com> > Date: Mon, 10 Aug 2009 12:11:31 +0930 > Subject: [PATCH] removes 1024mb from geforce 260 gtx and adds 896mb instead to directx.c > to match real geforce 260gtx cards. Please use a proper name, e-mail address and subject.

1 0