September 2009 - Wine-devel

meaning of "Hardware" field in bugzilla?
by Dan Kegel 13 Dec '09

13 Dec '09

Does "mac" mean "powerpc mac only"? I rather thought it meant "apple macintosh", regardless of cpu. I ask because Austin has just gone through and changed lots of "mac" bugs to "pc" even though the bugs were on Intel macs, which just seems wrong.

8 8

Towards leveraging app build and unit tests as a way to test wine
by Dan Kegel 18 Oct '09

18 Oct '09

Wine is far enough along that it ought to be able to build and run unit test suites from apps like Inkscape, Firefox, and OpenOffice, so I'm trying to write scripts that download and build various apps unattended, and eventually run their own test suites. The scripts are written to run equally well on Windows and Wine. This is hard to do without something like Cygwin or Autohotkey; I'm using Cygwin for my scripts out of personal preference. I already did a build script for Inkscape using mingw; http://kegel.com/wine/inkscape-download-and-build.sh.txt Now I'm tackling Firefox. So far the script installs Visual C++ 2005 Express and the 2003 platform SDK; see http://kegel.com/wine/vc2005x.sh.txt Next step: grabbing firefox source and building. I'm also filing bugs as I go; 19673 Microsoft Platform Installer 2003 fails to install 19668 cmd /c doesn't wait for result before exiting? 19636 Vista SDK installer fails in "Microsoft VC Redist 2008" subinstaller 19615 Can't compile Inkscape with mingw on wine: fd leak? 19581 Visual Studio 2005: "cl : Command line error D8022 : cannot open 'foo.rsp' "; foo.rsp was created with FILE_ATTRIBUTE_TEMPORARY 19502 Visual Studio 2005 SP1 install seems to fail While one doesn't really need to build the apps under Wine to run their test suites, it's a pain to have to compile them on one system and ship them over to another. And supporting building might have a nice benefit: if it's easy to develop for Windows on Wine, more Windows developers might bother to test their apps on Wine. So I think it's worth the extra effort. - Dan

5 16

search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by Dan Kegel 18 Oct '09

18 Oct '09

See http://bugs.winehq.org/show_bug.cgi?id=14980 Essentially, to run Office 2007, you have to set an override for riched20. Since Office installs a new, spiffier version of riched20 in its own private directory, and expects to find it there, isn't it a bug that we don't let it have it? Sounds like it's time to write a conformance test... sure would be nice if that override wasn't needed.

9 26

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit
by Henri Verbeet 10 Oct '09

10 Oct '09

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > +typedef struct tagDPSP_MSG_HEADER > +{ > + DWORD size; /* size & 0x000FFFFF, token & 0xFFF00000 */ > + SOCKADDR_IN SockAddr; > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER; > + It seems you're sending this over the network, so you should make sure it's correctly packed, and take the byte order into account.

3 11

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()
by Juan Lang 08 Oct '09

08 Oct '09

Hi Dan, > This is a bit different from the code I posted earlier; > following Samba's example, it combines the > fd and filename cases into a single function, Since you don't actually use the fd in your patch, I think it's preferred style not to include it for now. Also, +void DIR_set_attributes(int fd, DWORD attributes) +{ + /* Unimplemented. Wine does not yet store win32 file attributes. */ (snip) + + /* Try to save attributes. We don't care too much if it doesn't work. */ + DIR_set_attributes(fd, info->FileAttributes); Adding a no-op part of the patch is a bit ugly. Removing it allows you to focus on one thing in this patch, rewriting querying the file attributes. You re-add setting them later. (Thanks for working on this, by the way.) --Juan

2 4

Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
by Johan Gill 08 Oct '09

08 Oct '09

On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill <johan.gill(a)gmail.com> wrote: > This patch fixes bug 17215. Since the patch was seemingly dropped, I made > some test improvements and resubmit it. > > The tests pass on Windows XP, and of course Wine. > > Suggested changelog: > In DirectDraw fullscreen mode, make sure the fullscreen window is resized > when the display mode changes > > Johan Gill > > Since I heard nothing on this, I make a request here /Johan Gill

2 5

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing
by Dmitry Timoshkov 01 Oct '09

01 Oct '09

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hicon); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETICON, (WPARAM)hicon, 0); > + todo_wine ok_sequence(WmSetIconErrStaticSeq, "STM_SETICON on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ENHMETAFILE, (LPARAM)hemf); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); You should use SendMessageA instead of SendMessageW to make the test run under Win9x as well. Testing the return value of SendMessage would be also helpful. -- Dmitry.

3 3

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime
by Paul Vriens 01 Oct '09

01 Oct '09

On 09/29/2009 12:36 PM, Nikolay Sivov wrote: > Changelog: > - be sure we have a single view calendar for hittesting > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1002: Test failed: Expected 10000, got 10002 I fixed it on my NT4 box by checking the point more to the left (see attached). I somehow doubt it's the correct fix though. Aren't these tests with more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? -- Cheers, Paul.

2 5

Modifying Subsystem in Winelib executables
by Greg Geldorp 30 Sep '09

30 Sep '09

To fix one of the tests (shell32:shlexec) I'd like to copy the test executable and change the Subsystem type from IMAGE_SUBSYSTEM_WINDOWS_CUI (console app) to IMAGE_SUBSYSTEM_WINDOWS_GUI (GUI app) in the copy. Piece of cake for PE files, get the IMAGE_DOS_HEADER, follow it to the IMAGE_NT_HEADERS and just patch the OptionalHeaders.Subsystem field. My limited understanding of the structure of Winelib executables makes doing the same for testing on Wine quite a bit harder. I assume there's still a IMAGE_NT_HEADERS structure in there somewhere and with some research I'll probably be able to locate it in Linux ELF Winelib executables. What I'm wondering about is how big the can of worms I'm trying to open is? Is the encapsulation of PE headers in "native" executables the same for all OSes supported by Wine? Is changing a PE header field in (a copy of) a Winelib executable doomed to fail or is it a walk in the park? Ge.

4 5

firefox build success on visual c++ 2005 on wine!
by Dan Kegel 30 Sep '09

30 Sep '09

Moo hoo ha ha ha! Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, the firefox build procedure runs all the way through to the end (at least in release mode; debug builds still fail). Here's a log showing the whole build: http://kegel.com/wine/log.txt And, if AJ likes my hidden attribute patch, 'cc' will start working on Cygwin, making it easier to just try building random Unix apps on cygwin on wine. We're getting closer and closer to a world in which we can use random application http://wiki.winehq.org/UnitTestSuites as regression tests for wine. (It'd be cool if we could get buildbot working *on wine*; see http://bugs.winehq.org/show_bug.cgi?id=13844 Then we could make wine-powered buildbots for a bunch of open source projects without having to fiddle around porting their buildbot configs to invoke wine. - Dan

2 2