September 2009 - Wine-devel

Re: ddraw: set dwBackBufferCount=0 in CreateSurface for backbuffer
by Stefan Dösinger 29 Sep '09

29 Sep '09

Am 29.09.2009 um 15:09 schrieb Markus Stockhausen: > Sorry for the incomplete topic of my first mail. > > <patch.diff> The patch looks ok to me

1 0

Re: wininet(1/3): Only initialize SSL_CTX once
by Hans Leidekker 29 Sep '09

29 Sep '09

Hi Juan, > These patches collectively fix bug 18364, which was a crash in OpenSSL > in a multithreaded app (utorrent.exe.) The bug reporter sees long delays between torrents starting up after applying these patches, which makes we wonder if the ssl lock effectively serializes secure https requests? Would patch 1 and 3 not be sufficient to fix the utorrent crash? -Hans

2 1

Re: set caps.dwBackBufferCount=0 for backbuffer surface
by Paul Vriens 29 Sep '09

29 Sep '09

On 09/29/2009 03:01 PM, Markus Stockhausen wrote: > > > ------------------------------------------------------------------------ > > Hi Markus, Please stick to the coding style of the file, or at least the surrounding code (implementation and test). -- Cheers, Paul.

2 2

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)
by Nikolay Sivov 29 Sep '09

29 Sep '09

Could you please add a test for that?

2 1

Re: wininet: Handle finding ftp files in subdirectories and using wildcards.
by Detlef Riekenberg 29 Sep '09

29 Sep '09

On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: > + if (lpszSearchPath) > + HeapFree(GetProcessHeap(), 0, lpszSearchPath); > + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef

1 0

Re: ole32/tests: guard ReleaseStgMedium with SUCCEEDED
by Alexandre Julliard 29 Sep '09

29 Sep '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > @@ -1401,7 +1405,7 @@ static void test_getdatahere(void) > hr = IDataObject_GetDataHere(get, &fmt, &med); > ok(hr == S_OK, "got %08x\n", hr); > ok(med.tymed == TYMED_HGLOBAL, "got %x\n", med.tymed); > - ReleaseStgMedium(&med); > + if(SUCCEEDED(hr)) ReleaseStgMedium(&med); I don't think that's correct for the GetDataHere case, it's allocated by the caller. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server(4/5): Setting a process's affinity sets all of its threads' affinities too
by Alexandre Julliard 29 Sep '09

29 Sep '09

Juan Lang <juan.lang(a)gmail.com> writes: > +static void set_process_affinity( struct process *process, affinity_t affinity ) > +{ > + struct thread *thread; > + > + process->affinity = affinity; > + > + suspend_process( process ); > + LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread, proc_entry ) > + { > + set_thread_affinity( thread, affinity ); > + } > + resume_process( process ); Why are you suspending the process? -- Alexandre Julliard julliard(a)winehq.org

1 0

help with dwBackBufferCount in backbuffer surfaces needed
by Markus Stockhausen 29 Sep '09

29 Sep '09

Hi, currently I'm investigating bug 1660 and hopefully I found the reason for the misbehaviour. The only problem is, that I do not know what results I have to expect in windows. So it would be very helpful if someone can execute the attached testcase in a native environment so that I can fix the error condition and send in the final patch. The idea is that backbuffer surfaces have dwBackBufferCount=0 in Windows but on Wine they get the same count as the primary surface. The test will fail in Windows and Wine to get the results in both cases. The result will show like this: dsurface.c:1264: Test failed: backbuffer surface has dwBackBufferCount==2 Thanks for your help in advance. Markus

4 4

Re: [PATCH 10/10] add tests for SHOpenRegStream2A and SHCreateMemStream
by Alexandre Julliard 29 Sep '09

29 Sep '09

Peter Oberndorfer <kumbayo84(a)arcor.de> writes: > +#define test_streamsize(stream, size) \ > +{ \ > + STATSTG stat; \ > + HRESULT result; \ > + result = IStream_Stat(stream, &stat, STATFLAG_NONAME); \ > + ok(result == S_OK, "IStream::Stat failed %08x\n", result); \ > + ok(stat.cbSize.QuadPart == size, "Stat size wrong\n"); \ > +} > + > +#define test_value_type(name, wantedtype) \ > +{ \ > + LONG retval; \ > + DWORD type; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, &type, NULL, NULL); \ > + ok(retval == ERROR_SUCCESS, "RegQueryValueExA should succeed, error %d\n", retval); \ > + ok(type == wantedtype, "type of key wrong. wanted %d, got %d\n", wantedtype, type); \ > +} > + > +#define test_value_not_exist(name) \ > +{ \ > + LONG retval; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, NULL, NULL, NULL); \ > + ok(retval == ERROR_FILE_NOT_FOUND, "RegQueryValueExA returned wrong error %d\n", retval); \ > +} > + > +/* older versions (Win98) seem broken, they do not delete the key on close when it is empty */ > +#define test_value_type_broken(name, wantedtype) \ > +{ \ > + LONG retval; \ > + DWORD type; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, &type, NULL, NULL); \ > + ok(retval == ERROR_SUCCESS, "RegQueryValueExA should succeed, error %d\n", retval); \ > + ok(type == wantedtype || broken(type != wantedtype), "type of key wrong. wanted %d, got %d\n", wantedtype, type); \ > +} > + > +#define test_value_not_exist_broken(name) \ > +{ \ > + LONG retval; \ > + retval = RegQueryValueExA(hBaseKey, name, NULL, NULL, NULL, NULL); \ > + ok((retval == ERROR_FILE_NOT_FOUND) || broken(retval == ERROR_SUCCESS), \ > + "RegQueryValueExA returned wrong error %d\n", retval); \ > +} Please avoid hiding the code inside macros. When you have only a couple of lines just spell things out explicitly. For larger things write an inline function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 02/15] comctl32/monthcal: Make tests not depend from each other
by Paul Vriens 29 Sep '09

29 Sep '09

On 09/27/2009 07:51 PM, Nikolay Sivov wrote: > Changelog: > - Inependent tests are always better and more scalable. > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one seems (there were more for monthcal.c) to have introduced 2 test failures on a lot of boxes. The only reason I see (from the logs on test.winehq.org) is that the failing boxes don't run the English locale. Any idea? -- Cheers, Paul.

2 1