September 2009 - Wine-devel

Re: [2/5] WineD3D: Start replacing dxVersion with create flags
by Stefan Dösinger 30 Sep '09

30 Sep '09

Am 30.09.2009 um 16:22 schrieb Henri Verbeet: >> I prefer that all d3d version specific behaviors in wined3d(ie, >> those that >> can't be handled by the client lib alone) are controlled by one >> wined3d >> parameter. I don't feel strongly about this though. I could as well >> make >> them a parameter of CreateVertexBuffer if you prefer this. >> > I think it might make more sense there, although I suppose there's > something to say for keeping the differences centralised as well. Are the patches ok with you in that case? Otherwise I'll just fix bug 19365 with the old dxVersion hack and implement whatever properly designed setup you prefer the next time I have a few hours to kill (read: On my 16 hour flight to the google mentor summit later next month) > Is there any reason you're not sending these mails to wine-devel as > well? Apparently because the "reply" button in Apple Mail doesn't do the same as the "reply" button in kmail. Apparently because there's no "reply to mailing list" either.

2 2

Re: [1/2] richedit: Added test to show that handle to parent is cached.
by Paul Vriens 30 Sep '09

30 Sep '09

On 09/30/2009 03:56 PM, Dylan Smith wrote: > --- > dlls/riched20/tests/editor.c | 26 ++++++++++++++++++++++++++ > 1 files changed, 26 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Dylan, Could you change SetWindowLongPtrW to the A-variant to cope with 9x/Me? -- Cheers, Paul.

1 0

Re: ws2_32: Ignore EINTR poll result code in WS_select
by Alexandre Julliard 30 Sep '09

30 Sep '09

Dmitriy Anisimkov <anisimkov(a)ada-ru.org> writes: > Changelog: > - Ignore EINTR result code from poll call in WS_select. Your timeout computation is still wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: sti [2/2]: add stubs for the IStillImageW interface
by Alexandre Julliard 30 Sep '09

30 Sep '09

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static const struct IUnknownVtbl internal_unk_vtbl = > +{ > + Internal_QueryInterface, > + Internal_AddRef, > + Internal_Release > +}; > + > +static const struct IStillImageWVtbl stillimagew_vtbl = > +{ > + stillimagew_QueryInterface, > + stillimagew_AddRef, > + stillimagew_Release, > + stillimagew_Initialize, > + stillimagew_GetDeviceList, > + stillimagew_GetDeviceInfo, > + stillimagew_CreateDevice, > + stillimagew_GetDeviceValue, > + stillimagew_SetDeviceValue, > + stillimagew_GetSTILaunchInformation, > + stillimagew_RegisterLaunchApplication, > + stillimagew_UnregisterLaunchApplication, > + stillimagew_EnableHwNotifications, > + stillimagew_GetHwNotificationState, > + stillimagew_RefreshDeviceBus, > + stillimagew_LaunchApplicationForDevice, > + stillimagew_SetupDeviceParameters, > + stillimagew_WriteToErrorLog > +}; You don't really need a separate vtbl for IUnknown. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wininet(2/7): Separate loading libssl from loading libcrypto
by Alexandre Julliard 30 Sep '09

30 Sep '09

Juan Lang <juan.lang(a)gmail.com> writes: > This is a step toward relieving lock serialization, as the two > libraries can be loaded independently. (There is no lock yet, though, > and this still crashes in utorrent. Fixes in the next two patches.) There's no reason to invent such complicated locking mechanisms. Just put the whole thing inside a critical section and be done with it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/5] WineD3D: Add a create flag for addref in GetPrivateData
by Henri Verbeet 30 Sep '09

30 Sep '09

2009/9/30 Stefan Dösinger <stefan(a)codeweavers.com>: > This is hard to implement in the client lib - it would require to remove the > AddRef from wined3d altogether, and pass the priv data flags to the client, > and then AddRef in d3d8, d3d9 and dxgi/d3d10. I can't use a Release in ddraw > because we're calling application code here which might break if the app's > AddRef() implementation is broken. Handling the AddRef in d3d8/9/10 is a lot > of work because those libs don't have any IDirect3D*Resource base class that > could do this in a central place. I'm not sure why you'd need an entire baseclass, an utility function (which is how it's done in wined3d!) should do just fine. > +const UINT WINED3DCREATE_GET_PRIV_DATA_NO_ADDREFF = 0x00000004; There should only be a single 'F' in ADDREF.

1 0

Re: [2/5] WineD3D: Start replacing dxVersion with create flags
by Henri Verbeet 30 Sep '09

30 Sep '09

2009/9/30 Stefan Dösinger <stefan(a)codeweavers.com>: > Is there a real reason this (and the flag from the next patch) has to be set on the wined3d object? If there is, I think WINED3D_CREATE_BUFFER_NO_CONVERSION and WINED3D_CREATE_BUFFER_STATIC_FORMAT would be more appropriate names.

1 0

Re: [comctl32/tests] Fix a test failure on several platforms
by Paul Vriens 30 Sep '09

30 Sep '09

On 09/30/2009 02:21 PM, Paul Vriens wrote: > Hi, > > Positioning the point test a bit to the left makes this test succeed on > more boxes. > > (Maybe we should add MCHT_TITLEYEAR to the possible outcomes but I'm not > too sure about that). > > Changelog > Fix a test failure on several platforms > Just checked some other test failures on an XP. This one has more issues but also shows MCHT_TITLEMONTH for the test changed in this patch. Now I'm pretty convinced the fix is not correct, but I stand corrected. -- Cheers, Paul.

1 0

Compile error on current Git
by Paul Vriens 30 Sep '09

30 Sep '09

Hi, Anyone else seeing this: make[2]: Entering directory `/wine/wine-git/dlls/system.drv16' ccache gcc -m32 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Wcast-qual -Wlogical-op -o system.o system.c ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./system.drv16.spec system.o -Wb,--subsystem,win16 -o system.drv16.so -lkernel32 ../../libs/port/libwine_port.a system.o: In function `call_timer_proc16': system.c:(.text+0x54a): undefined reference to `NtCurrentTeb' collect2: ld returned 1 exit status winegcc: ccache failed make[2]: *** [system.drv16.so] Error 2 make[2]: Leaving directory `/wine/wine-git/dlls/system.drv16' make[1]: *** [system.drv16] Error 2 (Fedora 11, gcc 4.4.1) -- Cheers, Paul.

2 2

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER
by Paul Vriens 30 Sep '09

30 Sep '09

On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: > --- > dlls/ws2_32/tests/sock.c | 46 +++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 37 insertions(+), 9 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Mike, This one has introduced a test failure on Win98 and WinMe. Could you have a look? Let me know if you want me to run extra tests on these boxes. -- Cheers, Paul.

2 2