October 2010 - Wine-devel - list.winehq.org

Re: (6th try) winhlp32: Added Hebrew translation
by Paul Vriens 05 Oct '10

05 Oct '10

Hi Yaron, I'm see this one is still not applied. Maybe because there are still some small issues? See below. On 10/03/2010 11:12 PM, Yaron Shahrabani wrote: > +LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT This line should go, it's redundant (it's already stated at the beginning). This line was present in the English resources because there is a difference between SUBLANG_DEFAULT and SUBLANG_NEUTRAL in that resource file. For example 'colors' vs. 'colours'. > + > +IDD_INDEX DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU | WS_EX_LAYOUTRTL You should move the WS_EX_LAYOUTRTL to an EXSTYLE like the IDD_SEARCH_DIALOG below. Adding it to the STYLE has no effect. > +FONT 8, "MS Shell Dlg" > +CAPTION "מפתח" > +{ > + LISTBOX IDC_INDEXLIST, 10, 10, 180, 150, LBS_NOINTEGRALHEIGHT | WS_VSCROLL | WS_BORDER > +} > + > +IDD_SEARCH DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" -- Cheers, Paul.

1 0

Re: user32/tests: Test FindWindowEx for empty window title (try 2)
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5829 Your paranoid android. === W98SE (32 bit win) === win.c:2970: Test failed: message 000f available win.c:2982: Test failed: message 000f available win.c:2991: Test failed: message 000f available win.c:3000: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5828 Your paranoid android. === W98SE (32 bit url) === url.c:746: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 46

1 0

winmm/tests: Don't test the non-default Midi devices if the 'PreferredOnly' Windows setting is set.
by Joerg-Cyril.Hoehle＠t-systems.com 05 Oct '10

05 Oct '10

Hi, a few month ago when the discussion about "PreferredOnly" registry setting came up, I queried Google and found that many more users use this setting than one may believe - i.e. it is not exotic. Therefore, I don't think it's that great an idea to reduce the number of devices that the tests stress using that method: we'll get less feedback from a number of real machines. OTOH, I have no solution to the vmware MIDI trouble on Francois' machines. Regards, Jörg Höhle

1 0

Re: msi: Put the uninstall key for 32-bit packages under Wow6432Node on 64-bit.
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5824 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10427: Test failed: key not created

2 1

Re: [2/3] kernel32/process: Implement GetLogicalProcessorInformation using NtQuerySystemInformation
by Vitaliy Margolen 05 Oct '10

05 Oct '10

On 10/05/2010 04:46 AM, Rudolf Mayerhofer wrote: > --- > dlls/kernel32/process.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > Please exchange patches 2 and 3. And everywhere in your patches, please stick to _THE SAME_ formatting as the rest of the file you editing. Examples: > + if (status != STATUS_SUCCESS) > + { > + if( status == STATUS_INFO_LENGTH_MISMATCH ) Here you adding 2 differently formatted if () statements. > +static ULONG_PTR sysfs_cpu_topology_getmap(int cpu, const char *type) > +{ > + char buf[256]; > + FILE *fd; > + ULONG_PTR result; > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/topology/%s",cpu,type); Please add empty line between variable declarations and the rest of the code. All commas should always be followed by a space. > + fd = fopen(buf,"r"); > + if(fscanf(fd,"%lx",&result) != 1) You are not checking if fopen() succeeded. > +static int sysfs_cpucache_getint(int cpu, int cache, const char *type) > +{ > + }else{ > + val = -1; > + } > + fclose(fd); > + return val; > +} > ... > + BYTE level = sysfs_cpucache_getint(cpucount,cachecount,"level"); Don't mix signed and unsigned integers. Especially that you return -1 in case of error. In that entire file curly braces go on a separate line. Vitaliy.

1 0

[1/2] user32: fix FindWindowEx behavior if window name is an empty charachter
by Louis Lenders 05 Oct '10

05 Oct '10

>It would be better to avoid duplicate GetWindowTextW() calls. I thought a long time how to fix this, but i couldn't find another way than this one, because we need to find out whether or not the window title is empty, and afaik we can only do that by calling GetWindowText (again). If you have another way that i overlooked, please let me know Regards Louis

3 2

Re: winex11: Add support for animated cursors in X11 driver (try 5).
by Alexandre Julliard 05 Oct '10

05 Oct '10

Erich Hoover <ehoover(a)mines.edu> writes: > + imgs[nFrames++] = image; > + if (!(imgstmp = HeapReAlloc( GetProcessHeap(), 0, imgs, nFrames*sizeof(XcursorImage*) ))) goto cleanup; > + imgs = imgstmp; This is still broken. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ImmReleaseContext() function implementation
by Aric Stewart 05 Oct '10

05 Oct '10

I do not believe this is correct. You would be destroying the context every time it is released and that is clearly not what we want to be doing ass ImmGetContext and ImmReleaseContext as a pair are called over and over again in a typical application. -aric On 10/4/10 1:25 PM, Mikhail Gorbunov wrote: > This patch implements (with a basic sanity check) a behaviour of > ImmReleaseContext() > function as described in msdn and in the way ImmGetContext() has already been > impleneted. > > From 56f78bcd9584350b456ca0b0514a357b7ee8cdfd Mon Sep 17 00:00:00 2001 > From: Mikhail Gorbunov<mikhail.gorbunov(a)gmail.com> > Date: Mon, 4 Oct 2010 21:47:17 +0400 > Subject: [PATCH] ImmReleaseContext() function implementation > > --- > dlls/imm32/imm.c | 24 ++++++++++++++++++------ > 1 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 28f482c..87b4c14 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -2009,13 +2009,25 @@ BOOL WINAPI ImmRegisterWordW( > */ > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { > - static int shown = 0; > + TRACE("(%p, %p)\n", hWnd, hIMC); > > - if (!shown) { > - FIXME("(%p, %p): stub\n", hWnd, hIMC); > - shown = 1; > - } > - return TRUE; > + if (hIMC) > + { > + InputContextData *data = hIMC; > + > + if (data->IMC.hWnd != hWnd) > + { > + FIXME("(%p, %p): data->IMC.hWnd = %p :: err\n", > + hWnd, hIMC, data->IMC.hWnd); > + return TRUE; > + } > + else > + { > + return ImmDestroyContext(hIMC); > + } > + } > + else > + return TRUE; > } > > /***********************************************************************

1 0

Re: [PATCH 1/6] urlmon: Report error on synchronous bindings that don't have a cache file and are not read in callback.
by Alexandre Julliard 05 Oct '10

05 Oct '10

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) This breaks the gameux tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1