October 2010 - Wine-devel - list.winehq.org

Re: oleaut32/tests: added tests for negative fractional variant dates.
by Jeremy Drake 02 Oct '10

02 Oct '10

Oops, those empty parens () were intended to cite the URL for the article. Unfortunately, I can't seem to find it now. However, I found an MSDN page that describes the behavior I am testing here: http://msdn.microsoft.com/en-us/library/system.datetime.fromoadate.aspx This is actually documentation of a .NET method, but see the Remarks section for a description of the format. On Fri, 1 Oct 2010, Jeremy Drake wrote: > I recently read an article () mentioning some of the oddities that show up > in negative variant dates with non-zero (midnight) times, and I noticed > that wine had no test coverage for these cases. Until now. > > > > --- > dlls/oleaut32/tests/vartest.c | 32 +++++++++++++++++++++++--------- > 1 files changed, 23 insertions(+), 9 deletions(-) -- Egotist, n.: A person of low taste, more interested in himself than me. -- Ambrose Bierce, "The Devil's Dictionary"

1 0

Re: wininet(4/5): Support querying the cipher strength of an SSL connection
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5670 Your paranoid android. === W98SE (32 bit http) === No test summary line found === W2K8SE (32 bit http) === http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:771: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:774: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:775: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:776: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:777: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:780: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:899: Test failed: failed to read any of the document http.c:2893: Test failed: InternetQueryOption failed: 12018 http.c:2894: Test failed: expected INTERNET_HANDLE_TYPE_HTTP_REQUEST, got 0 http.c:2899: Test failed: HttpQueryInfo failed http.c:2900: Test failed: expected size > 0 http.c:2974: Test failed: 3062: expected status 11 got 100 http.c:3074: Test failed: expected ERROR_INTERNET_INCORRECT_HANDLE_STATE got 12150 http.c:3081: Test failed: InternetWriteFile failed 12019 http.c:3082: Test failed: expected 0 got 21 http.c:2974: Test failed: 3093: expected status 20 got 100 http.c:2975: Test failed: 3093: expected function 3 got 5 http.c:2974: Test failed: 3101: expected status 21 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:2974: Test failed: 3101: expected status 30 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:1136: Test failed: file size = 0 http.c:1144: Test failed: file size = 100

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by Andrew Eikum 01 Oct '10

01 Oct '10

On 09/24/2010 02:59 PM, Andrew Eikum wrote: > Likely fixes bug 18776. > > This patch is based heavily on a patch from Rein Klazes which was > rejected last summer. According to comments on the bug, Rein's patch > appears abandoned. > <http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html> > > The style has been cleaned up, as well as some minor improvements to the > tests to pass on more platforms. These tests don't fail for me. What failures are you seeing?

2 2

Re: [2/2] msi: Set more 64-bit properties.
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5687 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10040: Test failed: key not removed install.c:10050: Test failed: key not removed install.c:10061: Test failed: key not removed install.c:10352: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet 01 Oct '10

01 Oct '10

I think this is going in the right direction, but I still have a couple of comments. On 1 October 2010 00:43, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Macro to compare two floating point numbers */ > +#define F_EQ(a, b, epsilon) (fabs(a - b) <= epsilon) There's no reason this can't be an inline function. > +/* Color macro to simplify handling of D3DXCOLOR */ > +#define COLOR(r, g, b, a) {r, g, b, a} This looks pretty pointless. > +/* Signals the end of a probe list */ > +#define PROBE_END {-1, 0, {0.0f, 0.0f, 0.0f, 0.0f}, 0.0f, ""} You'll probably want to just pass a count to compute_shader_probe9(). > + /* The x and y coordinate, the width and the height of the region to check. > + When x < 0, this is the last probe */ > + int x, y; There's no width and height here. > + setup_device9(device, &render_target, &readback, D3DFMT_A32B32G32R32F, > + width, height, vshader, pshader); You can't use D3DFMT_A32B32G32R32F without checking if it's available using CheckDeviceFormat() first. > + /* Now go through the probes and check each one */ > + for(;probes->x >= 0;probes++) { > + int index = probes->x + (probes->y * lr.Pitch); > + ok(F_EQ(probes->c.a, pbits_data[index].a, probes->epsilon), > + "In alpha component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.a, pbits_data[index].a); > + ok(F_EQ(probes->c.b, pbits_data[index].b, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.b, pbits_data[index].b); > + ok(F_EQ(probes->c.g, pbits_data[index].g, probes->epsilon), > + "In green component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.g, pbits_data[index].g); > + ok(F_EQ(probes->c.r, pbits_data[index].r, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.r, pbits_data[index].r); > + } You'll probably want to have a function to compare two D3DXCOLORs. Also, please include the line number of the caller of compute_shader_probe9() somewhere. > + if (caps.PixelShaderVersion >= 0xffff0200) You can still just use D3DPS_VERSION(2, 0) here.

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Jacek Caban 01 Oct '10

01 Oct '10

On 10/1/10 9:59 AM, Reece Dunn wrote: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). We most likely should use to_object here. Please add a comment about it. - return E_FAIL; + return throw_type_error(ctx->parser->script, ei, V_DISPATCH(&constr) ? IDS_OBJECT_EXPECTED : IDS_NO_PROPERTY, NULL); You can't access V_DISPATCH(&constr) here as you don't know if constr is of VT_DISPATCH type. Jacek

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Ricardo Filipe 01 Oct '10

01 Oct '10

2010/10/1 Reece Dunn <msclrhd(a)googlemail.com>: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). > > - Reece > > > > wouldn't this be more readable in separate lines? one less condition, just repeating the VariantClear...

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5679 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: wininet(3/5): Returned certificate strings are always ASCII
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5669 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0

Re: wininet(2/5): Add some secure connection tests
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5668 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0