October 2010 - Wine-devel - list.winehq.org

Re: [PATCH1/3] include/winternl: Add Logical Processor Information to SYSTEM_CPU_INFORMATION
by Dmitry Timoshkov 03 Oct '10

03 Oct '10

Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: > /* System Information Class 0x01 */ > +typedef struct _SYSTEM_CPU_CACHE_INFORMATION { > + ULONG ProcessorMask; > + CACHE_DESCRIPTOR CacheInformation; > +} SYSTEM_CPU_CACHE_INFORMATION, *PSYSTEM_CPU_CACHE_INFORMATION; > > typedef struct _SYSTEM_CPU_INFORMATION { > WORD Architecture; > @@ -1100,6 +1104,10 @@ typedef struct _SYSTEM_CPU_INFORMATION { > WORD Revision; /* combination of CPU model and stepping */ > WORD Reserved; /* always zero */ > DWORD FeatureSet; /* see bit flags below */ > + ULONG Cores[64]; /* Contains a Processormask for each physical core. Index is CoreID*/ > + ULONG ProcessorPackages[64]; /* Contains a Processormask for each processorpackage. Index is ProcessorPackage ID*/ > + ULONG NumaNodes[64]; /* Contains a Processormask for each numa node. Index is NumaNodeNumber */ > + SYSTEM_CPU_CACHE_INFORMATION Caches[256]; /* Contains all cpu cache entries found */ > } SYSTEM_CPU_INFORMATION, *PSYSTEM_CPU_INFORMATION; Where does this come from? At least the processor mask is supposed to be an ULONG_PTR. -- Dmitry.

4 8

Re: [PATCH 1/2] mshtml: add support for the HTMLWindow.onunload event.
by Jacek Caban 03 Oct '10

03 Oct '10

On 10/3/10 2:24 PM, Reece Dunn wrote: > Implements HTMLWindow_get/put_onunload. + {unloadW, onunloadW, EVENTT_NONE, DISPID_EVMETH_ONUNLOAD, + EVENT_DEFAULTLISTENER|EVENT_FORWARDBODY} EVENT_DEFAULTLISTENER won't work well here. Same for your onerror patch. Jacek

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by testbot＠testbot.winehq.org 03 Oct '10

03 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5729 Your paranoid android. === W98SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WNT4WSSP6 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2KPROSP4 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WXPPROSP3 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K3R2SESP2 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WVISTAADM (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K8SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PRO (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (64 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926

3 3

Git server down?
by Joel Holdsworth 02 Oct '10

02 Oct '10

"nmap source.winehq.org" shows no git port. Any ideas?

3 2

Re: cabinet/tests: Reformated output in case of test failure
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5725 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] winmm/tests: Set a struct member to 0 is obsolete, after adding a memset
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === W7PRO (32 bit midi) === midi.c:238: Test failed: bad message 1e/0 from midiOutOpen, expect 3c7/0 midi.c:295: Test failed: bad message 1e/0 from midiOutLong unprepared, expect 0/feedf00d midi.c:321: Test failed: bad message 1e/0 from midiOutClose, expect 3c8/0 midi.c:322: Test failed: bad message 3c7/0 from midiOut over, expect 0/feedf00d midi.c:398: Test failed: bad message 3c8/0 from midiStreamOpen, expect 3c7/0 midi.c:419: Test failed: bad message 3c7/0 from midiOutLong unprepared, expect 0/feedf00d

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 3]
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5709 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml.inf: Add default GeckoCabDir
by Austin English 02 Oct '10

02 Oct '10

On Fri, Oct 1, 2010 at 4:29 AM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf > index d7d2428..dea1712 100644 > --- a/dlls/mshtml/mshtml.inf > +++ b/dlls/mshtml/mshtml.inf > @@ -273,6 +273,7 @@ HKLM,"Software\Microsoft\Internet Explorer\Default Behaviors","TIME",, "CLSID:47 > > [WineGecko.Reg] > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Software\Wine\MSHTML,"GeckoCabDir",,"/usr/share/wine/gecko/" The directory isn't always /usr/share, it's relative to where wine is installed -- -Austin

6 10

Re: ntdll: Fix 64 bit issue within NTDLL_mergesort().
by Marcus Meissner 02 Oct '10

02 Oct '10

On Sat, Oct 02, 2010 at 12:31:03AM +0200, Stefan Oberhumer wrote: > --- > dlls/ntdll/misc.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > What is the alleged 64bit problem here? left and right are indexes, not sizes actually. Ciao, Marcus > diff --git a/dlls/ntdll/misc.c b/dlls/ntdll/misc.c > index 2d7c0a7..39b0ad3 100644 > --- a/dlls/ntdll/misc.c > +++ b/dlls/ntdll/misc.c > @@ -255,11 +255,11 @@ double CDECL NTDLL_tan( double d ) > > /* Merge Sort. Algorithm taken from http://www.linux-related.de/index.html?/coding/sort/sort_merge.htm */ > static void > -NTDLL_mergesort( void *arr, void *barr, int elemsize, int(__cdecl *compar)(const void *, const void *), > - int left, int right ) > +NTDLL_mergesort( void *arr, void *barr, size_t elemsize, int(__cdecl *compar)(const void *, const void *), > + size_t left, size_t right ) > { > if(right>left) { > - int i, j, k, m; > + size_t i, j, k, m; > m=(right+left)/2; > NTDLL_mergesort( arr, barr, elemsize, compar, left, m); > NTDLL_mergesort( arr, barr, elemsize, compar, m+1, right); > >

1 0

Re: msxml3: Use the existing READYSTAT type instead of creating our own enum READYSTAT (and mixing the two).
by Nikolay Sivov 02 Oct '10

02 Oct '10

> If there_is_ a reason to keep the two separate, I strongly suggest to > use different names (having a typedef READYSTAT as well as an enum by > that name is tricky) and someone needs to look in the mixing of types > that happens in line 277. Makes sense, yes. Honestly I didn't check for this type to be defined already, and it just happens to use the same name.

1 0