November 2010 - Wine-devel - list.winehq.org

Re: mshtml/tests: Add some broken 2k8 values
by Jacek Caban 11 Nov '10

11 Nov '10

Hi André, On 11/10/10 9:01 PM, André Hentschel wrote: > That really only happens on some 2008: > http://test.winehq.org/data/tests/mshtml:htmldoc.html > --- > dlls/mshtml/tests/htmldoc.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) AFAIR these failures are regression after commit 3b20cb11c8c61f141950bc5c71cfae14a35deea0. Looking at the patch it seems that these failures are strange and unexpected. Given that it worked before, we should be able to make it not without using broken() macro. Otherwise we won't be testing refcount leaks on Windows just because exactly one box has strange behavior. Jacek

2 1

Re: AUTHORS list and the C locale on Mac OS X
by James Mckenzie 11 Nov '10

11 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >On 11/9/10 12:13 PM, James Mckenzie wrote: >> No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by >> MacOSX changed to be acceptable? >That ain't gonna fly. I think we should explicitly use a UTF-8 locale >(like en_US.UTF-8 or some such) instead of the C locale when sed goes >over the AUTHORS file. Don't shoot the messenger. Maybe we can force the use of sed if it exists in the /usr/bin directory then to get around the 'brokenness' of GNU sed on the Mac? If not, it is a real bear to set the language on a Mac per previous discussions on the Users list. James McKenzie

6 12

Re: winmm/tests: Fix test failure in multi-byte locale.
by Marvin 11 Nov '10

11 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6989 Your paranoid android. === W98SE (32 bit mci) === mci.c:1007: Test failed: mci status position: 128

1 0

Re: [1/4] msxml3/domdoc: Fix duplicated declarations after document ::get_xml()
by Alexandre Julliard 11 Nov '10

11 Nov '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From 13c41e51047445591cb1b718f835a13bfe28c53d Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Sat, 6 Nov 2010 22:07:11 +0300 > Subject: [PATCH 1/4] Fix duplicated declarations after document ::get_xml() > > --- > dlls/msxml3/domdoc.c | 50 ++++++++++++++++++++++++++++++++++++++++- > dlls/msxml3/msxml_private.h | 2 + > dlls/msxml3/node.c | 2 +- > dlls/msxml3/tests/domdoc.c | 46 +++++++++++++++++++++++++++++++++++++ > dlls/msxml3/tests/saxreader.c | 1 + > 5 files changed, 99 insertions(+), 2 deletions(-) Sorry for not catching this sooner, this one breaks with libxml 2.6.16: ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o doctype.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm Undefined symbols: "_xmlSaveToBuffer", referenced from: _domdoc_get_xml in domdoc.o ld: symbol(s) not found collect2: ld returned 1 exit status winegcc: gcc failed make[1]: *** [msxml3.dll.so] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: inetcpl.cpl: Added Portuguese (Brazilian) translation (try 2)
by Paul Vriens 11 Nov '10

11 Nov '10

On 11/11/2010 03:13 PM, Eu wrote: > I had forgotten to configure the author name and e-mail, resending patch. > Hi Gustavo, The header says "English resources for the Internet control panel applet". You also need only one "LANGUAGE LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN" at the beginning. There is no need to have this for every resource. -- Cheers, Paul.

1 0

Re: [1/2] version: zero pad section up to virtual size
by Alexandre Julliard 11 Nov '10

11 Nov '10

Ričardas Barkauskas <miegalius(a)gmail.com> writes: > @@ -282,8 +282,12 @@ static BOOL find_pe_resource( HFILE lzfd, DWORD *resLen, DWORD *resOff ) > } > > /* Read in resource section */ > - resSectionSize = sections[i].SizeOfRawData; > - resSection = HeapAlloc( GetProcessHeap(), 0, resSectionSize ); > + if ( sections[i].SizeOfRawData < sections[i].Misc.VirtualSize ) > + resSectionSize = sections[i].SizeOfRawData; > + else > + resSectionSize = sections[i].Misc.VirtualSize; > + > + resSection = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sections[i].Misc.VirtualSize ); That won't work, the data won't be zero since you'll be reading from the filepast the end of the section. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winspool.drv: skip tests when no printer is installed
by Marvin 11 Nov '10

11 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6979 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Website copyright notice?
by Scott Ritchie 11 Nov '10

11 Nov '10

I was looking at the Wine wikipedia article and some jerk is nominating the logo image for deletion for copyright reasons. I wanted to correct the error and point to the license for the file, but couldn't actually find a license to point at. Have we asked this question before? Part of me just assumed the website had the same license as Wine itself (LGPL 2.1 or greater), is that the case? Thanks, Scott Ritchie

2 2

Re: mshtml/tests: Add some broken 2k8 values
by Marvin 10 Nov '10

10 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6958 Your paranoid android. === W7PRO (32 bit htmldoc) === htmldoc.c:2241: Test failed: unexpected call UpdateUI htmldoc.c:2466: Test failed: unexpected call Exec_UPDATECOMMANDS

2 1

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Alexandre Julliard 10 Nov '10

10 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does > Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you have an app that depends on this? -- Alexandre Julliard julliard(a)winehq.org

2 4