November 2010 - Wine-devel - list.winehq.org

Compilation error with latest wine
by Luca Bennati 14 Nov '10

14 Nov '10

I get this: registrar.c: In function ‘DllGetClassObject’: registrar.c:747:18: error: ‘CLSID_Registrar’ undeclared (first use in this function) registrar.c:747:18: note: each undeclared identifier is reported only once for each function it appears in registrar.c: In function ‘do_register_server’: registrar.c:796:22: error: ‘CLSID_Registrar’ undeclared (first use in this function) make[1]: *** [registrar.o] Error 1 make[1]: Leaving directory `/home/luca/wine-git/dlls/atl' make: *** [dlls/atl] Error 2 make: *** Waiting for unfinished jobs.... I'm compiling with "CFLAGS=' -g -O0 -pipe' CXXFLAGS=' -g -O0 -pipe' ./configure --prefix=/usr --sysconfdir=/etc --with-x --without-capi --without-gsm --without-icns" after a make distclean What's wrong here?

6 8

Re: widl: Fix for typelib generation when unaligned access to memory is not allowed
by Marcus Meissner 13 Nov '10

13 Nov '10

On Sat, Nov 13, 2010 at 07:02:02PM +0100, André Hentschel wrote: > caused a "Bus error" on sparc > --- > tools/widl/write_msft.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index da4eb25..5175b73 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -1208,7 +1208,11 @@ static void write_value(msft_typelib_t* typelib, int *out, int vt, const void *v > int len = strlen(s), seg_len = (len + 6 + 3) & ~0x3; > int offset = ctl2_alloc_segment(typelib, MSFT_SEG_CUSTDATA, seg_len, 0); > *((unsigned short *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset]) = vt; > - *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#ifdef ALLOW_UNALIGNED_ACCESS > + *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#else > + memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2], &len, sizeof(len)); > +#endif > memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+6], value, len); Just do the memcpy unconditional. Ciao, Marcus

1 0

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify
by Marvin 13 Nov '10

13 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7032 Your paranoid android. === W98SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called === WNT4WSSP6 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2KPROSP4 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === WVISTAADM (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2K8SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PRO (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (64 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called

2 1

Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)
by Paul Vriens 13 Nov '10

13 Nov '10

On 11/06/2010 11:16 AM, Bernhard Übelacker wrote: > Hello, > this patch checks for correct arrival of messages to a subclassed property page. > > For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically > the first WM_SIZE message is interesting which is not sent in wine. > > I have changed the patch based on the feedback I got on my first mail. > (http://www.winehq.org/pipermail/wine-devel/2010-October/087474.html) > > Now I am using the msg.h facilities for checking the messages. > > Kind regards, > Bernhard > Hi, Ever since this patch the shell32:shlexec tests fail on NT4 and W2K: http://test.winehq.org/data/tests/shell32:shlexec.html I can reproduce easily by running (on a clean Windows box): winetest-latest.exe comctl32:propsheet shell32:shlexec This will throw some error dialog boxes and I'm also unable to double-click items in the "Windows Explorer". Thoughts/Ideas/Suggestions? -- Cheers, Paul.

2 2

Re: regedit: add a manpage
by Alexandre Julliard 13 Nov '10

13 Nov '10

Austin English <austinenglish(a)gmail.com> writes: > While looking at the Debian Wine sources, I found they have manpages > for several of our bulitin programs :-) Then you should ask them to submit patches. You can't just grab the manpages and submit under your name. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: loader: On Mac, reserve the process's original thread for the frameworks. (try 2)
by Alexandre Julliard 13 Nov '10

13 Nov '10

Ken Thomases <ken(a)codeweavers.com> writes: > + { > + CFRunLoopAddSource( CFRunLoopGetMain(), source, kCFRunLoopCommonModes ); > + CFRunLoopSourceSignal( source ); > + CFRunLoopWakeUp( CFRunLoopGetMain() ); > + CFRelease( source ); > + > + /* This is a hack. We want to wait until the main thread has > + * really exited in response to our signal. However, Mac OS X > + * doesn't let us join the main thread for whatever reason. > + * It results in a SIGBUS. So, we just sleep for a bit and hope > + * it got enough time. */ > + usleep(100); We need something more reliable than this. (The pthread_join crash is a bug in libsystem, I filed a bug a while back but haven't heard anything). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] ntdll/tests: Added qsort_s tests. (try 5)
by Marvin 13 Nov '10

13 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7037 Your paranoid android. === WVISTAADM (32 bit string) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Help with 'WineAPI' wiki
by Max TenEyck Woodbury 12 Nov '10

12 Nov '10

As I mentioned before, I am trying to establish a place where the Windows API can be discussed that is not under the control of Microsoft. While the name I have chosen is debatable, it is not beyond reason and conveys enough about its intended contents that it should not be too hard to find. It currently consists of two major pieces: * The Wine piece follows the distribution directory structure with pages for each directory and many of the files. * The API piece currently consists of an index of all the APIs I found in the .spec files. * Other projects that use the windows API can put the information specific to their project in directory trees similar to the one I have set up for Wine. I am having a few specific problems: * Some of the .spec files contain more information than can be displayed on a single Wiki page. This information has to be split up into a reasonable number of sub-pages and organized so the information needed can be found fairly easily. I can handle the technical aspects of setting up the pages, and have some idea of where the splits should be, but I am uncertain enough that I want advice. * This is the first Wiki I have had administrative responsibility for and I frankly do not know what I am doing. Advice and help with the administration of the Wiki and the project would help. * Some of the technical choices have been based on my technical limits. I am simply ignorant of possible alternatives. Again, I think advice would help. * I know some of the sections are just plain ugly. I am mostly concerned with getting accurate and current information into the Wiki at this point, but the presentation does need improvement and again, I think some advice would be helpful. * My dyslexia has bitten me more than once. Someone to review what I am doing might help. - Max

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by Charles Davis 12 Nov '10

12 Nov '10

What's wrong now? Chip

1 1

re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7
by Dan Kegel 12 Nov '10

12 Nov '10

I think that's a clue that you need a better name than 'i'. Maybe 'fixme_shown'.

1 0