November 2010 - Wine-devel - list.winehq.org

Haiku talking about wine
by Dan Kegel 14 Nov '10

14 Nov '10

Seems to have been a long thread recently about restarting a port of Wine to Haiku, see http://haikuware.com/bounty-discussion/1533-wine-bounty I don't think there was anything really happening, though.

1 0

Re: [PATCH] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet 14 Nov '10

14 Nov '10

2010/11/14 Rico Schüller <kgbricola(a)web.de>: > +HRESULT d3dcompiler_shader_reflection_init(const void *data, SIZE_T data_size, void **reflector) Allocation and initialization are different things. Either way, it's unnecessary to make "reflector" void **. > + if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection)) > { > - ERR("Failed to allocate D3D compiler shader reflection object memory\n"); > - return E_OUTOFMEMORY; > + WARN("Wrong riid %s, accept only %s!\n", debugstr_guid(riid), debugstr_guid(&IID_ID3D11ShaderReflection)); > + return E_FAIL; > } I'm not sure if you have tests for this returning E_FAIL, but typically you'd expect E_NOINTERFACE for something like that.

1 0

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet 14 Nov '10

14 Nov '10

On 12 November 2010 21:08, Travis Athougies <iammisc(a)gmail.com> wrote: > + static struct hlsl_probe_info sin_probes[] = This should be const. As a general rule, try to pay attention to at least other patches to the same module. I fixed a couple of these about two weeks ago. Same goes for calculating the probe count. > + { > + {0, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {1, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {2, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {3, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {4, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {5, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {6, 0, {0.9620f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {7, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {8, 0, {1.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {9, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {10, 0, {0.9619f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {11, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {12, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {13, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {14, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {15, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {16, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {17, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {18, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {19, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {20, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {21, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {22, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {23, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {24, 0, {0.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {25, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {26, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {27, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {28, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {29, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {30, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {31, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + }; > + 32 probes is probably a bit excessive, but I guess it's not a major problem. Note that you can easily return the cosine results in the .y component though, instead of duplicating the complete test.

1 0

Re: wined3d: remove a useless variable
by Nikolay Sivov 14 Nov '10

14 Nov '10

On 11/14/2010 22:17, David Adam wrote: > if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > return; > } Why is it useless?

2 3

Re: wined3d: remove a useless variable
by André Hentschel 14 Nov '10

14 Nov '10

> > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > Why is that useless? It supresses console flooding. -- Best Regards, André Hentschel

1 0

Re: [msi/tests] Cleanup properly on Win9x
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7053 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [PATCH 10/10] mshtml: Added document fragment cloneNode implementation.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7048 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/10] mshtml: Correctly handle DOCUMENT_FRAGMENT_NODE in IHTMLDOMNode::get_nodeType.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7045 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [5/5] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7042 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [4/4] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0