November 2010 - Wine-devel - list.winehq.org

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework
by Alexandre Julliard 30 Nov '10

30 Nov '10

Aric Stewart <aric(a)codeweavers.com> writes: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 > +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec This is showing many deprecated function warnings even on Leopard. We should try to avoid that in new code. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.
by Dmitry Timoshkov 30 Nov '10

30 Nov '10

Alexander Puzankov <alxpnv(a)gmail.com> wrote: > + lpProc = mmioInstallIOProc(FOURCC_DOS, (LPMMIOPROC)mmio_test_IOProc, MMIO_INSTALLPROC); > + ok(lpProc == (LPMMIOPROC)mmio_test_IOProc, "mmioInstallIOProc error\n"); Please try to avoid this kind of casts, they hide the bugs. Also, if the tests depend on the following patches in sequence to pass, the tests should be sent as a last patch ('make test' should succeed after each patch in the sequence). -- Dmitry.

2 2

Translation patches for wine-1.2.2
by Michael Stefaniuc 30 Nov '10

30 Nov '10

Hello Alexandre, attached is the list of translation patches for wine-1.2.2. This time I manually checked the changes to the En.rc files if they are indeed a wine-1.2 incompatible change. Thus there are some patches in the list that I missed for wine-1.2.1 with the automatic "stop at first En.rc file change". Some other things to note: - There are 4 of my janitorial patches in; you can skip them like the last time and fix up the patches that don't cherry-pick cleanly. - "winhlp32: Use a standard About dialog, with the proper icon" seemed inconspicuous enough to include and thus allow translation patches for winhlp32 after that commit. - Does it make sense to include the Arab and Hebrew translations? Support for mirroring is only in wine-1.3.x. bye michael

1 0

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.
by Paul Vriens 30 Nov '10

30 Nov '10

Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 111 > ++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures: http://test.winehq.org/data/tests/mshtml:htmldoc.html Just a matter of adding 3000024 and 3000025 to the switch in PropertyNotifySink_OnChanged()? -- Cheers, Paul.

2 1

Re: shdocvw: Do not annoy user when he disabled winemenubuilder
by Alexandre Julliard 30 Nov '10

30 Nov '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -85,6 +85,9 @@ static BOOL run_winemenubuilder( const WCHAR *args ) > GetSystemDirectoryW( app, MAX_PATH - sizeof(menubuilder)/sizeof(WCHAR) ); > strcatW( app, menubuilder ); > > + if( GetFileAttributesW(app) == INVALID_FILE_ATTRIBUTES) > + return FALSE; Checking for file existence doesn't make much sense for builtins. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)
by C.W. Betts 30 Nov '10

30 Nov '10

It doesn't look like you look for Apple's OpenCL implementation, which uses <OpenCL/opencl.h>. You can do this: #ifdef __APPLE__ #include <OpenCL/opencl.h> #else #include <CL/opencl.h> #endif On Nov 29, 2010, at 7:39 AM, Peter Urbanec wrote: > Resending because previous patch was mangled by Thunderbird. > > --- > configure.ac | 13 ++++++++ > dlls/opencl/Makefile.in | 6 ++++ > dlls/opencl/opencl.c | 29 ++++++++++++++++++ > dlls/opencl/opencl.spec | 75 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 123 insertions(+), 0 deletions(-) > create mode 100644 dlls/opencl/Makefile.in > create mode 100644 dlls/opencl/opencl.c > create mode 100644 dlls/opencl/opencl.spec > > > <0001-opencl-Initial-stub-implementation-of-OpenCL-1.0.patch>

2 1

Re: [PATCH 1/5] ddraw/tests: Fix a typo.
by Marvin 29 Nov '10

29 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7343 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415849

1 0

Re: [PATCH 3/5] wined3d: Pass an IWineD3DDeviceImpl pointer to drawStridedSlow().
by Henri Verbeet 29 Nov '10

29 Nov '10

On 2010-11-29 23:08, Henri Verbeet wrote: > --- > dlls/wined3d/device.c | 12 ++++---- > dlls/wined3d/drawprim.c | 59 ++++++++++++++++++--------------------- > dlls/wined3d/wined3d_private.h | 2 +- > 3 files changed, 34 insertions(+), 39 deletions(-) > I messed up the commit message, this is for drawPrimitive() of course.

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 4.
by Alexandre Julliard 29 Nov '10

29 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 306 +++++++++++++++++++++++++++++++++---------------- > 1 files changed, 206 insertions(+), 100 deletions(-) This is causing strange crashes during prefix creation on 64-bit (there's no backtrace unfortunately). -- Alexandre Julliard julliard(a)winehq.org

1 0

Crappy Deb build scripts
by Ben Klein 29 Nov '10

29 Nov '10

By request of Austin, my crappy build scripts. I finally had the concentration to bundle all the right files together!

3 4