November 2010 - Wine-devel - list.winehq.org

Re: user32/tests: Remove obsolete comment
by Marvin 29 Nov '10

29 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7336 Your paranoid android. === W7PRO (32 bit input) === input.c:817: Test failed: 0 (a4/0): the msg sequence is not complete: expected 0000 - actual c0ae

1 0

Re: dsound.h: Undefine INTERFACE before using it.
by Alexandre Julliard 29 Nov '10

29 Nov '10

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -419,6 +419,7 @@ extern HRESULT WINAPI GetDeviceID(LPCGUID lpGuidSrc, LPGUID lpGuidDest); > /***************************************************************************** > * IDirectSound interface > */ > +#undef INTERFACE > #define INTERFACE IDirectSound > DECLARE_INTERFACE_(IDirectSound,IUnknown) The preferred pattern is to undefine it after use. If there are files that don't do this they should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] [Kernel32, Server]: fixed a couple of bugs when reading bare console input with overlapped operations
by Alexandre Julliard 29 Nov '10

29 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -3011,6 +3014,7 @@ BOOL CONSOLE_Init(RTL_USER_PROCESS_PARAMETERS *params) > /* reply->event shouldn't be created by server */ > } > SERVER_END_REQ; > + fcntl( 0, F_SETFL, O_NONBLOCK ); I don't think that's a good idea, the calling process may not expect that. Also using overlapped I/O seems overkill considering that you already have a Unix fd. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: remove unused field
by Vincent Povirk 29 Nov '10

29 Nov '10

I don't know much about this area of Wine, but I think the change is incorrect. The DC's transform is applied to the font when it is rendered. To do this correctly, the glyphs must be transformed when they are rasterized and uploaded. Note that we only appear to use the first four fields of XFORM (they are copied to a shorter FMAT2 struct) to rasterize the glyphs. The last two fields of XFORM only specify an offset, so I think they can be safely ignored. 2010/11/28 Ričardas Barkauskas <miegalius(a)gmail.com>: > Makes Steam store page scrolling smoother. > Didn't find where this field would be used or what relevant difference > between fonts it would indicate for this caching. > Without it lots of fonts differing only by fields in this structure are > created in such a way that they get marked as unused almost immediately and > thus cache entries get reused fast. > Hacking to allow for much more generous cache growth resulted ~880 entries > (in short run) in font cache and it still managed not to find font in cache > quite often. > With this I didn't notice any such growth, no visual changes and no tests > complained (that don't complain usually). > Don't know what if any tests I could write for this (or more likely I simply > wouldn't be able :P). > > Rčardas Barkauskas > REalm > > > >

2 1

[PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo
by James Eder 29 Nov '10

29 Nov '10

On 11/26/10 12:15 AM, Damjan Jovanovic wrote: > On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen > <wine-devel at kievinfo.com> wrote: >> On 11/24/2010 07:19 PM, James McKenzie wrote: >>> On 11/24/10 6:56 PM, Vitaliy Margolen wrote: >>>> On 11/24/2010 12:23 PM, jimportal at gmail.com wrote: >>>>> From: James Eder<jimportal at gmail.com> >>>>> >>>>> - while (fgets(line,200,f) != NULL) >>>>> + while (fgets(line,450,f) != NULL) >>>> You might as well then change this to "sizeof(line)". >>> Just for my edification, is there not a better way then setting the >>> variable >>> line to a flexible length for this purpose. >> Unless I didn't understand your question - you can't set a buffer to a >> "variable length". You have to provide fgets() a size of the buffer so it >> can read at most that many characters -1 for terminating \0. >> >> Vitaliy. >> >> >> > So read lines dynamically instead: > It would be nice to not reinvent that wheel all the time. I don't suppose your function could be pulled out of winemenubuilder.c and placed in a more accessible location. Should I just copy and paste it? It's a good function and it would fit just fine in my opinion. Alternatively, I doubt 2k or 4k worth of processor features ("flags") are going to show up for some years, but I don't know. At any rate, at least it would fix it for current systems. -- Jim

3 4

Re: winex11: remove unused field
by Dmitry Timoshkov 29 Nov '10

29 Nov '10

Ričardas Barkauskas <miegalius(a)gmail.com> wrote: > typedef struct > { > LOGFONTW lf; > - XFORM xform; > SIZE devsize; /* size in device coords */ > DWORD hash; > } LFANDSIZE; > @@ -639,7 +638,6 @@ static BOOL fontcmp(LFANDSIZE *p1, LFANDSIZE *p2) > { > if(p1->hash != p2->hash) return TRUE; > if(memcmp(&p1->devsize, &p2->devsize, sizeof(p1->devsize))) return TRUE; > - if(memcmp(&p1->xform, &p2->xform, sizeof(p1->xform))) return TRUE; > if(memcmp(&p1->lf, &p2->lf, offsetof(LOGFONTW, lfFaceName))) return TRUE; > return strcmpiW(p1->lf.lfFaceName, p2->lf.lfFaceName); > } It's not useless, probably you need to check the DC graphics mode before storing the XFORM in the cache, like dlls/gdi32/freetype.c,WineEngCreateFontInstance() is doing. -- Dmitry.

1 0

Re: [PATCH] user32/tests: Fix test failures by disabling IME when testing unicode input.
by Marvin 29 Nov '10

29 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7331 Your paranoid android. === W7PRO (32 bit input) === input.c:817: Test failed: 0 (a4/0): the msg sequence is not complete: expected 0000 - actual c0ae

1 0

Packaging 1.3.7 and newer, lucid?
by Trygve Vea 28 Nov '10

28 Nov '10

Hello, I can't seem to find wine 1.3.7 / 1.3.8 packages for lucid in the ppa-repository. Does anyone know if this is on purpose? Regards -- Trygve Vea

3 3

Re: quartz: Start DirectSound renderer as soon as possible.
by Erich Hoover 28 Nov '10

28 Nov '10

I've been working on a set of patches (compiled together and attached for your convenience) to fix the background music in Fallout 3 (Bug #24478) and I've run into some trouble recently with commit 64b14c0ecdd13530a92ff636c451523a99253a0b. Before that commit (or removing that commit in current git) and applying the patches allows the music to function in both the main menu, properly stop when the menu is closed, and later play again when the user is in the game. With said commit applied these patches still permit the background music to work when at the main menu; however, the moment the "stop" occurs on exiting the menu then all audio in the entire game ceases to function. I would really appreciate any feedback you can provide or pointers on where to look for the source of this problem. Thanks in advance! Erich Hoover ehoover(a)mines.edu

2 3

Re: [2/2] atl: add support for binary values in IRegistrar
by Paul Vriens 28 Nov '10

28 Nov '10

Hi Damjan, On 11/24/2010 10:10 AM, Damjan Jovanovic wrote: > Changelog: > * atl: add support for binary values in IRegistrar > > It appears that 'm' (REG_MULTI_SZ) values do not work on Windows (not > even the MSDN example on > http://msdn.microsoft.com/en-us/library/ttd53fhh(VS.71).aspx) so this > concludes the patch set. > I see some failures on test.winehq.org: http://test.winehq.org/data/tests/atl:registrar.html My Win95 also fails and all the Windows boxes that fail, fail with 0x80020009 (DISP_E_EXCEPTION). Removing both binary values from textA (and the corresponding tests of course) makes the tests succeed on my Win95 box. Does that makes sense? I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7. So what decides if binary values are supported? -- Cheers, Paul.

2 3