November 2010 - Wine-devel - list.winehq.org

re: msvcrt: Fixed problem parsing multi-byte characters in _mbspbrk.
by Dan Kegel 28 Nov '10

28 Nov '10

http://en.wiktionary.org/wiki/negato says Adjective negato m. (f. negata, m plural negati, f plural negate) 1. denied, refused negato m. (f. negata, m plural negati, f plural negate) (per) or (in) 1. useless, hopeless (at) Neither that, nor the William Gates pseudonym, are particularly helpful. Wine is built on a web of trust, and if we have no idea who you are -- and if you act like you have something to hide -- we might have to assume that you've purloined Windows source code, and refuse your patch to protect ourselves. So, who are you, really? - Dan

1 0

Re: msvcrt: Fixed problem parsing multi-byte characters in _mbspbrk.
by William Gates 27 Nov '10

27 Nov '10

Who's to say this is not my real name? On Sat, Nov 27, 2010 at 5:08 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > On 11/26/10 11:41 AM, William Gates wrote: > > You have to send in patches with your real name. > > James McKenzie > > > >

2 1

Re: atl/tests: Fix test in test_registrar.
by Paul Vriens 27 Nov '10

27 Nov '10

Hi Gerald, On 11/27/2010 10:19 PM, Gerald Pfeifer wrote: > An obvious one I'd say... > > Gerald > --- > dlls/atl/tests/registrar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/atl/tests/registrar.c b/dlls/atl/tests/registrar.c > index 422608b..268765f 100644 > --- a/dlls/atl/tests/registrar.c > +++ b/dlls/atl/tests/registrar.c > @@ -106,7 +106,7 @@ static void test_registrar(void) > size = 4; > lret = RegQueryValueExA(key, "binary_quoted", NULL, NULL, bytes,&size); > ok(lret == ERROR_SUCCESS, "RegQueryValueA, failed, error %d\n", lret); > - ok(bytes[0] = 0xde&& bytes[1] == 0xad&& bytes[2] == 0xbe&& bytes[3] == 0xef, > + ok(bytes[0] == 0xde&& bytes[1] == 0xad&& bytes[2] == 0xbe&& bytes[3] == 0xef, > "binary quoted value was not preserved (it's 0x%02X%02X%02X%02X)\n", > 0xff& bytes[0], 0xff& bytes[1], 0xff& bytes[2], 0xff& bytes[3]); > There are two of these actually. Do you mind me sending in one big patch to fix the stuff you found and the fix for Win95/NT that don't support binary values? -- Cheers, Paul.

1 0

Re: Added unit test suite for process functions (try 4)
by James McKenzie 27 Nov '10

27 Nov '10

On 11/27/10 9:03 AM, Borut Razem wrote: > On 11/27/2010 03:48 AM, Marvin wrote: > > process.c:133: Test failed: _pclose should return after 2 seconds, > but it returned after 6 seconds > > It seems that the "paranoid android" Marvin was very busy... > Looks like something else went busy too as I received about ten copies on the Wine Patches list. James McKenzie

1 0

Could these changes break Wine? Fwd: gcc in natty now passes --as-needed by default to the linker
by Scott Ritchie 27 Nov '10

27 Nov '10

Trying to head off a problem before it's a problem... -------- Original Message -------- Subject: gcc in natty now passes --as-needed by default to the linker Date: Mon, 15 Nov 2010 12:26:27 +0100 From: Matthias Klose <doko(a)ubuntu.com> Reply-To: ubuntu-devel-discuss(a)lists.ubuntu.com To: ubuntu-devel <ubuntu-devel-announce(a)lists.ubuntu.com>, ubuntu-devel <ubuntu-devel(a)lists.ubuntu.com> There is a second change to the linking in natty; as announced in [1], --no-add-needed/--no-copy-dt-needed-entries is passed by default, with the current gcc in natty, --as-needed is passed as well. Please see [2] for implications (runtime failures) and a list of packages which might be affected. To revert this change on a per package basis, pass --no-as-needed to the linker (-Wl,--no-as-needed in LDFLAGS). To add an explicit dependency on a library use --no-as-needed -lfoo --as-needed. Please tag bug reports with `as-needed' if you see runtime failures caused by this change (mostly unresolvable symbols referenced by plugins and ldopened objects). Matthias [1] https://lists.ubuntu.com/archives/ubuntu-devel-announce/2010-October/000772… [2] http://wiki.debian.org/ToolChain/DSOLinking#Onlylinkwithneededlibraries

3 2

Re: Added unit test suite for process functions (try 3)
by Marvin 26 Nov '10

26 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7294 Your paranoid android. === WVISTAADM (32 bit process) === process.c:133: Test failed: _pclose should return after 2 seconds, but it returned after 6 seconds === W2K8SE (32 bit process) === process.c:133: Test failed: _pclose should return after 2 seconds, but it returned after 6 seconds

1 0

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo
by Vitaliy Margolen 26 Nov '10

26 Nov '10

On 11/24/2010 12:23 PM, jimportal(a)gmail.com wrote: > From: James Eder<jimportal(a)gmail.com> > > - while (fgets(line,200,f) != NULL) > + while (fgets(line,450,f) != NULL) You might as well then change this to "sizeof(line)". Vitaliy.

3 5

Re: [1/4] msi: Fix the Create/RemoveFolders actions to actually create and remove empty folders.
by Marvin 26 Nov '10

26 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7281 Your paranoid android. === W2K8SE (32 bit action) === Timeout

1 0

re: dockFill problem
by Dan Kegel 26 Nov '10

26 Nov '10

.bill wrote: > I have the following problem in a .NET application. > A form resides in a maximized MDI window. > On startup the MDI gets maximized but the form is not although the dockFill property is set. Sounds interesting. If you're not already, please try the latest version of wine (1.3.7 or built from git). If the problem persists, please file a bug, and we'll give you suggestions about debugging there. If you can include the source and binary for a tiny program that demonstrates the problem, that would help greatly. - Dan

2 2

Re: wined3d: Allow color key processing for surfaces with alpha channel
by Stefan Dösinger 26 Nov '10

26 Nov '10

Am Mittwoch 24 November 2010, 12:38:00 schrieb Ilya Shpigor: > Hello! > > This is new patch for bug: > http://bugs.winehq.org/show_bug.cgi?id=23750 > > I have tested color key processing for SURFACE_OPENGL and SURFACE_GDI > surfaces with alpha channel in Windows.The color key has been processed > for both surface types. I'm not sure I understand - SURFACE_OPENGL and SURFACE_GDI are wine specific, how did you test on Windows? > I don't know how to write correct Wine test for this problem. Can anybody > help me? > Is this Wine test realy needed? Yes, we need a test for this patch, as it contradicts documentation I have previously read. A Nvidia document about color keying emulation states that Nvidia drivers ignore color keying on Alpha 3D textures. Thus we need a test to (a) be sure that the patch is correct and (b) make sure we don't revert the patch if reverting it happens to fix some app in the future. Take a look at dlls/ddraw/tests/dsurface.c and dlls/ddraw/tests/visual.c. The best would be to write a test for the 2D blitting path in dsurface.c and a test for drawing with a color keyed 3D texture in visual.c

1 0