February 2010 - Wine-devel - list.winehq.org

Re: [PATCH 4/5] wined3d: Remove the unused device type parameter from the fragment pipe's get_caps() function.
by Stefan Dösinger 04 Feb '10

04 Feb '10

Am 03.02.2010 um 18:17 schrieb Henri Verbeet: > On the subject of actually supporting software devices, we should probably > implement those by creating a software or reference adapter with appropriate > gl_info and pipe implementations and creating a device based on that. Wouldn't that conflict with how adapters work in the d3d8/9 API? There an adapter identifies the display hardware, not necessarily the rendering device. Or, to phrase it in API terms: > static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT adapter_idx, > WINED3DDEVTYPE device_type, HWND focus_window, DWORD flags, IUnknown *parent, > IWineD3DDeviceParent *device_parent, IWineD3DDevice **device) You'd want to remove device_type from here as well if we merge it into the adapter(and then deal with splitting up wined3d adapters into d3d8/9 adapters and device types in the client libs)

2 2

Check out my photos on Facebook
by Kirn Gill 04 Feb '10

04 Feb '10

Hi Wine-devel, I set up a Facebook profile where I can post my pictures, videos and events and I want to add you as a friend so you can see it. First, you need to join Facebook! Once you join, you can also create your own profile. Thanks, Kirn To sign up for Facebook, follow the link below: http://www.facebook.com/p.php?i=1311167334&k=Z3D4XXPXVZT14JDIWK662USUVWFJ5T… Already have an account? Add this email address to your account http://www.facebook.com/n/?merge_accounts.php&e=wine-devel(a)winehq.org&c=a… was invited to join Facebook by Kirn Gill. If you do not wish to receive this type of email from Facebook in the future, please click on the link below to unsubscribe. http://www.facebook.com/o.php?k=dd3238&u=728096903&mid=1d44feaG2b65e087G0G8 Facebook's offices are located at 1601 S. California Ave., Palo Alto, CA 94304.

1 0

make crosstest issue
by Christian Costa 03 Feb '10

03 Feb '10

Hi, make crosstest gives the following output : ../../../tools/winegcc/winegcc -b i586-mingw32msvc -B../../../tools/winebuild --sysroot=../../.. --lib-suffix=.cross.a d3drm.cross.o vector.cross.o testlist.cross.o -o d3drm_crosstest.exe -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lwinecrt0 collect2: ld a retourné 1 code d'état d'exécution winegcc: i586-mingw32msvc-gcc failed make: *** [d3drm_crosstest.exe] Erreur 2 This was working before. Any Idea ? Bye Christian

3 3

Wine FIXME Report 2009 Aug - Dec
by Michael Stefaniuc 03 Feb '10

03 Feb '10

Hello! Introduction ============ Back at the last WineConf after the wineoops presentation I have been asked if the wineoops could collect FIXME/ERR messages too and do some statistics on those. Well, it doesn't and I didn't want to introduce scope creep thus this new "project" winefixme was created (while reusing a lot of code). As the complexity of this problem is a lot easier than the one tackled by wineoops it goes into "production" first. After this initial report covering the month August to December of 2009 I will do a monthly report at the beginning of every month covering the previous month; the report for January 2010 is to be expected in the first week of February 2010. Wine FIXME Report 2009 Aug to Dec ================================= The data for this report comprise the emails from the 2009 Aug to Dec archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 35369 (emails: 32631, bugzilla attachments: 2738) Files with FIXME/ERR/WARN: 2256 Type | Total | Unique ------+--------+-------- fixme | 170639 | 36113 err | 67789 | 2958 warn | 29367 | 9283 The Most Popular Messages ------------------------- This are the most prevalent ERR and FIXME messages aka the number of files where they show up. FIXME: Files | Lines | Channel:Text ------+-------+------------- 220 | 246 | system:SetProcessDPIAware stub! 213 | 285 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 209 | 559 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 209 | 877 | shell:DllCanUnloadNow stub 133 | 501 | urlmon:URLMoniker_BindToObject use running object table 110 | 118 | resource:GetGuiResources (0xffffffff,0): stub 94 | 386 | shdocvw:BindStatusCallback_OnProgress status code 11 81 | 1002 | wininet:InternetLockRequestFile STUB 79 | 125 | msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" 76 | 269 | advapi:DeregisterEventSource (0xcafe4242) stub ERR: Files | Lines | Channel:Text ------+-------+------------- 77 | 99 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 75 | 98 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 58 | 3052 | ole:CoCreateInstance apartment not initialised 57 | 139 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 52 | 87 | ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. 52 | 84 | ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. 46 | 92 | ole:CoUninitialize Mismatched CoUninitialize 45 | 89 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 45 | 186 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 44 | 88 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered The Top Ten Single Charts ------------------------- This are the messages with the most occurrences in a single file. FIXME: Lines | Files | Channel:Text ------+-------+------------- 5270 | 1 | d3d_surface:surface_download_data Read back converted textures unsupported, format=WINED3DFMT_B5G6R5_UNORM 3436 | 1 | d3d7:IDirect3DDeviceImpl_3_SetLightState D3DLIGHTSTATE_MATERIAL called with NULL material !!! 2456 | 1 | d3d_surface:surface_load_ds_location (0x1a7c50) Not supported with fixed up depth stencil 2346 | 4 | mlang:fnIMultiLanguage2_ConvertStringToUnicodeEx 1852 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000109 1468 | 1 | d3d_draw:drawStridedInstanced >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glDrawElements @ drawprim.c / 547 1451 | 1 | ddraw:IDirectDrawImpl_WaitForVerticalBlank (0xa2204e0)->(1,0x0): Stub 1430 | 1 | d3d:IWineD3DSwapChainImpl_Present Unhandled present options 0x32fc94/0x32fca4 1404 | 6 | rpc:NdrStubCall2 new correlation description not implemented 1279 | 1 | rpc:RpcImpersonateClient ((nil)): stub ERR: Lines | Files | Channel:Text ------+-------+------------- 3561 | 3 | win:DefWindowProcW called for other process window 0x10020 3110 | 6 | d3d:resource_init Out of adapter memory 3110 | 2 | ddraw:IDirectDrawImpl_CreateNewSurface IWineD3DDevice::CreateSurface failed. hr = 8876017c 3098 | 2 | ddraw:IDirectDrawImpl_CreateSurface IDirectDrawImpl_CreateNewSurface failed with 8876017c 2436 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1b50000 dib.bitmap_data=0x1b50000 1217 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1a60000 dib.bitmap_data=0x1a60000 751 | 2 | ole:CoGetClassObject no class object {33246f92-d56f-4e34-837a-9a49bfc91df3} could be created for context 0x4 750 | 2 | ole:create_server class {33246f92-d56f-4e34-837a-9a49bfc91df3} not registered 700 | 1 | d3d_surface:IWineD3DBaseSurfaceImpl_CreateDIBSection CreateDIBSection failed! 584 | 58 | ole:CoCreateInstance apartment not initialised The Most Chatty Channels ------------------------ Includes the ERR and FIXME messages for a channel sorted by the number of lines. Channel | Lines -----------+------ d3d | 34496 d3d_surface| 19381 ole | 19172 shdocvw | 16462 ddraw | 15058 shell | 13980 msi | 9177 dinput | 8476 win | 6566 wininet | 5625 Further Info: ------------- The sqlite3 database and the SQL commands to output the above info can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/200908-200912/ Questions and feedback are welcome! bye michael

9 13

Re: [PATCH] msi: call Custom function via wrapper
by Henri Verbeet 03 Feb '10

03 Feb '10

On 3 February 2010 16:57, Marcus Meissner <meissner(a)suse.de> wrote: > The difference to other packages is that 11.2 Wine builts with > -fomit-frame-pointer. > Sounds like a questionable thing to do, this is probably not the only place where the frame pointer saves broken applications.

1 0

Re: d3d10/test: Add effect shader test.
by Stefan Dösinger 03 Feb '10

03 Feb '10

Am 03.02.2010 um 18:52 schrieb Rico Schüller: > Hi, > > this patch adds a test case for d3d10 shader parsing and ID3D10EffectPass::Get*ShaderDesc() functions. > +static DWORD fx_local_shader[] = { > +0x43425844, 0x95577e13, 0xab5facae, 0xd06d9eab, > +0x8b127be0, 0x00000001, 0x00001652, 0x00000001, > ... the binary shader is pretty long. Wouldn't it be better to load the bytes from an external file, or if that makes the tests too complicated, put the DWORD[] into a separate .c or .h file? > + hr = D3D10CreateEffectFromMemory(fx_local_shader, fx_local_shader[6], 0, device, NULL, &effect); Is there a reason for using fx_local_shader[6] instead of sizeof(fx_local_shader)? I see that the other tests do it as well.

3 2

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter
by Alexandre Julliard 03 Feb '10

03 Feb '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > +/* Macro to get the SampleGrabber This pointer from interface pointer */ > +#define GET_THIS(ptr,iface) ((SG_Impl *)((char *)(ptr) - FIELD_OFFSET(SG_Impl,iface ## _Vtbl))) Please define an inline function for that sort of thing. Look at shelllink.c for examples. -- Alexandre Julliard julliard(a)winehq.org

2 2

re: msi: copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl (resend)
by Dan Kegel 03 Feb '10

03 Feb '10

André Hentschel wrote > makes the installer in http://tinyurl.com/y9gy6c4 run farther Thanks for including the link. (For the curious, see http://www.boschrexroth.com/business_units/brc/de/information_de/software_d… http://www.boschrexroth.com/country_units/america/united_states/en/products… It looks like a pretty cool CAD simulation package.)

1 0

Re: [PATCH] mdi: fix drawing the MDI client area when creating children.
by Alexandre Julliard 03 Feb '10

03 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> writes: > diff --git a/dlls/user32/mdi.c b/dlls/user32/mdi.c > index 631d477..0850282 100644 > --- a/dlls/user32/mdi.c > +++ b/dlls/user32/mdi.c > @@ -1132,6 +1132,7 @@ LRESULT MDIClientWndProc_common( HWND hwnd, UINT message, WPARAM wParam, LPARAM > hwnd, 0, csA->hOwner, > (LPVOID)csA->lParam); > } > + InvalidateRect(hwnd, NULL, TRUE); > return (LRESULT)child; The window should have been exposed and repainted when the children got resized. If this doesn't happen it's a bug, but invalidating by hand is only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function.
by Henri Verbeet 03 Feb '10

03 Feb '10

On 2 February 2010 18:11, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > +void wpp_write_message_var(const char *fmt, ...) This is probably not strictly required, but if you add the gcc format attribute to the function, gcc will check if the parameters types match the ones in the format string. You can look at the PRINTF_ATTR macro in dlls/wined3d/wined3d_private and similar macros in other places for examples. > + if(current_include == NULL) > + { > + ERR("current_include == NULL, desc == %p, buffer = %s\n", > + desc, desc->buffer); > + HeapFree(GetProcessHeap(), 0, desc); > + return; > + } > + ID3DXInclude_Close(current_include, desc->buffer); > + HeapFree(GetProcessHeap(), 0, desc); > + return; Something like the following is probably nicer: + if (current_include) + ID3DXInclude_Close(current_include, desc->buffer); + else + ERR("current_include == NULL, desc == %p, buffer = %s\n", desc, desc->buffer); + + HeapFree(GetProcessHeap(), 0, desc); + return; > + struct wpp_callbacks wpp_callbacks = { > + wpp_lookup_mem, > + wpp_open_mem, > + wpp_close_mem, > + wpp_read_mem, > + wpp_write_mem, > + wpp_error, > + wpp_warning, > + }; This should be static const. > + TRACE("Shader source:\n"); > + for(i=0;i<data_len;i++) > + { > + TRACE("%c", data[i]); > + } > + TRACE("\n"); This doesn't look right. You should be using debugstr_an(), since this is external data you're tracing.

1 0