February 2010 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] d3drm: Improve IDirect3DRMMeshBuilderImpl_Load and corresponding test
by Paul Vriens 03 Feb '10

03 Feb '10

On 02/03/2010 08:38 AM, Christian Costa wrote: > > --- > > dlls/d3drm/meshbuilder.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- > dlls/d3drm/tests/d3drm.c | 32 ++++++++++++++++++++++++-------- > 2 files changed, 69 insertions(+), 9 deletions(-) > > > > Hi Christian, I ran your tests on winetestbot and it shows some failures on several platforms: https://winetestbot.geldorp.nl/JobDetails.pl?Key=562 -- Cheers, Paul.

2 1

Re: [PATCH 4/5] d3drm: Add some tests
by Stefan Dösinger 03 Feb '10

03 Feb '10

On Monday 01 February 2010 08:18:42 Christian Costa wrote: > +void Test(void) > +{ > ... > Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file.

3 7

Re: [1/2] msxml3/doc: Implement IXMLDOMDocument::get_url() with some tests
by Jacek Caban 03 Feb '10

03 Feb '10

Hi Nikolay, On 2/2/10 11:23 PM, Nikolay Sivov wrote: > Implement IXMLDOMDocument::get_url() with some tests > You probably should use GetDisplayName result of moniker used to load the document to obtain its URL. Thanks, Jacek

2 2

re: msi: copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl
by Dan Kegel 02 Feb '10

02 Feb '10

> makes an installer run farther Please, when posting patches like that, mention *which* installer, unless you have some good reason to keep it private. Thanks!

1 0

Several msxmlX modules
by Nikolay Sivov 02 Feb '10

02 Feb '10

Hi. Wine currently has only one module for MSXML parser - msxml3. Since the third one v4 and v6 are already out. Judging from file size I don't think native modules reuse some code between them, instead it looks like a completely independent builds. What Wine's policy should be about that? Is that really necessary to have several modules to look like native does (forwarding class creation to msxml3 of course)? The other way is a bit misleading - having msxml3 that responds to v4 interface creation I mean (and lot of application depend on version fourth today). After that I thought about renaming msxml3 to msxml but I'm not sure that won't break some apps. I'd like to see some opinions on this.

3 5

Re: ws2_32: Fix parameter validation order in getpeername.
by Alexandre Julliard 02 Feb '10

02 Feb '10

Andrew Nguyen <arethusa26(a)gmail.com> writes: > Invalid pointers appear to be handled by getpeername in all versions > of Windows, so adding an exception handler seems to be justified. It's only justified if there is a real app that passes a bad pointer that is not the result of some other Wine bug. Please provide more details. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().
by Maarten Lankhorst 02 Feb '10

02 Feb '10

Hi Lei, 2010/2/2 Lei Zhang <thestig(a)google.com>: > Hi, > > Over the weekend, someone wrote a Chromium base unit test that calls > DestroyEnvironmentBlock(). So I guess it's time to implement it. The > modified Wine test case passed on my WinXP machine. Are you sure that DestroyEnvironmentBlock needs that null pointer check? ~Maarten

2 1

Re: [1/3] gdiplus: Implement GdipSetImageAttributesGamma.
by Paul Vriens 02 Feb '10

02 Feb '10

On 01/31/2010 02:03 AM, Vincent Povirk wrote: > + stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color); > + expect(Ok, stat); > + todo_wine expect(0xff20ffff, color); Hi Vincent, This one introduces a test failure on what appears to be mostly VMware boxes. Not all VMware boxes show this failure btw and I did see the same failure on a real WinMe box. Would a color_match (like we use in several other tests) be more appropriate or maybe a broken()? -- Cheers, Paul.

2 1

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter
by Nikolay Sivov 02 Feb '10

02 Feb '10

On 2/2/2010 16:21, Paul Chitescu wrote: > Changelog: > qedit: Mostly stubbed out implementation of SampleGrabber filter > > Until the last patch component is applied most application will crash as they > rarely check for errors. > > + if (IsEqualIID(riid,&IID_IUnknown) || > + IsEqualIID(riid,&IID_IPersist) || > + IsEqualIID(riid,&IID_IMediaFilter) || > + IsEqualIID(riid,&IID_IBaseFilter)) { > + InterlockedIncrement(&This->refCount); > + *ppvObject =&(This->IBaseFilter_Vtbl); > + return S_OK; > + } > You should use ISampleGrabber_AddRef() here on success to keep increment call in one place. It's a common practice as far as i can see in Wine code.

2 1

user32: A window is after a call to SetParent invisible when hwnd and newParent is equal (bug 21497)
by Bernhard Übelacker 02 Feb '10

02 Feb '10

(Resent, my first mail has not appeared on the list?) Hello, in SetParent the window (hwnd) get hidden by ShowWindow( hwnd, SW_HIDE ), then a call to wineserver is done and then the window is made visible again. If this call to wineserver fails the window stays invisible. This patch at least avoids this when hwnd and newParent is equal. (If there are other cases this call could fail the window stays invisble.) It could be observed in http://bugs.winehq.org/show_bug.cgi?id=21497 I want to ask for some comments what to change or if it could be sent to wine-patches as it is? Kind regards Bernhard --- dlls/user32/tests/win.c | 6 ++++++ dlls/user32/win.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 6fb6ce0..82caccb 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -445,6 +445,12 @@ static void test_parent_owner(void) ret = SetParent( test, child ); ok( ret == desktop, "SetParent return value %p expected %p\n", ret, desktop ); check_parents( test, child, child, 0, 0, hwndMain, test ); + + ShowWindow( test, SW_SHOW ); + ret = SetParent( test, test ); + ok( ret == NULL, "SetParent return value %p expected %p\n", ret, NULL ); + ok( GetWindowLongA( test, GWL_STYLE ) & WS_VISIBLE, "window is not visible after SetParent\n" ); + check_parents( test, child, child, 0, 0, hwndMain, test ); DestroyWindow( test ); /* owned popup */ diff --git a/dlls/user32/win.c b/dlls/user32/win.c index acf70a3..8308ba8 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -2690,8 +2690,8 @@ HWND WINAPI SetParent( HWND hwnd, HWND parent ) return 0; } - /* Some applications try to set a child as a parent */ - if (IsChild(hwnd, parent)) + /* Some applications try to set a child as a parent or itself */ + if (IsChild(hwnd, parent) || hwnd == parent) { SetLastError( ERROR_INVALID_PARAMETER ); return 0; -- 1.6.5

1 0