April 2010 - Wine-devel - list.winehq.org

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
by Tony Wasserka 20 Apr '10

20 Apr '10

> +static inline void check_ref(IUnknown *obj, int exp) > +static inline void check_release(IUnknown *obj, int exp) We shouldn't use these function definitions anymore IMO, either do the ref check in the code itself, or replace the check_ref and check_release functions with macros; the reason is that if there really is a test error, the given line refers to the function source and thus won't help us at all, i.e. before actually examining an error you'd first have to find out what check actually failed... Also I'm not too sure whether it's necessary to include resources.h ... > + if (SUCCEEDED(hr)) { > + if (*format == D3DFMT_UNKNOWN || *format == D3DX_DEFAULT) *format = D3DFMT_A8R8G8B8; > + > + hr = IDirect3D9_CheckDeviceFormat(d3d, params.AdapterOrdinal, params.DeviceType, mode.Format, usage, > + D3DRTYPE_TEXTURE, *format); > + } > + > + if (d3d) > + IDirect3D9_Release(d3d); > + > + if (FAILED(hr)) > + return D3DERR_INVALIDCALL; Maybe we should add a FIXME within that if (FAILED(hr)), since that part is something which still needs to be implemented. Best regards, Tony

2 3

ImageCapture Wine TWAIN plug-in
by C.W. Betts 20 Apr '10

20 Apr '10

Anybody else up for the idea of an ImageCapture (Mac OS X) plug-in for Wine's TWAIN? It would fit the role of sane.ds and gphoto.ds, as it can both scan and access cameras. ImageCapture can also use Mac OS X TWAIN drivers.

1 0

Re: imm32: rework storage of thread default contexts
by André Hentschel 20 Apr '10

20 Apr '10

Hi Aric, You should have a second look at the Function heads in the tests (imm32.c). I doubt WINAPI should be used and the functions should be static. -- Best Regards, André Hentschel

2 1

Re: [2/2] dlls/shell32/tests: add some tests for ShellExecuteEx
by Greg Geldorp 20 Apr '10

20 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1612 Your paranoid android. === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === Timeout === W7PROX64 (Windows 7 Professional 64 bit) === shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

Re: [shell32/tests] Fix a test failure on Windows 2000
by Paul Vriens 20 Apr '10

20 Apr '10

On 04/19/2010 08:22 PM, Paul Vriens wrote: > Hi, > > NT4 and lower don't run these tests so maybe it should be "shell32 5.0 > and lower" instead of "Windows 2000". > > This one was reported by the testbot to wine-devel btw. > > Changelog > Fix a test failure on Windows 2000 > Please ignore this one. Nikolay will sent a better fix -- Cheers, Paul.

1 0

Future of the WWN
by Zachary Goldberg 19 Apr '10

19 Apr '10

Hey folks. I plan on releasing one WWN per Wine release which at a minimum will include a very short news section and the bugzilla/appdb stats. I will also be "crown sourcing" news via the Wine Wiki: http://wiki.winehq.org/RecentNewsQueue. If you would like to get a news article into the WWN please add your post there and please do not forget to add your name for attribution! Thanks, Zach

2 2

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Maarten Lankhorst 19 Apr '10

19 Apr '10

Hi Marcus, 2010/4/19 Marcus Meissner <meissner(a)suse.de>: > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps > in gcc. Not sure though.) Are you sure this is the case in win64 too? I'd assume that it would probably be 16 byte aligned there, since the first 4 arguments would be passed in registers and it could ensure stack alignment since they owned the abi from the start. If not it would definitely be 8. Cheers, Maarten

2 1

Re: winecfg: Add SP2 for Vista
by Austin English 19 Apr '10

19 Apr '10

2010/4/19 André Hentschel <nerv(a)dawncrow.de>: > Internet Explorer 9 Preview needs it. > --- > programs/winecfg/appdefaults.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c > index 8d28b0a..cf07fe8 100644 > --- a/programs/winecfg/appdefaults.c > +++ b/programs/winecfg/appdefaults.c > @@ -50,7 +50,7 @@ static const struct > { > { "win7", "Windows 7", 6, 1, 0x1DB0,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, > { "win2008", "Windows 2008", 6, 0, 0x1771,VER_PLATFORM_WIN32_NT, "Service Pack 1", 0, 0, "ServerNT"}, > - { "vista", "Windows Vista", 6, 0, 0x1770,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, > + { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, > { "win2003", "Windows 2003", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "ServerNT"}, > { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, > { "win2k", "Windows 2000", 5, 0, 0x893, VER_PLATFORM_WIN32_NT, "Service Pack 4", 4, 0, "WinNT"}, Please change dlls/ntdll/version.c to keep them in sync. -- -Austin

1 0

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
by Henri Verbeet 19 Apr '10

19 Apr '10

On 19 April 2010 09:43, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +BOOL is_pow2(UINT num) > +{ > + UINT i; > + > + if (!num) return FALSE; > + for (i = 0; num >> 1; i++) num >>= 1; > + > + return (num << i) == num; > +} This should at least be static. You can also just replace it with "return !(num & (num - 1));". You don't care about 0, since you already check that earlier in D3DXCheckTextureRequirements(). make_pow2() can probably be simplified as well.

4 5

ISP causes winhttp test failures
by Stefan Dösinger 19 Apr '10

19 Apr '10

Hi, I get winhttp test failures on all my machines: http://test.winehq.org/data/780981bc7a2c8e173bea580a2d748fd7cb242468/wine_s… I suspect my ISP is to blame. When try to resolve a nonexistant domain name I don't get an error, instead I get a search page: http://suche.upc.at/upcatassist/dnsassist/main/?domain=www.sreaverwdoc.moc $ ping www.sreaverwdoc.moc PING www.sreaverwdoc.moc (67.63.50.48): 56 data bytes Request timeout for icmp_seq 0 ... Verisign was once ordered not to this. But that was in the US. What should we do about this error? I don't think there's any way I can get a DNS error back from my stupid provider :-/ Stefan

6 8