April 2010 - Wine-devel - list.winehq.org

Re: [PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B
by Paul Vriens 19 Apr '10

19 Apr '10

On 04/16/2010 12:20 AM, Detlef Riekenberg wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 29 +++++++++++++++++++++-------- > 1 files changed, 21 insertions(+), 8 deletions(-) > Hi Detlef, After this patch none of the tests are actually run on W95B and we have loads of win_skip's. Wouldn't it be better to just check for one (or all) and bail out with a (only one) win_skip()? I guess if one is not present, none are? -- Cheers, Paul.

2 2

d3dx9: Add a stubbed D3DXDeclaratorFromFVF
by David Adam 19 Apr '10

19 Apr '10

Hi, patch from Tony Wasserka. A+ David

1 0

my god, it's full of benchmarks
by Dan Kegel 19 Apr '10

19 Apr '10

Turns out everybody and his brother are writing game benchmarks and game benchmark tools. There are a whole mess of them at http://downloads.guru3d.com/Benchmarks-&-Demo's_c6.html which I'll probably take a look at sometime soon. Has anyone been running any of these (beyond the obvious 3dmarkXX's) on Wine?

1 0

Crash when executing custom action in msi
by Octavian Voicu 18 Apr '10

18 Apr '10

Hello, I'm trying to get the Adobe Photoshop Elements 8.0 installer to work and noticed the license screen doesn't show up when running the installer using wine. A trace shows that a custom action (CA_EULA_ExtractEulaFiles) generates a page fault. The cause of the crash is that MsiGetActiveDatabase is called on a remote handle that is actually a database handle (not a package handle as expected). A simple proof of concept would be to call this from a custom action handler in a dll: MsiGetActiveDatabase(MsiGetActiveDatabase(hPackage)); MsiGetActiveDatabase will call msi_get_remote and cast the result to IWineMsiRemotePackage, then call IWineMsiRemotePackage_GetActiveDatabase. Because our handle is actually a database handle, instead of calling mrp_GetActiveDatabase, it will call mrd_GetPrimaryKeys. This leads to a crash (see attached log). The correct behavior for MsiGetActiveDatabase is to return 0 when called with an invalid handle. I made a patch for this (also attached). In order to check if the com object is actually an IWineMsiRemotePackage, I compare the IUnknown->lpVtbl pointer against msi_remote_package_vtbl. This looks a bit messy, but I found no other way to do it. I'm posting the patch here for review first. Octavian

2 2

Re: [3/3]usp10/tests: add Thaana itemize tests
by Greg Geldorp 18 Apr '10

18 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1558 Your paranoid android. === W98SE (Windows 98 Second Edition) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === W2KPROSP4 (Windows 2000 Professional SP4) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === WXPPROSP3 (XP Professional SP3 (English, IE6)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === WVISTAADM (Windows Vista (English, IE7)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W2K8SE (Server 2008 Standard Edition) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PRO (Windows 7 Professional (English, IE8)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel

1 0

Re: [PATCH 4/8] server: send the proper status code in case of socket error
by Greg Geldorp 18 Apr '10

18 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1520 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === sock.c:3162: Test failed: Expected event sequence [FD_OOB(0) bad(65)], got [FD_OOB(0)]

2 1

Benchmarking D3D?
by Dan Kegel 18 Apr '10

18 Apr '10

I've added four benchmarks to wisotool: 3dmark03 3D Mark 03 (Futuremark, 2003) 3dmark06 3D Mark 06 (Futuremark, 2006) re5bench Resident Evil 5 Benchmark (Capcom, 2009) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) Are there others worth using (besides, I suppose, 3dmark05)? (3dmark03 isn't working for me because I can't bypass the sysinfo crash, see http://bugs.winehq.org/show_bug.cgi?id=22392 )

6 10

Wine 2.0
by Remco 18 Apr '10

18 Apr '10

How about, instead of calling the next major release version 1.2, call it version 2.0? The reason is purely marketing: an x.0 number will attract more press. Last major release was 1.0. It seems fitting to have the next major release be 2.0. Besides, is there any reason to have multiple levels of "major releases"? I somehow doubt that a "2.0" can ever be justified if regular major releases use 1.x. -- Remco

3 2

(no subject)
by Oleg Krylov 17 Apr '10

17 Apr '10

http://IvanaKalmus0627.co.cc

1 0

Re: usp10/tests: add tests for CR and LF chars and remove some trailing white space
by Greg Geldorp 17 Apr '10

17 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1506 Your paranoid android. === W98SE (Windows 98 Second Edition) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2KPROSP4 (Windows 2000 Professional SP4) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WXPPROSP3 (XP Professional SP3 (English, IE6)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WVISTAADM (Windows Vista (English, IE7)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2K8SE (Server 2008 Standard Edition) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PRO (Windows 7 Professional (English, IE8)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16

2 1