April 2010 - Wine-devel - list.winehq.org

Re: Jacek Caban : jscript: Fixed String. match implementation for non-global regexps.
by Paul Chitescu 19 Apr '10

19 Apr '10

On Thursday 15 April 2010 07:37:36 pm Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 6f17fa5298449114a8532778b8a6c0f8a5c505de > URL: http://source.winehq.org/git/wine.git/?a=commit;h=6f17fa5298449114a8532778b… > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Thu Apr 15 12:38:38 2010 +0200 > > jscript: Fixed String.match implementation for non-global regexps. > > --- > > dlls/jscript/jscript.h | 1 + > dlls/jscript/regexp.c | 81 ++++++++++++++++++++++++++++++++++++++++++ > dlls/jscript/string.c | 59 +++++------------------------- > dlls/jscript/tests/regexp.js | 27 ++++++++++++++ > 4 files changed, 119 insertions(+), 49 deletions(-) This patch is somehow b0rked in CVS. regexp.c and tests/regexp.js were commited and then reverted. Is it possible to have them synched back to git? Thanks, Paul Chitescu

2 1

wine in press
by Stefan Leichter 19 Apr '10

19 Apr '10

Hi, while reading the german heise news i came across an article about wine. Luckily there is an english version too: http://www.h-online.com/open/news/item/Wine-update-improves-Direct3D-and-64… german version: http://www.heise.de/open/meldung/Wine-mit-verbesserter-3D-und-64-Bit-Unters… Bye Stefan

1 0

Re: winmm: Rewrite time.c using windows timer queues
by Alexandre Julliard 19 Apr '10

19 Apr '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -50,16 +33,14 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(mmtime); > > -typedef struct tagWINE_TIMERENTRY { > - struct list entry; > - UINT wDelay; > - UINT wResol; > - LPTIMECALLBACK lpFunc; /* can be lots of things */ > - DWORD_PTR dwUser; > - UINT16 wFlags; > - UINT16 wTimerID; > - DWORD dwTriggerTime; > -} WINE_TIMERENTRY, *LPWINE_TIMERENTRY; > +typedef struct { > + struct list entry; /* must be first item */ There's no reason that it needs to be the first item if you use the list macros correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] shlwapi: Implement SHCreateThreadRef
by Alexandre Julliard 19 Apr '10

19 Apr '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -120,6 +120,89 @@ typedef struct tagSHLWAPI_THREAD_INFO > IUnknown *refIE; /* Reference to the IE process */ > } SHLWAPI_THREAD_INFO, *LPSHLWAPI_THREAD_INFO; > > +typedef struct > +{ > + void* lpVtbl; > + LONG *ref; > +} threadref; You need to use correct pointer types, a vtbl is not a void*. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/6] msi: Add beginnings of a test module that concentrates on patches.
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1590 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === patch.c:696: Test failed: expected 1000, got 0 patch.c:709: Test failed: expected 1002, got 0

1 0

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Alexandre Julliard 19 Apr '10

19 Apr '10

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps > in gcc. Not sure though.) It needs to be the default in gcc. It's not specific to stdcall or to Wine, there's plenty of Linux code that doesn't align the stack either. gcc can't start generating code that assumes 16-byte alignment on Linux. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [8/11] shell32: Complete IFolderView::ItemCount() implementation
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1576 Your paranoid android. === WVISTAADM (Windows Vista (English, IE7)) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W2K8SE (Server 2008 Standard Edition) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PRO (Windows 7 Professional (English, IE8)) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PROX64 (Windows 7 Professional 64 bit) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PROX64 (Windows 7 Professional 64 bit) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000

1 0

Re: [5/11] shell32: Load shell folder column names as A/W strings depending on 9x/NT selector
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1574 Your paranoid android. === W2KPROSP4 (Windows 2000 Professional SP4) === shfldr_special.c:188: Test failed: got 0x80004001 shfldr_special.c:189: Test failed: got 2294136

1 0

TestBot changes
by Greg Geldorp 19 Apr '10

19 Apr '10

I've made a bunch of changes to TestBot, aimed at improving its reliability for processing wine-patches submissions and preventing false positives (where the bot incorrectly claims a patch introduces a new failure.) For the moment it won't send error reports directly to wine-devel, instead it sends them to me and I'll manually forward after checking. - Skip tests if required DLL is not available Previously, when running e.g. urlmon_test.exe on NT4, the test would fail to start if a statically imported DLL (urlmon.dll in the NT4 case) was not present on the system. Eventually the test would time out and this would be registered as a failure. The new behavior is to skip the test entirely and not treat it as a failure (this is the same behavior as that of winetest-latest.exe.) - Add support for programs tests We've had cmd tests in programs/cmd/tests for a while now, patches to these tests were not handled properly. This should be fixed now (and obviously not only for programs/cmd but for any test under programs/.) - Avoid false positives when comparing logs The bot tries to figure out whether new errors have been introduced by a patch. It does this by comparing the log generated by running the patched test against the log from the last winetest-latest.exe run. If there are new "Test failed" lines they will be flagged as new errors. When searching for these new lines, we have to disregard the source line numbers that are present in the log lines (log lines have the form "testfile.c:999: Test failed: Description"), since the source line numbers can easily change if the patch adds or removes lines near the start of the file. - Use both author email address and max patch number for set determination We discussed this last week, this should be an improvement but still does not catch all possible scenarios. - Run intermediate tests too When submitting a 4 part set, where part 2 and 3 contain changes to a test, we'd previously wait until all 4 parts were available, create one big patch file out of parts 1-4, apply that and run the tests. Now, we'll detect that part 2 contains a test change, apply 1-2 and run tests. Then when part 3 becomes available we detect that it too contains a test change, apply 1-3 and run tests again. More TestBot changes to come. Ge.

2 3

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Marcus Meissner 19 Apr '10

19 Apr '10

On Sun, Apr 18, 2010 at 04:28:54PM -0600, Charles Davis wrote: > On 4/18/10 4:17 PM, Marcus Meissner wrote: > > Hi, > > > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > > For MMX/SSE operations we however need to have the stack aligned > > to 16 (2^4). > > > > So specify this explicitly. > > > > (This should probably be even part of attribute((stdcall)) perhaps > > in gcc. Not sure though.) > From windef.h: > > # ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a > 4-byte one */ > # define __stdcall __attribute__((__stdcall__)) > __attribute__((__force_align_arg_pointer__)) > # else > # define __stdcall __attribute__((__stdcall__)) > # endif > > Maybe then it's time we got rid of the #ifdef __APPLE__ block, then, and > used the OS X definition everywhere? Or, we could use your switch, and > that would obviate the need for __force_align_arg_pointer__ with gcc > (but not clang, because it doesn't implement that switch yet). Hmm. Sounds like an idea. I will test and send a patch. Ciao, Marcus

1 0