May 2010 - Wine-devel - list.winehq.org

Steam hardware survey causing crashes (so next round of statistics will under-represent Wine users)
by Scott Ritchie 19 May '10

19 May '10

Just a small note but occasionally we hear from Valve about steam statistics and the percentage of Wine users. I just got a crash from running the survey. It makes me pretty unlikely to click the button again, even if it doesn't crash in the future. I imagine other users would feel similarly. This means we might be substantially underestimating Wine users if we use the Valve hardware survey as a basis. Last I remember we were at 0.4% or so, but that was over a year ago. Thanks, Scott Ritchie

2 1

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection
by Juan Lang 19 May '10

19 May '10

Hi Piotr, + if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( + res == ERROR_INTERNET_SEC_CERT_DATE_INVALID + || res == ERROR_INTERNET_INVALID_CA + || res == ERROR_INTERNET_SEC_CERT_NO_REV + || res == ERROR_INTERNET_SEC_CERT_REV_FAILED + || res == ERROR_INTERNET_SEC_CERT_REVOKED + || res == ERROR_INTERNET_SEC_INVALID_CERT + || res == ERROR_INTERNET_SEC_CERT_CN_INVALID)) + res = ERROR_INTERNET_SEC_CERT_ERRORS; I'm confused. Is there evidence that native does the same? This would be surprising to me, given the existence of INTERNET_OPTION_SECURITY_FLAGS to mask particular errors. When are you trying to accomplish with this patch? Tests would certainly help. Thanks, --Juan

2 2

Re: [PATCH 2/4] wininet: Added INTERNET_OPTION_ERROR_MASK flag handling to InternetSetOptionW
by testbot＠testbot.winehq.org 19 May '10

19 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2142 Your paranoid android. === W98SE (32 bit internet) === internet.c:969: Test failed: Retrieved proxy server should've been L"proxy.example", was: L"\0001\a000\2684X\0fb4h\0200" internet.c:975: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1003: Test failed: Retrieved flags should've been PROXY_TYPE_DIRECT, was: 5767180 internet.c:1006: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1033: Test failed: Retrieved flags should've been PROXY_TYPE_PROXY | PROXY_TYPE_DIRECT, was: 5767180 internet.c:1036: Test failed: Expected regtype to be REG_DWORD, was: 3 === W2KPROSP4 (32 bit internet) === Timeout

1 0

SONAME_LIBFONTCONFIG undeclared
by GOUJON Alexandre 18 May '10

18 May '10

Hi, I just updated my local tree and ran CFLAGS="-g -O0" ./configure --disable-tests && make and I got make[1]: Entering directory `/home/alex/Projects/wine/dlls/winex11.drv' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o xrender.o xrender.c xrender.c: In function 'X11DRV_XRender_Init': xrender.c:398: error: 'SONAME_LIBFONTCONFIG' undeclared (first use in this function) xrender.c:398: error: (Each undeclared identifier is reported only once xrender.c:398: error: for each function it appears in.) xrender.c:401: error: 'pFcConfigSubstitute' undeclared (first use in this function) xrender.c:402: error: 'pFcDefaultSubstitute' undeclared (first use in this function) xrender.c:403: error: 'pFcFontMatch' undeclared (first use in this function) xrender.c:404: error: 'pFcInit' undeclared (first use in this function) xrender.c:405: error: 'pFcPatternCreate' undeclared (first use in this function) xrender.c:406: error: 'pFcPatternDestroy' undeclared (first use in this function) xrender.c:407: error: 'pFcPatternAddInteger' undeclared (first use in this function) xrender.c:408: error: 'pFcPatternAddString' undeclared (first use in this function) xrender.c:409: error: 'pFcPatternGetInteger' undeclared (first use in this function) xrender.c:411: error: 'fontconfig_installed' undeclared (first use in this function) xrender.c:411: warning: implicit declaration of function 'pFcInit' xrender.c:413: error: expected ')' before 'SONAME_LIBFONTCONFIG' make[1]: *** [xrender.o] Error 1 make[1]: Leaving directory `/home/alex/Projects/wine/dlls/winex11.drv' make: *** [dlls/winex11.drv] Error 2 Is anyone else experiencing this ?

3 4

Re: ntdll: add stub for NtRaiseHardError (try 2)
by Reece Dunn 18 May '10

18 May '10

On 18 May 2010 19:17, Austin English <austinenglish(a)gmail.com> wrote: > This time returning STATUS_NOT_IMPLEMENTED instead of E_NOTIMPL, to > match the rest of ntdll. Thanks to Juan for pointing that out. > > -- > -Austin Patch? - Reece

1 0

Re: ntdll: add stub for NtRaiseHardError
by Juan Lang 18 May '10

18 May '10

Hi Austin, + return E_NOTIMPL; I'm thinking this should return STATUS_NOT_IMPLEMENTED instead. --Juan

2 1

Nightly performance regression graphs
by Dan Kegel 18 May '10

18 May '10

I finally threw together some graphs, see http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html Not sure what to make of the results yet. They use svg, so a modern browser is required.

5 6

Re: setupx.dll16: Fix error handling in VCP_VirtnodeCreate. (RETRY)
by Alexandre Julliard 18 May '10

18 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This was not applied and I also did not see any feedback (and even > checked the list archives) so I am resending it. If you are going to return an error you have to handle the error properly and free the data structures etc. It's not clear that this is the right thing to do though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] wininet: Fix error handling in HTTP_HttpSendRequestW
by Alexandre Julliard 18 May '10

18 May '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/wininet/http.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:2692: Test failed: 2780: expected status 21 got 30 http.c:2692: Test failed: 2780: expected status 30 got 31 http.c:2692: Test failed: 2780: expected status 31 got 100 http.c:2692: Test failed: 2797: expected status 100 got 30 http.c:2693: Test failed: 2797: expected function 3 got 4 http.c:2696: Test failed: 2797: expected thread 68 got 68 http.c:2692: Test failed: 2797: expected status 30 got 31 http.c:2692: Test failed: 2811: expected status 31 got 40 http.c:2693: Test failed: 2811: expected function 4 got 5 http.c:2692: Test failed: 2819: expected status 40 got 41 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2692: Test failed: 2819: expected status 41 got 100 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2692: Test failed: 2819: expected status 100 got 50 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2701: Test succeeded inside todo block: 2819: expected status 70 got 70 http.c:2703: Test succeeded inside todo block: 2819: expected function 6 got 6 make[1]: *** [http.ok] Error 17 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Nightly performance regression graphs
by Dan Kegel 18 May '10

18 May '10

On Tue, May 18, 2010 at 3:07 AM, Scott Ritchie <scott(a)open-vote.org> wrote: > > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > What tool are you using to make them? gnuplot. The script (if you can call it that) I use is at http://code.google.com/p/winezeug/source/browse/trunk/yagmark-plot.sh > I recommend cairoplot, it's the tool I used in the model I made here: > http://yokozar.org/blog/archives/48 > > It outputs svgs just the same, but is nice and pretty and pythonic. We > could then script interesting things automatically, such as having the > chart automatically use the previous max benchmark as its first or > second node. I'll improve what I've got a bit, but at the moment I don't see a reason to switch away from gnuplot. - Dan

2 1