May 2010 - Wine-devel - list.winehq.org

Re: kernel32/tests: Remove variable len which is not really used from test_CommandLine.
by testbot＠testbot.winehq.org 05 May '10

05 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1901 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Alexandre Julliard 05 May '10

05 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). It's very unlikely that we'd want to use red and green but not blue... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Henri Verbeet 05 May '10

05 May '10

On 5 May 2010 00:24, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). > It probably should be used. At first sight it looks like that's not the only issue with that function though.

1 0

Trying again
by Joakim Tjernlund 05 May '10

05 May '10

This didn't show up in the archives, so trying again. >From 7882df972ec827f0e7b7b622c01be2644e54d122 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> Date: Mon, 3 May 2010 20:30:32 +0200 Subject: [PATCH] RegisterWaitForSingleObject() fix special tmo == 0 case. At http://msdn.microsoft.com/en-us/library/aa332406%28VS.71%29.aspx one can read: "If the timeOutInterval parameter is not zero (0) and the executeOnlyOnce parameter is false, the timer is reset every time the event is signaled or the time-out interval elapses." timeOutInterval == 0 makes the above false and the timer should NOT be reset, fix that. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> --- dlls/ntdll/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..f6c9fb4 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -377,7 +377,8 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); wait_work_item->CallbackInProgress = FALSE; - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

2 1

What is the point of mincore() in reserve_area() in libs/wine/mmap.c?
by Johann "Myrkraverk" Oskarsson 05 May '10

05 May '10

Hi all, In the Solaris/BSD implementation of reserve_area() in libs/wine/mmap.c there is for (i = 0; i < size; i += pagesize) if (mincore( (caddr_t)addr + i, pagesize, &vec ) != -1) break; &vec is never used again in that function. What is the point of mincore() ? I'm looking at this in reference to bug 22033. Johann

3 2

Re: user32/tests: Remove variable hdata which is not really used from test_initialisation.
by testbot＠testbot.winehq.org 05 May '10

05 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1902 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 14 error(s) dde.c:2040: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: RegisterWaitForSingleObject() fix special tmo == 0 case.
by Charles Davis 04 May '10

04 May '10

On 5/4/10 12:06 AM, Joakim Tjernlund wrote: > > Here are two versions Generally, it's a bad idea to put two patches in one mail. You should instead have two separate emails, one for each patch. Chip

1 0

Re: [PATCH 1/2] tools: Added a script to build BMPs from SVGs
by Alexandre Julliard 04 May '10

04 May '10

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > Make.rules.in | 5 +-- > tools/buildbitmap | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 92 insertions(+), 3 deletions(-) > create mode 100755 tools/buildbitmap This could go in the buildicon script, most of the code is the same. -- Alexandre Julliard julliard(a)winehq.org

1 0

Winebuild b0rken on Mac OS X?
by Charles Davis 04 May '10

04 May '10

While building Wine (latest git) on Mac OS X, I noticed this: /usr/bin/nm: object: amstream_test.MDsdpi.o malformed object (LC_SEGMENT command 0 filesize field greater than vmsize field) Undefined symbols: "_GetDesktopWindow", referenced from: _func_amstream in amstream.o "_TlsGetValue", referenced from: _get_tls_data in testlist.o "_MultiByteToWideChar", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_CloseHandle", referenced from: _func_amstream in amstream.o "_TlsSetValue", referenced from: _get_tls_data in testlist.o "_DirectDrawCreate", referenced from: _func_amstream in amstream.o "_CoCreateInstance", referenced from: _create_ammultimediastream in amstream.o "_WaitForSingleObject", referenced from: _winetest_wait_child_process in testlist.o "_CoInitializeEx", referenced from: _func_amstream in amstream.o "_HeapAlloc", referenced from: _get_tls_data in testlist.o "_CoUninitialize", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_GetExitCodeProcess", referenced from: _winetest_wait_child_process in testlist.o "_GetEnvironmentVariableA", referenced from: _main in testlist.o _main in testlist.o _main in testlist.o _main in testlist.o "_ExitProcess", referenced from: _exit_process in testlist.o ___wine_spec_exe_entry in libwinecrt0.a(exe_entry.o) "_CreateFileA", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_TlsAlloc", referenced from: _run_test in testlist.o ld: symbol(s) not found collect2: ld returned 1 exit status winegcc: gcc failed make[1]: *** [amstream_test.exe.so] Error 2 make: *** [dlls/amstream/tests] Error 2 Something's gone horribly wrong. Winebuild shouldn't be generating b0rken Mach-O files. What gives?

2 3

Re: [12/13]docs/wineusr: unix paths are supported
by Austin English 04 May '10

04 May '10

2010/5/4 André Hentschel <nerv(a)dawncrow.de>: > --- > en/wineusr-running.sgml | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/en/wineusr-running.sgml b/en/wineusr-running.sgml > index f36383f..106be37 100644 > --- a/en/wineusr-running.sgml > +++ b/en/wineusr-running.sgml > @@ -90,8 +90,8 @@ Usage: wine PROGRAM [ARGUMENTS...] Run the specified program > in the <parameter>Path</parameter> environment variable, you can > simply give the executable file name. However, if the executable > is not in <parameter>Path</parameter>, you must give the full path to > - the executable (in Windows format, not UNIX format!). For > - example, given a <parameter>Path</parameter> of the following: > + the executable. For example, given a <parameter>Path</parameter> > + of the following: > </para> > <screen> > Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > @@ -112,7 +112,11 @@ Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > </screen> > <para> > (note the backslash-escaped "\" !) > + or: > </para> > + <screen> > +<prompt>$</prompt> <userinput>wine ~/.wine/drive_c/myapps/foo.exe</userinput> > + </screen> > <para> > For details on running text mode (CUI) executables, read the > <link linkend="CUI-programs">section</link> below. > -- A lot of programs break when using Unix paths. I don't think we should encourage it. Perhaps instead put an example using wine start /unix. -- -Austin

2 1