May 2010 - Wine-devel - list.winehq.org

Compilation failure in wine-1.1.44
by wylda＠volny.cz 09 May '10

09 May '10

Hi guys, i can't compile wine-1.1.44 (1.1.43 is OK here like all the ones before)... As i guess you would not release a wine, which can't be compiled, than i suspect there could be a trouble in my system (Debian Lenny 32bit). For this reason, i did not bother to fill a bug ;) as it would be marked invalid... Any suggestion? I wanted to give some bugs a retest, but i'm stuck ;) ... make[2]: Leaving directory `/home/pavel/install/wine/src/wine-1.1.44/tools' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o config.o ./config.c -DBINDIR='"/usr/local/bin"' -DDLLDIR='"/usr/local/lib/wine"' -DLIB_TO_BINDIR=\"`../../tools/relpath /usr/local/lib /usr/local/bin`\" -DLIB_TO_DLLDIR=\"`../../tools/relpath /usr/local/lib /usr/local/lib/wine`\" -DBIN_TO_DLLDIR=\"`../../tools/relpath /usr/local/bin /usr/local/lib/wine`\" -DBIN_TO_DATADIR=\"`../../tools/relpath /usr/local/bin /usr/local/share/wine`\" gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o cptable.o cptable.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o debug.o debug.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o fold.o fold.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o ldt.o ldt.c {standard input}: Assembler messages: {standard input}:1472: Error: symbol `wine_get_fs' is already defined {standard input}:1502: Error: symbol `wine_set_fs' is already defined make[1]: *** [ldt.o] Error 1 make[1]: Leaving directory `/home/pavel/install/wine/src/wine-1.1.44/libs/wine' make: *** [libs/wine] Error 2

7 9

Re: gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1981 Your paranoid android. === W98SE (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WNT4WSSP6 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2KPROSP4 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WXPPROSP3 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2K3R2SESP2 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WVISTAADM (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2K8SE (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W7PRO (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W7PROX64 (64 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559

1 0

Wine should warn when ulimit -n needs raising
by Octavian Voicu 09 May '10

09 May '10

I was looking at http://bugs.winehq.org/show_bug.cgi?id=19861 and it seemed pretty easy to fix. In my opinion, the warning should either go in server/file.c - file_set_error() or in server/fd.c - open_fd(). open_fd() is pretty much the only place where open() is called, so it's a good candidate. On the other hand, having the check in file_set_error() might detect the condition in more instances, but it might also impact performance (file_set_error() is called really often; having lots of code in one branch might make the compiler generate slower code). The warning would go on the ENFILE/EMFILE branches, and maybe also print the value of getrlimit(RLIMIT_NOFILE) and suggest a fix (editing /etc/security/limits.conf). Octavian

2 2

Re: shdocvw: implement IWebBrowser2::get_LocationName
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1977 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1236: Test failed: unexpected call UpdateUI webbrowser.c:315: Test failed: unexpected nsCmdID 21 webbrowser.c:259: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2497: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2497: Test failed: CoCreateInterface failed: 80040154

1 0

Re: wined3d: Make forced reading of a byte in flush_to_framebuffer_drawpixels more reliable.
by Stefan Dösinger 09 May '10

09 May '10

I think this should be removed entirely. I added it in 2005 because Mesa back then choked on our protected memory(X server freeze or kernel panic). Around 2008 I checked if this bug still exists, and it seems to be fixed. If anyone still runs into this bug he should seriously consider upgrading his Mesa installation... Am 07.05.2010 um 23:20 schrieb Gerald Pfeifer: > Looking at the current code in flush_to_framebuffer_drawpixels it occurs > to me that we really need to mark the memory we want to _read_ volatile, > not the local variable that is used to "force" reading said memory. > > That is more direct, more logical, and even more efficient. > > Looking at the generated code of all of dlls/wined3d/surface.c the > only material difference is > > movb %al, -25(%ebp) > > which is saving the byte we are trying to read onto the stack and into > the local variable. And that is the part that indeed is not necessary. > > Gerald > > --- > dlls/wined3d/surface.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index bb18b95..199a1bd 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -1839,8 +1839,7 @@ static void flush_to_framebuffer_drawpixels(IWineD3DSurfaceImpl *This, GLenum fm > * ReleaseDC, and the app won't use the dc any more afterwards. > */ > if((This->Flags & SFLAG_DIBSECTION) && !(This->Flags & SFLAG_PBO)) { > - volatile BYTE read; > - read = This->resource.allocatedMemory[0]; > + *(volatile BYTE*)This->resource.allocatedMemory; > } > > if(This->Flags & SFLAG_PBO) { > -- > 1.6.6.2 >

1 0

Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1970 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

Re: [PATCH] ntdll: Reimplement qsort() using generic mergesort
by Vincent Pelletier 09 May '10

09 May '10

Le dimanche 09 mai 2010 13:09:47, Marcus Meissner a écrit : > As __cdecl (for the compare function) is not the UNIX cdecl in Win64 > anymore, we need to reimplement sort to call the right comparator > functions. Not that it's important, but that reminded me of this: http://docs.python.org/library/ctypes.html#callback-functions (scroll a bit for qsort example on windows vs. linux) It would be interesting (though probably futile) to see how this code behaves. -- Vincent Pelletier

1 0

re: Release plans
by Dan Kegel 09 May '10

09 May '10

Tom Wickline wrote: >> http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu… > > Three releases to fix 88 nasty bugs? The sad fact is that it would take a lot more than that to fix them all, and it probably doesn't make sense to hold up the release until it's perfect. We probably want to update http://wiki.winehq.org/WineReleaseCriteria with the current release criteria. Some other interesting searches: Bugs marked as 'regression' (340!): http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu… Bugs marked 'bisected': http://bugs.winehq.org/buglist.cgi?quicksearch=bisected Anything A.F. has analyzed : http://bugs.winehq.org/buglist.cgi?product=Wine&bug_status=UNCONFIRMED&bug_… - Dan

6 9

RFC kernel32: add test for FindFirstFileA with a path ending with "/>"
by Vincent Pelletier 09 May '10

09 May '10

This test passes on win2k & winxp, fails on wine. That failure causes cdkey verification problems in "Earth 2160" as sold on GOG.com: Once the installation is finished, the installers generates a registry key value based (among other things) on the ctime of installed directory. Looked-up path has trailing "/>", causing the registry key to be incorrect and the game rejects it. I have no idea how to solve this error at the moment, nor the whole set of acceptable path trails. Please advise me if you have insight on this, and I'll see if I can fix it. This is the reason why I didn't add a todo_wine in the test. --- dlls/kernel32/tests/file.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)

2 3

Re: shell32/tests: Remove variable res which is not really used from init_strings.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1972 Your paranoid android. === W2KPROSP4 (32 bit progman_dde) === progman_dde.c:442: Test failed: CreateGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [C_G:2] === W2K3R2SESP2 (32 bit progman_dde) === progman_dde.c:507: Test failed: DeleteGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:13] progman_dde.c:587: Test failed: Compound String [CreateGroup(Group3)][AddItem(C:\WINDOWS\TEMP\dde14.tmp,f1g3Name)][AddItem(C:\WINDOWS\TEMP\dde15.tmp,f2g3Name)]: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [CPD:14] progman_dde.c:507: Test failed: DeleteGroup Group3: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:15] === W7PRO (32 bit progman_dde) === progman_dde.c:369: Test failed: Window "Group1" was not created in 45 seconds - assumed failure. [S_G:12]

1 0