May 2010 - Wine-devel - list.winehq.org

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum <henry.blum@gmail.com>
by Charles Davis 09 May '10

09 May '10

On 5/7/10 11:10 PM, Henry Blum wrote: > - if (status != STATUS_SUCCESS) > + if (status != STATUS_SUCCESS || (access & PROCESS_VM_WRITE)) According to this, opening a process and specifying the PROCESS_VM_WRITE access right causes OpenProcess() to fail. Why do you need this? And what about programs that legitimately need to write to another process's VM? Chip

1 0

Re: [2/2] gdiplus: Implement GdipGetImageThumbnail.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1960 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: [1/2] gdiplus: Add test for GdipGetImageThumbnail.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1959 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: user32: Fix selected brush color for caret bitmap creation
by Nikolay Sivov 08 May '10

08 May '10

On 5/8/2010 22:20, Nikolay Sivov wrote: > Fixes bug 1733. > > Selected brush color should depend on current window color or other system settings, it just inverts hdc colors. (should -> shouldn't)

1 0

Re: gdiplus: Implement bitmap color keying.
by testbot＠testbot.winehq.org 08 May '10

08 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1955 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.
by Jacek Caban 08 May '10

08 May '10

Hi Gerald, On 5/2/10 9:16 PM, Gerald Pfeifer wrote: > IActiveScriptSite_OnStateChange is described to return S_OK upon > success, so instead of ignoring its return value and unconditionally > returning S_OK it strikes me that we should return its result instead. > In this case returning S_OK is fine, but there is missing test for OnStateChange return value. Jacek

2 2

Re: mshtml: Fix return type value for HTMLBodyElement_put_text.
by Jacek Caban 08 May '10

08 May '10

On 5/8/10 1:07 PM, Gerald Pfeifer wrote: > The current code does not handle an error coming out of > nsIDOMHTMLBodyElement_SetText and actually discards whatever nsres > is set to. > > Jacek, is a patch like this okay, should we just remove nsres, or > is it more complicated than that? > We can't mix nsresult with HRESULT. We should check for failure and return something like E_FAIL (and preferably print an error, there is something seriously wrong if SetText fails). Thanks, Jacek

1 0

Re: Add tests for ImageGetDigestStream
by testbot＠testbot.winehq.org 08 May '10

08 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1950 Your paranoid android. === W7PROX64 (64 bit image) === image.c:324: Test failed: ImageGetDigestStream failed: 87 image.c:187: Test failed: flags = 0: expected 7 updates, got 3 image.c:194: Test failed: flags = 0, update 2: unexpected value image.c:187: Test failed: flags = CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO: expected 5 updates, got 3 image.c:194: Test failed: flags = CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO, update 2: unexpected value

1 0

Re: gdi32/tests: Remove two variables which are not really used from test_clipping.
by Nikolay Sivov 07 May '10

07 May '10

On 5/3/2010 03:48, Gerald Pfeifer wrote: > --- > dlls/gdi32/tests/bitmap.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index 882d548..b570a8a 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -2810,9 +2810,7 @@ static void test_GdiAlphaBlend(void) > static void test_clipping(void) > { > HBITMAP bmpDst; > - HBITMAP oldDst; > HBITMAP bmpSrc; > - HBITMAP oldSrc; > HRGN hRgn; > LPVOID bits; > BOOL result; > @@ -2830,11 +2828,9 @@ static void test_clipping(void) > > bmpDst = CreateDIBSection( hdcDst,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 ); > ok(bmpDst != NULL, "Couldn't create destination bitmap\n"); > - oldDst = SelectObject( hdcDst, bmpDst ); > > bmpSrc = CreateDIBSection( hdcSrc,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 ); > ok(bmpSrc != NULL, "Couldn't create source bitmap\n"); > - oldSrc = SelectObject( hdcSrc, bmpSrc ); > > result = BitBlt( hdcDst, 0, 0, 100, 100, hdcSrc, 100, 100, SRCCOPY ); > ok(result, "BitBlt failed\n"); > Bitmap are useless after this change.

2 2

mciseq: Prevent busy-wait while paused.
by Joerg-Cyril.Hoehle＠t-systems.com 07 May '10

07 May '10

Hi, any comment on that patch? It's currently the bottommost in source.winehq.org/patches hence may fall into the bitbucket anytime. I had noticed that the MCI MIDI player would busy loop while paused because of a while(xyz) ; statement therein. Test it using these MCI commands open c:\data\foo.mid alias m play m pause m So I simply added a Sleep() and wrote: >7 ms is arbitrary. It allows to sleep well yet be responsive enough >so the app doesn't wait too long should the next command be MCI_Stop. >For the ear, an even larger sleep would be good enough. Sleep is a sort of stop gap until someone invents a notification/setEvent/Resume patch or whatever would be TRT. Regards, Jörg Höhle

2 3