June 2010 - Wine-devel - list.winehq.org

Re: avifil32: Update English resource
by Alexandre Julliard 15 Jun '10

15 Jun '10

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE > IDS_AVIFILETYPE "Wine AVI-default-filehandler" > IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate them. Also you should never submit 60 patches in one go; 10-15 is the maximum for a patch series, and that's only if you are absolutely confident that they are correct. Otherwise send only a couple until you are sure to get it right on the first try. -- Alexandre Julliard julliard(a)winehq.org

5 9

Gcov and PGO
by Peter Davies 15 Jun '10

15 Jun '10

After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRACFLAGS=-fprofile-generate LDFLAGS=-fprofile-generate" Run sample program (test suite is inappropriate because it doesn't represent normal usage). Run "make clean" Run "make EXTRACFLAGS=-fprofile-use LDFLAGS=-fprofile-use" Peter

1 0

Re: propsys: mention that the functions are stubs
by Hans Leidekker 15 Jun '10

15 Jun '10

On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > Hans might have missed that No, to me a fixme that prints a parameter list without further explanation implies that the function is a stub.

5 8

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler
by testbot＠testbot.winehq.org 15 Jun '10

15 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.
by Alexandre Julliard 15 Jun '10

15 Jun '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT notification, UINT_PTR param1, UINT_PTR param2 ) > { > + static int has_extracted; > + This is not reentrant. Also you need to point out which bugs these patches are fixing that justifies putting them in during code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Changes to enable the use of gcov
by James McKenzie 15 Jun '10

15 Jun '10

Peter Davies wrote: > To use gcov you must pass --coverage at both compile and link time. > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test", > "gcov file.c" is sufficient generate .gcov files. > > Peter: Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? James McKenzie

3 2

New Wine stuff in FreeWear.org
by Ismael Barros² 15 Jun '10

15 Jun '10

Hello, We have decided to renew our offer of Wine T-shirts, as the current T-shirt has had mostly no success at all, probably because users don't feel identified nor appealed with the design. I'm attaching the pdf with our new proposals (we hope you like them!). We decided to offer the design in black garment, as in our experience it works much better. We want to be transparent, so I'm attaching also a spreadsheet with our expenses, donations and profits for each model. We usually collaborate with FOSS events, sending them stuff from our catalogue for its sale on the event. In these cases, we make a double donation: one to the organization of the event (higher, as they are in charge of the sales) and another one to the corresponding FOSS organization for the sold article. You can see the details in the spreadsheet. If you have no objection, we'll send Wine stuff to the event that require it. Currently, almost all organizations we work with have us linked from their website. This helps boosting the sales, and therefore the donations, so that everybody wins. We would be very glad if we could get a link somewhere at winehq.org, or alternatively a news item, which for us has the downside of having a limited front-page life-span, but works nonetheless. We hope you like and approve the design. Suggestions are welcome. When the design is approved, we'll upload it to our website. Kind regards, Ismael

2 2

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it
by Alexandre Julliard 15 Jun '10

15 Jun '10

Marcus Meissner <marcus(a)jet.franken.de> writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is, it doesn't really prove anything. Also please use sizeof and friends instead of hardcoded numbers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Updating the 1.2 release announcement text
by Dan Kegel 15 Jun '10

15 Jun '10

http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

4 4

Re:Anotated 'make test' log
by Max TenEyck Woodbury 15 Jun '10

15 Jun '10

Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to start, so I started at the top of the log. I expect that to change once I become more sure that I have the mechanics correct. There are several things I'm trying to do. First is to find the place where each 'bit of noise' is generated. I seem to be doing that right. Then I look at why the noise was generated and to show that I've understood why, I wrote a note on how the 'noise' could be turned off without changing the test. I labelled these 'fixup:'. I then looked at the test code and added 'Note:'s where I thought the test could be improved. > While that's a noble quest, and I'd like to encourage people > to improve the tests, it might be more productive to do so > around areas of pain for users. > For instance, you could look at bugs in bugzilla that have > patches attached that aren't committed yet because tests are > needed, and write those tests. > - Dan That sounds useful. I also have a few issues I'd like fixed too. However, it's been more than five years since I've done serious coding; things happened that destroyed my self-confidence. A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

1 0