June 2010 - Wine-devel - list.winehq.org

WINE and demoscene products
by Wolfram Sang 12 Jun '10

12 Jun '10

Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine 1.2-rc2 was recently posted here [2]. Out of 25, 14 are flawless and 4 OK - pretty good numbers IMO. (BTW the demos can be downloaded using the search function of the website.) Regards, Wolfram [1] http://en.wikipedia.org/wiki/Demo_%28computer_programming%29 [2] http://pouet.net/topic.php?which=7400

1 0

Test suite success rate
by Peter Davies 11 Jun '10

11 Jun '10

How do I get the test suite to report it success rate (as a whole) in a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. Peter

3 2

Re: gdi32: Add CreateFontIndirectEx implementation (try2)
by Alexandre Julliard 11 Jun '10

11 Jun '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try2: function body moved to *Ex call, and CreateFontIndirect use it. You should also print FIXMEs if the ignored data is used by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

No test summary line found
by GOUJON Alexandre 11 Jun '10

11 Jun '10

Hi, I'm wondering if my patch (62325) hasn't been reviewed yet or if you expect a strict error-free patch. Indeed, http://source.winehq.org/patches/data/62325.testfail shows a "No test summary line found" for WNT4WSSP6. If it's an issue, how to fix it ? Thanks

2 6

Re: [PATCH 2/5] include: Add IEnumShellItems interface declaration.
by Huw Davies 11 Jun '10

11 Jun '10

On 11 Jun 2010, at 12:17, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/actxprxy/usrmarshal.c | 21 +++++++++++++++++++++ > include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/dlls/actxprxy/usrmarshal.c b/dlls/actxprxy/usrmarshal.c > index f2aacf8..85e534c 100644 > --- a/dlls/actxprxy/usrmarshal.c > +++ b/dlls/actxprxy/usrmarshal.c > + > +HRESULT CALLBACK IEnumShellItems_Next_Proxy( > + IEnumShellItems *This, > + ULONG celt, > + IShellItem **rgelt, > + ULONG *pceltFetched) > +{ > + TRACE("(%p)\n", This); > + return IEnumShellItems_RemoteNext_Proxy( This, celt, rgelt, > pceltFetched ); > +} pceltFetched could be a NULL ptr here, so you should pass the address of a local variable in that case. See ole32/usrmarshal.c for examples on how to marshal IEnum*_Next Huw.

1 0

Re: Updating Ukrainian translations to kernel32
by Dmitry Timoshkov 11 Jun '10

11 Jun '10

Igor Paliychuk <igor-hkr(a)mail.ru> wrote: > Updating Ukrainian translations to kernel32(ukr.nls). > file : ukrainian-kernel32-ukr-nls.patch You forgot to mention what's wrong with current ukr.nls. -- Dmitry.

2 1

Re: gdi32: CreateFontIndirectEx implementation on top of CreateFontIndirect
by Alexandre Julliard 11 Jun '10

11 Jun '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From fb4317a2a39475c225fe04946795892c4891cd26 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Fri, 11 Jun 2010 01:42:06 +0400 > Subject: [PATCH] CreateFontIndirectEx implementation on top of CreateFontIndirect It should of course be the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()
by Andrew Nguyen 11 Jun '10

11 Jun '10

On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23003 > > -- > -Austin > > > > You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.

3 5

IDL trouble (patch: adding IEnumShellItems interface declaration.)
by David Hedberg 11 Jun '10

11 Jun '10

Hello everyone, I'm having some trouble with this simple patch. Specifically, it breaks compiling of dlls/actxprxy, producing the message: ***** ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./actxprxy.spec usrmarshal.o actxprxy_activscp_p.o actxprxy_comcat_p.o actxprxy_docobj_p.o actxprxy_hlink_p.o actxprxy_htiframe_p.o actxprxy_objsafe_p.o actxprxy_ocmm_p.o actxprxy_servprov_p.o actxprxy_shobjidl_p.o actxprxy_urlhist_p.o dlldata.o -o actxprxy.dll.so -luuid -loleaut32 -lole32 -lrpcrt4 -lkernel32 -lntdll ../../libs/port/libwine_port.a -L/usr/local/valgrind-svn/lib actxprxy_shobjidl_p.o: In function `IEnumShellItems_RemoteNext_Stub': /home/david/Projects/wine/git/dlls/actxprxy/actxprxy_shobjidl_p.c:6507: undefined reference to `IEnumShellItems_Next_Stub' actxprxy_shobjidl_p.o:(.data.rel.ro+0xf0): undefined reference to `IEnumShellItems_Next_Proxy' ***** It compiles if I remove the [call_as] attribute, but I guess that would kind of break the interface. Any obvious mistakes in the patch, or grammar not supported by widl? Thanks, David --- include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 6bd0244..97cd82f 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -385,6 +385,36 @@ typedef enum tagNWMF { } NWMF; /***************************************************************************** + * IEnumShellItems interface + */ +[ + object, + uuid(70629033-E363-4A28-A567-0DB78006E6D7), + pointer_default(unique) +] +interface IEnumShellItems : IUnknown +{ + [local] HRESULT Next( + [in, annotation("__in")] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched), annotation("__out_ecount_part(celt, *pceltFetched)")] + IShellItem **rgelt, + [out, annotation("__out_opt __deref_out_range(0, celt)")] ULONG *pceltFetched); + + [call_as(Next)] HRESULT RemoteNext( + [in] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched)] IShellItem **rgelt, + [out] ULONG *pceltFetched); + + HRESULT Skip( + [in] ULONG celt); + + HRESULT Reset(); + + HRESULT Clone( + [out] IEnumShellItems **ppenum); +} + +/***************************************************************************** * FOLDERSETTINGS */ typedef char *LPVIEWSETTINGS; -- 1.7.1

2 1

Re: Three year sever outstanding bug requiring minor fix
by James Mckenzie 11 Jun '10

11 Jun '10

velociraptor Genjix <aphidia(a)hotmail.com> wrote at Jun 9, 2010 8:52 AM > >Hey, >Please look into this issue, >http://bugs.winehq.org/show_bug.cgi?id=15118 >It seems like a fairly trivial fix which renders this application useless. A detailed >description of the implementation needed is provided in that ticket. If it were a 'trival' fix, it would have been a long time ago. Something that looks, on the surface, to be simple, maybe very complex. For instance, I have been working on a fix for one function in the richedit area has taken over four years. Now as to your concern, tough. This project, for the most part is volunteer. So, if you want it fixed, do it yourself or find someone who can. Otherwise, you'll have to wait for someone to come by, find this interesting and then fix it. There is a part of the project that is paid, and they work for a company called CodeWeavers. Maybe they have found a fix and incorporated it into their product line. That you'll have to pay for. Remember, we fix things as WE find the time and the incorporation process is very strict. This takes time and some folks will pick up a project, only to set it down because they become busy with other things in life or they just don't have the tenancity to see it through. James McKenzie

2 1