July 2010 - Wine-devel - list.winehq.org

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.
by James McKenzie 25 Jul '10

25 Jul '10

Max TenEyck Woodbury wrote: > --- > dlls/ntdll/file.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 0a6ee55..86c200f 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2148,6 +2148,11 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, PIO_STATUS_BLOCK io, > io->u.Status = STATUS_INVALID_PARAMETER_3; > break; > > + /* Invalid requests - do not need 'fixing'. */ > + case FileAllInformation: > + io->u.Status = STATUS_NOT_IMPLEMENTED; > + break; > + > default: > FIXME("Unsupported class (%d)\n", class); > io->u.Status = STATUS_NOT_IMPLEMENTED; > Max: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when this call is made? If not, your fix is WRONG. Silencing a 'fixme' is NOT a fix and this will be REJECTED. If this is correct and is what Windows does, then state so. Otherwise, withdraw the patch and fix it the right way. James McKenzie

4 6

Re: [PATCH 2/2] dlls/ntdll/file.c: Return a different status code.
by Ricardo Filipe 25 Jul '10

25 Jul '10

2010/7/25 Max TenEyck Woodbury <max(a)mtew.isa-geek.net>: > --- > dlls/ntdll/file.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 86c200f..c32baa0 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2150,7 +2150,7 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, PIO_STATUS_BLOCK io, > > /* Invalid requests - do not need 'fixing'. */ > case FileAllInformation: > - io->u.Status = STATUS_NOT_IMPLEMENTED; > + io->u.Status = STATUS_INVALID_INFO_CLASS; > break; > > default: > -- > 1.7.1.1 > > > > your first patch has not been accepted yet. you should just make a try 2 of the first patch with the correct return code instead of a new patch correcting the first.

1 0

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.
by James McKenzie 25 Jul '10

25 Jul '10

Max TenEyck Woodbury wrote: > On 07/25/2010 01:55 PM, James McKenzie wrote: >> Andrew Eikum wrote: >>> On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: >>>> On 07/25/2010 09:45 AM, James McKenzie wrote: >>>>> I think you missed what Nicolay and Dmitry are trying to tell you. >>>>> We are trying to implement, bug for bug, the functionality of what >>>>> Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when this >>>>> call is made? If not, your fix is WRONG. Silencing a 'fixme' is NOT a >>>>> fix and this will be REJECTED. >>>>> If this is correct and is what Windows does, then state so. >>>>> Otherwise, >>>>> withdraw the patch and fix it the right way. >>>>> >>>>> James McKenzie >>>>> >>>> Frankly, I do not know what Microsoft does, but the test would fail on >>>> their implementation if they did something else, so I think it is safe >>>> to assume the test is implemented properly. Given that, the fixme is >>>> wrong. >> You had very well much know what Microsoft does and care very much about >> what they do. The goal of this project, as it has been since the mid >> 1990s is to fully emulate, bug and all, the Microsoft Windows32 and >> Windows64 (since 64 bit versions of Windows arrived) APIs. Thus we have >> test cases that demonstrate what the actions are of the API/ABI. That is >> what I've been working on with several richedit functions that I need to >> have for programs that I personally use. I'm 'eating my own dog food' to >> speak. >> > Since I do not have (and should never have if I work on Wine) access to > Microsoft's code, I can not know what they actually do. Upon the insistance of AJ and others, I will no longer be working on or for the Wine project. Your code does have an error, it was just recently pointed out that the return value was incorrect. Thank you for sufficiently flogging me with the whip I was attempting to flog you with. James McKenzie

1 0

Re: [PATCH] libs/wpp: Fixed bug in preventing add_text_to_macro from handling macros over 1 kb large
by André Hentschel 25 Jul '10

25 Jul '10

Hi, Your Patch got wrapped. Try change some settings in you Mailclient please and resubmit. Thx -- Best Regards, André Hentschel

1 0

Re: Any more infos about the build failure for my (small) patch
by James Mckenzie 25 Jul '10

25 Jul '10

Octavian Voicu wrote: >On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes ><bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: >> Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root >> Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h >> >> Ah, Readhat defining in it's own way. >> What about debian? >> >> Isn't the OpenSSL documentation way th way it should be? > >Ubuntu also has /usr/include/openssl/ssl.h. >Linux manpages show the same thing: http://linux.die.net/man/3/ssl_ctx_new > >Maybe this should go in autoconf? > Have to check the effect on other UNIX variations, including MacOSX before doing this. Looks like a good idea, however. James McKenzie

4 4

Sorry for all the repeat emails :(
by Misha Koshelev 24 Jul '10

24 Jul '10

They did not seem to go through this morning. My apologies for the (apparently unnecessary) resends. Misha

1 0

Re: [2/2] shell32/tests: CommandLineToArgvW("") shouldn't truncate returned exe path. (resend)
by testbot＠testbot.winehq.org 24 Jul '10

24 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3816 Your paranoid android. === WVISTAADM (32 bit shlexec) === shlexec.c:192: Test failed: WaitForSingleObject(hProcess) returned 258 === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wtBAC3.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

Re: [PATCH 2/7] msvcp90/tests: Added allocator<char> tests
by testbot＠testbot.winehq.org 24 Jul '10

24 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3813 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

RFC: winex11.drv: drag from X, drop to OLE (try 3)
by Damjan Jovanovic 24 Jul '10

24 Jul '10

Hi This is my third attempt at a patch for dragging from X and dropping to Wine, with the more advanced OLE drag and drop. This attempt doesn't add a public API to OLE and instead uses the cross-process drag and drop framework implemented by commit 6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786. The previous attempt was http://www.winehq.org/pipermail/wine-patches/2007-August/042910.html. I am not expecting this to get accepted yet, just posting to wine-devel to get some feedback on the overall design. Thank you Damjan Jovanovic

1 0

Re: [1/5] gameux: Add initial implementation of gameux.dll
by Henri Verbeet 24 Jul '10

24 Jul '10

2010/7/18 Mariusz Pluciński <vshader(a)gmail.com>: > +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: > + * DllRegisterServer (OLEAUT32.@)

5 4