July 2010 - Wine-devel - list.winehq.org

RFC: draft HLSL test suite
by Travis Athougies 23 Jul '10

23 Jul '10

Henri, Thanks for the quick reply. So I got rid of the maze of structures and instead called the helper functions directly for each test. The tests are now much easier to understand. Is there anything else that should be incorporated into these tests? Any other ideas or suggestions? Travis Athougies On Thu, Jul 22, 2010 at 3:16 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 21 July 2010 23:46, Travis Athougies <iammisc(a)gmail.com> wrote: >> an HLSL test suite might be a good place to start, so here's a draft >> of a test framework and a few tests that use it. It's not complete, I >> know (for one, I need to write tests for vertex shaders), but before I >> go any farther, I'd like to know get peoples' opinion on the design. >> Is this the way a wine HLSL test suite should look? Is there something >> else I should incorporate into these tests? I'm absolutely open to >> suggestions. > Leaving the (fairly significant) specific issues with the > implementation aside, the basic idea will work, but it seems to me > you're making it more complicated than it needs to be. This really > doesn't need to be much more complex than the tests in > dlls/d3d9/tests/visual.c, though a bit more generic would be nice. > >> http://wiki.winehq.org/HLSLTestSuite > That page is pretty awful. > -- Travis Athougies -- Travis Athougies

1 0

Re: [1/5] shdocvw: Add menu bar to Internet Explorer (try2)
by Frédéric Delanoy 23 Jul '10

23 Jul '10

2010/7/21 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>: > This series adds a menu bar and Open URL dialog box to Wine's IE. > > try2: > - Fix errors pointed out by Jacek > - Don't use ExecWB() until we can be sure it uses CGID_MSHTML > Alexander N. Sørnes You should merge the "New" and "Window" in a single menu entry (New window) A submenu with only one entry is not useful IMHO. It increases for no reason the # of clicks/key typed. Besides, it can make translation a bit more difficult (in some languages, the adjective is written differently according to the "gender" of the noun) Frédéric

1 0

re: RFC: draft HLSL test suite
by Dan Kegel 23 Jul '10

23 Jul '10

Henri wrote: >> http://wiki.winehq.org/HLSLTestSuite > That page is pretty awful. Yep, it was written very quickly by somebody who doesn't know d3d at all. Now that somebody's working on an HLSL test suite, it can fade away, or maybe be replaced with a description of the final test suite, if that makes sense. - Dan

1 0

Build error introduced by f1ea06375d76c9f8e181e3ee4874ddef661e80c2
by Octavian Voicu 23 Jul '10

23 Jul '10

Seems that f1ea06375d76c9f8e181e3ee4874ddef661e80c2 introduces a build error on Ubuntu with gcc 4.4.3. [...] ccache gcc -m32 -c -I../../../wine-git/dlls/user32 -I. -I../../../wine-git/include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -D_FORTIFY_SOURCE=0 -o painting.o ../../../wine-git/dlls/user32/painting.c ../../../wine-git/dlls/user32/painting.c: In function ‘GetDCEx’: ../../../wine-git/dlls/user32/painting.c:913: error: initializer element is not constant $ gcc --version gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. According to [1] this is not a compiler bug: the C standard says the expression is not constant. I wonder why I'm the only one who gets this error. Octavian [1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20426

2 1

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW
by Vitaliy Margolen 23 Jul '10

23 Jul '10

On 07/21/2010 10:23 AM, Andrew Eikum wrote: Please more-less follow the format of the file and don't add yet one more. > + if(outLen == 0) > + return 0; Need space between "if" and "(". > + if(!buf){ Curly bracket goes on to separate line. > + buf = HeapAlloc(GetProcessHeap(), 0, outLen * sizeof(WCHAR)); > + ret = GetPrivateProfileStringW(appName, keyName, NULL, buf, outLen, filename); > + strcpyW(out, buf); > + HeapFree(GetProcessHeap(), 0, buf); Why do you need extra buffer here? Use passed buffer instead. Vitaliy.

3 2

Any more infos about the build failure for my (small) patch
by Uwe Bonnes 23 Jul '10

23 Jul '10

Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static SSL_METHOD *method; is flagges as an warning. My patch exchanged -static SSL_METHOD *method; +static const SSL_METHOD *method; but http://source.winehq.org/patches/ flags 63746 Build failure Uwe Bonnes Add-missing-const-qualifier.patc Can anybody give more information? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 4

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.
by Misha Koshelev 23 Jul '10

23 Jul '10

> > +static DWORD compute_sphere_test_index_data(FLOAT radius, UINT slices, UINT stacks) > I haven't really thought this through yet, but would it perhaps be > simpler to calculate the faces a vertex is part of, instead of the > other way around? > Please find attached the relevant data. I do not see a way from this data to generate the faces a vertex is part of that would be simpler than what I am doing for indices. However, if you have any suggestions, I would very much appreciate them. Thank you as always for your careful review of my patches. Misha

2 1

Re: cmd: Fix cmd's mishandling of quote-enclosed command strings
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3778 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W2KPROSP4 (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === WXPPROSP3 (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W2K3R2SESP2 (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === WVISTAADM (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W2K8SE (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W7PRO (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W7PROX64 (32 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74 === W7PROX64 (64 bit) === batch.c:177: Test failed: unexpected char 0x74 position 0 in line 49 (got 'test file.txt.fake', wanted 'testfile.txt.fake') batch.c:188: Test failed: unexpected end of output in line 49, expected 0x74

1 0

Re: [6/9] msi: Add some tests for MsiGetSourcePath.
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3772 Your paranoid android. === W7PROX64 (32 bit package) === package.c:8336: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8347: Test failed: Expected "C:\winetest\", got "" package.c:8358: Test failed: Expected "C:\winetest\", got "" package.c:8408: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8419: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8428: Test failed: Expected "C:\", got "" package.c:8434: Test failed: Expected "C:\winetest\", got "" package.c:8455: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8464: Test failed: Expected "C:\winetest\FileName1", got "" === W7PROX64 (64 bit package) === package.c:8336: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8347: Test failed: Expected "C:\winetest\", got "" package.c:8358: Test failed: Expected "C:\winetest\", got "" package.c:8408: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8419: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8428: Test failed: Expected "C:\", got "" package.c:8434: Test failed: Expected "C:\winetest\", got "" package.c:8455: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8464: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [5/9] msi: Set/unset the SourceDir property at the right stage in the execution sequence.
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3771 Your paranoid android. === W98SE (32 bit install) === Timeout === W2K3R2SESP2 (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:3713: Test failed: Expected imaname, got ðõ install.c:3724: Test failed: Expected 314, got 12 install.c:3730: Test failed: Expected OrderTestValue, got ðõ

1 0