July 2010 - Wine-devel - list.winehq.org

Re: [3/9] msi/tests: Properly contruct the icon path for win9x.
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3770 Your paranoid android. === W7PROX64 (32 bit install) === install.c:3565: Test failed: Expected imaname, got ðõ© install.c:3576: Test failed: Expected 314, got 12 install.c:3582: Test failed: Expected OrderTestValue, got ðõ©

1 0

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.
by Stefan Dösinger 23 Jul '10

23 Jul '10

Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > + hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw, (void **) &dd); > + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr); This is redundant, lpDD is already an IDirectDraw interface. > + hr = IDirectDraw_CreateSurface(dd, &ddsd, &surf, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface failed: 0x%08x\n", hr); This test will fail before your 3/4 patch is in, so you'll have to use todo_wine for now, and remove in the patch that implements the correct behavior. You'll have to handle the NULL pointer that is returned in case of a failure.

2 2

How about a registry key/environment variable to disable creation of .desktop files?
by Scott Ritchie 23 Jul '10

23 Jul '10

In my automated testing I've noticed that some apps create desktop links without asking and there's no way to avoid them. It's a similar situation for start menu entries. It would be nice to be able to have an entire install fully contained in a .wine folder that could be cleanly deleted after the test is done. This isn't currently the case. Would it be appropriate to have a registry key or environment variable to disable this behavior silently? Or is hacking scripts to delete individual entries afterwards the right approach? Thanks, Scott Ritchie

2 1

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 2)
by Misha Koshelev 23 Jul '10

23 Jul '10

I hate to do this but I would rather look bad as a person than taint Wine with imperfect code. Thus, I will please ask to hold my very own patch for the moment. I don't honestly know that there is a better way to come up with indices but I have some ideas, mainly looking at: http://local.wasp.uwa.edu.au/~pbourke/miscellaneous/sphere_cylinder/ http://sol.gfxile.net/sphere/index.html Basically this would involve, rather than creating vertices & indices like we do now, creating _all_ the vertices (with duplications) and then collapsing to vertices + indices. We would have to allocate larger structures, but this may indeed solve the problem that Henri was referring to and make the index code cleaner. In any case, it would also help me take my mind off teapot ;) Thank you and hopefully you will see a better patch from me on Monday. If not, then I don't have a better one :( Misha

1 0

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the cases that count <= 1.
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3763 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

Re: [2/2] gdiplus: Implemented GdipFillClosedCurve and GdipFillClosedCurveI.
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3764 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [try 2] [2/4] d3dx9: Add basic implementation of D3DXFilterTexture, plus tests
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3760 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: user32: Implement GetUserObjectInformation with index=UOI_USER_SID
by Dmitry Timoshkov 23 Jul '10

23 Jul '10

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> wrote: > + size = 0; > + GetUserNameW( NULL, &size ); > + > + user_name = HeapAlloc( GetProcessHeap(), 0, (size + 1) * sizeof(WCHAR) ); > + if (!user_name) { > + SetLastError(ERROR_OUTOFMEMORY); > + return FALSE; > + } > + > + if (!GetUserNameW( user_name, &size )) > + { > + HeapFree( GetProcessHeap(), 0, user_name ); > + return FALSE; > + } > + > + size = 0; > + dom_size = 0; > + LookupAccountNameW( NULL, user_name, NULL, &size, NULL, &dom_size, &use ); > + > + *needed = size; > + if (info == NULL) > + { > + HeapFree( GetProcessHeap(), 0, user_name ); > + return TRUE; > + } > + > + if (len < size) > + { > + SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > + HeapFree( GetProcessHeap(), 0, user_name ); > + return FALSE; > + } > + > + dom_size = 0; > + ret = LookupAccountNameW( NULL, user_name, (PSID)info, &size, NULL, &dom_size, &use ); > + HeapFree( GetProcessHeap(), 0, user_name ); > + return ret; > + } You need to test return value of every 1st call as well as you do for every next one. -- Dmitry.

1 0

Re: [PATCH 2/4] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3756 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found === W7PRO (32 bit dsurface) === dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004 === W7PROX64 (32 bit dsurface) === dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004 === W7PROX64 (64 bit dsurface) === dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004

1 0

Re: [PATCH 2/2] comdlg32: Store and use save/open dialogs' most-recently-used data
by testbot＠testbot.winehq.org 23 Jul '10

23 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3755 Your paranoid android. === W7PRO (32 bit filedlg) === Timeout

1 0