September 2010 - Wine-devel

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 2)
by Henri Verbeet 09 Sep '10

09 Sep '10

On 9 September 2010 02:40, Misha Koshelev <misha680(a)gmail.com> wrote: > + while (count < MAX_FVF_DECL_SIZE && (count == 0 || declaration[count-1].Stream != 0xFF)) > + { > + count++; > + } > + if (count > 1) > + { > + vertex_size = declaration[count-2].Offset + d3dx_decltype_size[declaration[count-2].Type]; > + } You may want to consider using D3DXGetDeclVertexSize() there.

1 0

Re: dlls/rstrtmgr: add stubs for RmGetList and RmRegisterResources
by Paul Vriens 09 Sep '10

09 Sep '10

On 09/09/2010 07:41 AM, Austin English wrote: > +@ stdcall RmGetList(long ptr ptr ptr) Hi Austin, This function has 5 parameters. -- Cheers, Paul.

1 0

Re: msxml3: Implement property SelectionNamespaces for XPath
by testbot＠testbot.winehq.org 09 Sep '10

09 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5150 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6002: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6002: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6002: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: shdocvw: Fixed tests on IE <6.
by testbot＠testbot.winehq.org 09 Sep '10

09 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === WVISTAADM (32 bit webbrowser) === webbrowser.c:1210: Test failed: unexpected call UpdateUI webbrowser.c:289: Test failed: unexpected nsCmdID 21 webbrowser.c:233: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [try 2] [1/3] dsound: Add support for 32-bit IEEE float buffers
by Chris Robinson 08 Sep '10

08 Sep '10

On Wednesday, September 08, 2010 11:02:27 am Owen Rudge wrote: > + *(BYTE *) dst = (clamp(le32(*(const float *)src), -1, 1)) * 127 + > 0.5; Is it safe to call le32 on a float? Especially one that's going to be used more? If the system is big-endian, the float/integer will need to be in big- endian to be processed. I'm also not sure that the conversion math is correct. In this case, -1.0 would get converted to -126.5 (or -32766.5, etc), instead of -128 (or -32768, etc). As well, I don't think the rules for converting a negative float value to an unsigned integer are that straight forward. I seem to recall mention that some systems will actually give 0 in that case. You may have to go the long way and do something like: float v = *(const float*)src; if(v < -1.0f) *(__int8*)dst = -128; if(v < 0.0f) *(__int8*)dst = v*128.0f; if(v > 1.0f) *(__int8*)dst = 127; if(v >= 0.0f) *(__int8*)dst = v*127.0f; ..and similarly for 16/24/32 bit.

2 1

Mistake in : msxml3: Don't use xmlnode's IXMLDOMNode iface in get_[first|last]Node implementations.
by Joris Huizer 08 Sep '10

08 Sep '10

Hello, I noticed some copy/paste mistake in this patch; A number of functions for *get_lastChild now call node_get_first_child. HTH, Joris

2 1

daily wine clang tests
by Austin English 08 Sep '10

08 Sep '10

Howdy all, I've added a daily test of wine/winetest compiled using clang (tag wine_ae-ub1004-clang). I fixed the first bug it found (http://source.winehq.org/git/wine.git/?a=commitdiff;h=7f30ae6349e01095823e6…) but there are a few more failures that look interesting (interesting = crashes with clang, but not gcc): http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… http://test.winehq.org/data/ec382f43452890354b9edd30ecb7d293045bb8c2/wine_a… msi in particular doesn't seem to like clang. Anywho, if you want traces/patches tested, drop me a line. Cheers! -- -Austin

1 0

Re: [1/3] msi: Set more 64-bit properties.
by Alexandre Julliard 08 Sep '10

08 Sep '10

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/package.c | 43 ++++++++++++++++++++++++++++++++----------- > 1 files changed, 32 insertions(+), 11 deletions(-) This breaks the tests on 64-bit: ../../../../wine/tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so ../../../../wine/dlls/msi/tests/automation.c && touch automation.ok automation.c:2505: Test failed: File not installed automation.c:2506: Test failed: File not installed automation.c:2507: Test failed: File not installed automation.c:2508: Test failed: File not installed automation.c:2509: Test failed: File not installed automation.c:2510: Test failed: File not installed automation.c:2511: Test failed: File not installed automation.c:2512: Test failed: File not installed automation.c:2513: Test failed: File not installed automation.c:2514: Test failed: File not installed automation.c:2515: Test failed: File not installed make: *** [automation.ok] Error 11 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Right text placement (Bugfix for #22109)
by Alexandre Julliard 08 Sep '10

08 Sep '10

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > Much thanks to Konstantin Kondratyuk. He is the brain behind this bugfix. > > --- a/dlls/user32/text.c 2010-06-01 18:14:04.000000000 +0200 > +++ b/dlls/user32/text.c 2010-06-01 18:15:37.000000000 +0200 > @@ -954,8 +954,12 @@ > > if (flags & DT_SINGLELINE) > { > - if (flags & DT_VCENTER) y = rect->top + > - (rect->bottom - rect->top) / 2 - size.cy / 2; > + if (flags & DT_VCENTER) > + { > + int sign = 1; > + if (rect->top < 0 && rect->bottom < 0) sign = -1; > + y = rect->top + (rect->bottom - rect->top) / 2 - sign * size.cy / 2; This doesn't make sense, the sign should depend on the viewport mappings, not on the position being negative. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10: we are unable to shape non TMPF_TRUETYPE fonts
by Alexandre Julliard 08 Sep '10

08 Sep '10

Aric Stewart <aric(a)codeweavers.com> writes: > So return a proper error instead of generating unexpected garbage > --- > dlls/usp10/usp10.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) It fails the tests: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:907: Test failed: ScriptShape should return 0 not (80040200) make[1]: *** [usp10.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0